[INFO] updating cached repository benalexau/envoy-exporter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benalexau/envoy-exporter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benalexau/envoy-exporter" "work/ex/clippy-test-run/sources/stable/gh/benalexau/envoy-exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benalexau/envoy-exporter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benalexau/envoy-exporter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benalexau/envoy-exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benalexau/envoy-exporter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 67d6f33bde68588df3c799e479025f9f5ef864df [INFO] sha for GitHub repo benalexau/envoy-exporter: 67d6f33bde68588df3c799e479025f9f5ef864df [INFO] validating manifest of benalexau/envoy-exporter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benalexau/envoy-exporter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benalexau/envoy-exporter [INFO] finished frobbing benalexau/envoy-exporter [INFO] frobbed toml for benalexau/envoy-exporter written to work/ex/clippy-test-run/sources/stable/gh/benalexau/envoy-exporter/Cargo.toml [INFO] started frobbing benalexau/envoy-exporter [INFO] finished frobbing benalexau/envoy-exporter [INFO] frobbed toml for benalexau/envoy-exporter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benalexau/envoy-exporter/Cargo.toml [INFO] crate benalexau/envoy-exporter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benalexau/envoy-exporter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benalexau/envoy-exporter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15ee714a20ebcbb06ee7ffea5cedcabf64e5d9a0f907ef8ff02b2932fa4ce17d [INFO] running `"docker" "start" "-a" "15ee714a20ebcbb06ee7ffea5cedcabf64e5d9a0f907ef8ff02b2932fa4ce17d"` [INFO] [stderr] Compiling prometheus v0.4.2 [INFO] [stderr] Checking quick-error v0.2.2 [INFO] [stderr] Checking spin v0.4.10 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Checking libz-sys v1.0.25 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking actix v0.7.7 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking actix-net v0.2.4 [INFO] [stderr] Checking actix-web v0.7.14 [INFO] [stderr] Checking envoy-exporter v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let host = sys.host.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | let url = sys.url.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | let user = sys.user.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | let pass = sys.pass.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | let sn = sys.sn.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | let host = sys.host.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | let url = sys.url.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | let user = sys.user.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | let pass = sys.pass.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/handlers.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | let sn = sys.sn.unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.19s [INFO] running `"docker" "inspect" "15ee714a20ebcbb06ee7ffea5cedcabf64e5d9a0f907ef8ff02b2932fa4ce17d"` [INFO] running `"docker" "rm" "-f" "15ee714a20ebcbb06ee7ffea5cedcabf64e5d9a0f907ef8ff02b2932fa4ce17d"` [INFO] [stdout] 15ee714a20ebcbb06ee7ffea5cedcabf64e5d9a0f907ef8ff02b2932fa4ce17d