[INFO] updating cached repository belzile/algorithms-with-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/belzile/algorithms-with-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/belzile/algorithms-with-rust" "work/ex/clippy-test-run/sources/stable/gh/belzile/algorithms-with-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/belzile/algorithms-with-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/belzile/algorithms-with-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/belzile/algorithms-with-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/belzile/algorithms-with-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afb5df97648c054b69610842098dc47bbcec6248 [INFO] sha for GitHub repo belzile/algorithms-with-rust: afb5df97648c054b69610842098dc47bbcec6248 [INFO] validating manifest of belzile/algorithms-with-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of belzile/algorithms-with-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing belzile/algorithms-with-rust [INFO] finished frobbing belzile/algorithms-with-rust [INFO] frobbed toml for belzile/algorithms-with-rust written to work/ex/clippy-test-run/sources/stable/gh/belzile/algorithms-with-rust/Cargo.toml [INFO] started frobbing belzile/algorithms-with-rust [INFO] finished frobbing belzile/algorithms-with-rust [INFO] frobbed toml for belzile/algorithms-with-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/belzile/algorithms-with-rust/Cargo.toml [INFO] crate belzile/algorithms-with-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting belzile/algorithms-with-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/belzile/algorithms-with-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5be8f3943118eededc0d329fedd0a78c9504bd85038c16225afa8c49d64bb36d [INFO] running `"docker" "start" "-a" "5be8f3943118eededc0d329fedd0a78c9504bd85038c16225afa8c49d64bb36d"` [INFO] [stderr] Checking algorithms v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/search/binary.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod binary { [INFO] [stderr] 2 | | pub fn find(slice: &[isize], number: isize) -> isize { [INFO] [stderr] 3 | | if slice.len() == 0 { [INFO] [stderr] 4 | | return -1; [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search/binary.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search/binary.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return find(slice, number) > -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find(slice, number) > -1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/search/binary.rs:3:12 [INFO] [stderr] | [INFO] [stderr] 3 | if slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/search/binary.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod binary { [INFO] [stderr] 2 | | pub fn find(slice: &[isize], number: isize) -> isize { [INFO] [stderr] 3 | | if slice.len() == 0 { [INFO] [stderr] 4 | | return -1; [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search/binary.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/search/binary.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return find(slice, number) > -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `find(slice, number) > -1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/search/binary.rs:3:12 [INFO] [stderr] | [INFO] [stderr] 3 | if slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/search/binary.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | assert!(binary::any(&v, 9) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!binary::any(&v, 9)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "5be8f3943118eededc0d329fedd0a78c9504bd85038c16225afa8c49d64bb36d"` [INFO] running `"docker" "rm" "-f" "5be8f3943118eededc0d329fedd0a78c9504bd85038c16225afa8c49d64bb36d"` [INFO] [stdout] 5be8f3943118eededc0d329fedd0a78c9504bd85038c16225afa8c49d64bb36d