[INFO] updating cached repository beefsack/rbasic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/beefsack/rbasic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/beefsack/rbasic" "work/ex/clippy-test-run/sources/stable/gh/beefsack/rbasic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/beefsack/rbasic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/beefsack/rbasic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beefsack/rbasic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beefsack/rbasic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 585869f942b47fe6d18b777e099a603438192882 [INFO] sha for GitHub repo beefsack/rbasic: 585869f942b47fe6d18b777e099a603438192882 [INFO] validating manifest of beefsack/rbasic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of beefsack/rbasic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing beefsack/rbasic [INFO] finished frobbing beefsack/rbasic [INFO] frobbed toml for beefsack/rbasic written to work/ex/clippy-test-run/sources/stable/gh/beefsack/rbasic/Cargo.toml [INFO] started frobbing beefsack/rbasic [INFO] finished frobbing beefsack/rbasic [INFO] frobbed toml for beefsack/rbasic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beefsack/rbasic/Cargo.toml [INFO] crate beefsack/rbasic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting beefsack/rbasic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/beefsack/rbasic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3b067550f7c58d7c13269288af862e95e7229f73937771b747def8945ecd446 [INFO] running `"docker" "start" "-a" "f3b067550f7c58d7c13269288af862e95e7229f73937771b747def8945ecd446"` [INFO] [stderr] Checking rbasic v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/io.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/io.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/io.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if self.buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/parser/io.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 49 | let mut rem_buf = Vec::with_capacity(diff); [INFO] [stderr] | ------------------------ help: consider replace allocation with: `vec![0; diff]` [INFO] [stderr] 50 | rem_buf.extend(iter::repeat(0).take(diff)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/io.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | if self.buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/parser/io.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 49 | let mut rem_buf = Vec::with_capacity(diff); [INFO] [stderr] | ------------------------ help: consider replace allocation with: `vec![0; diff]` [INFO] [stderr] 50 | rem_buf.extend(iter::repeat(0).take(diff)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.78s [INFO] running `"docker" "inspect" "f3b067550f7c58d7c13269288af862e95e7229f73937771b747def8945ecd446"` [INFO] running `"docker" "rm" "-f" "f3b067550f7c58d7c13269288af862e95e7229f73937771b747def8945ecd446"` [INFO] [stdout] f3b067550f7c58d7c13269288af862e95e7229f73937771b747def8945ecd446