[INFO] updating cached repository bddap/automata [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bddap/automata [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bddap/automata" "work/ex/clippy-test-run/sources/stable/gh/bddap/automata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bddap/automata'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bddap/automata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/automata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/automata'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce6314778f9c6b22e2af8477ffc34ca4625f6289 [INFO] sha for GitHub repo bddap/automata: ce6314778f9c6b22e2af8477ffc34ca4625f6289 [INFO] validating manifest of bddap/automata on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bddap/automata on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bddap/automata [INFO] finished frobbing bddap/automata [INFO] frobbed toml for bddap/automata written to work/ex/clippy-test-run/sources/stable/gh/bddap/automata/Cargo.toml [INFO] started frobbing bddap/automata [INFO] finished frobbing bddap/automata [INFO] frobbed toml for bddap/automata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/automata/Cargo.toml [INFO] crate bddap/automata has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bddap/automata against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bddap/automata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c65ef477f134d2897284973f5606f457d0cb7863c11a9ea367d7f92c09b5260 [INFO] running `"docker" "start" "-a" "4c65ef477f134d2897284973f5606f457d0cb7863c11a9ea367d7f92c09b5260"` [INFO] [stderr] Checking terminal_graphics v0.1.5 [INFO] [stderr] Checking terminal_size v0.1.7 [INFO] [stderr] Checking automata v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `GameOfLife` [INFO] [stderr] --> src/automata.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | GameOfLife(bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | fn is_succeptible_to_liquid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | fn wet(&self, wetness: u8) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | fn powered(&self, pow: u8) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | fn inflict(&self, other: Self, direction: Direction) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | fn resolve_infliction(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GameOfLife` [INFO] [stderr] --> src/automata.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | GameOfLife(bool), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | fn is_succeptible_to_liquid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | fn wet(&self, wetness: u8) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | fn powered(&self, pow: u8) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | fn inflict(&self, other: Self, direction: Direction) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/automata.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | fn resolve_infliction(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `"docker" "inspect" "4c65ef477f134d2897284973f5606f457d0cb7863c11a9ea367d7f92c09b5260"` [INFO] running `"docker" "rm" "-f" "4c65ef477f134d2897284973f5606f457d0cb7863c11a9ea367d7f92c09b5260"` [INFO] [stdout] 4c65ef477f134d2897284973f5606f457d0cb7863c11a9ea367d7f92c09b5260