[INFO] updating cached repository bddap/anagram-solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bddap/anagram-solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bddap/anagram-solver" "work/ex/clippy-test-run/sources/stable/gh/bddap/anagram-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bddap/anagram-solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bddap/anagram-solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/anagram-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/anagram-solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3c84d24a08eae564d9d4a0bc73504c5d407ba36 [INFO] sha for GitHub repo bddap/anagram-solver: b3c84d24a08eae564d9d4a0bc73504c5d407ba36 [INFO] validating manifest of bddap/anagram-solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bddap/anagram-solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bddap/anagram-solver [INFO] finished frobbing bddap/anagram-solver [INFO] frobbed toml for bddap/anagram-solver written to work/ex/clippy-test-run/sources/stable/gh/bddap/anagram-solver/Cargo.toml [INFO] started frobbing bddap/anagram-solver [INFO] finished frobbing bddap/anagram-solver [INFO] frobbed toml for bddap/anagram-solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bddap/anagram-solver/Cargo.toml [INFO] crate bddap/anagram-solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bddap/anagram-solver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bddap/anagram-solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] beb1bff1832f5fc624356118d8e6a139243c5d1def99bc84257f9d506d99566b [INFO] running `"docker" "start" "-a" "beb1bff1832f5fc624356118d8e6a139243c5d1def99bc84257f9d506d99566b"` [INFO] [stderr] Compiling enum-map-derive v0.4.0 [INFO] [stderr] Checking enum-map v0.4.1 [INFO] [stderr] Checking anagram-solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from_byte(cha: &u8) -> Option { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/solver.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|word| CountedWord::from_word(word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CountedWord::from_word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/solver.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn find<'a>(wl: &WordList, target: LetterCounts) -> Option>> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/solver.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match target.checked_sub(&word.counts) { [INFO] [stderr] 212 | | Some(new_target) => match _find(wl, letter, new_target) { [INFO] [stderr] 213 | | Some(mut vec) => { [INFO] [stderr] 214 | | vec.push(word); [INFO] [stderr] ... | [INFO] [stderr] 219 | | None => {} [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 211 | if let Some(new_target) = target.checked_sub(&word.counts) { match _find(wl, letter, new_target) { [INFO] [stderr] 212 | Some(mut vec) => { [INFO] [stderr] 213 | vec.push(word); [INFO] [stderr] 214 | return Some(vec); [INFO] [stderr] 215 | } [INFO] [stderr] 216 | None => {} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/solver.rs:212:33 [INFO] [stderr] | [INFO] [stderr] 212 | Some(new_target) => match _find(wl, letter, new_target) { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 213 | | Some(mut vec) => { [INFO] [stderr] 214 | | vec.push(word); [INFO] [stderr] 215 | | return Some(vec); [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | None => {} [INFO] [stderr] 218 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | Some(new_target) => if let Some(mut vec) = _find(wl, letter, new_target) { [INFO] [stderr] 213 | vec.push(word); [INFO] [stderr] 214 | return Some(vec); [INFO] [stderr] 215 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:35:27 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from_byte(cha: &u8) -> Option { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/solver.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|word| CountedWord::from_word(word)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `CountedWord::from_word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/solver.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn find<'a>(wl: &WordList, target: LetterCounts) -> Option>> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/solver.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match target.checked_sub(&word.counts) { [INFO] [stderr] 212 | | Some(new_target) => match _find(wl, letter, new_target) { [INFO] [stderr] 213 | | Some(mut vec) => { [INFO] [stderr] 214 | | vec.push(word); [INFO] [stderr] ... | [INFO] [stderr] 219 | | None => {} [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 211 | if let Some(new_target) = target.checked_sub(&word.counts) { match _find(wl, letter, new_target) { [INFO] [stderr] 212 | Some(mut vec) => { [INFO] [stderr] 213 | vec.push(word); [INFO] [stderr] 214 | return Some(vec); [INFO] [stderr] 215 | } [INFO] [stderr] 216 | None => {} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/solver.rs:212:33 [INFO] [stderr] | [INFO] [stderr] 212 | Some(new_target) => match _find(wl, letter, new_target) { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 213 | | Some(mut vec) => { [INFO] [stderr] 214 | | vec.push(word); [INFO] [stderr] 215 | | return Some(vec); [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | None => {} [INFO] [stderr] 218 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | Some(new_target) => if let Some(mut vec) = _find(wl, letter, new_target) { [INFO] [stderr] 213 | vec.push(word); [INFO] [stderr] 214 | return Some(vec); [INFO] [stderr] 215 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.19s [INFO] running `"docker" "inspect" "beb1bff1832f5fc624356118d8e6a139243c5d1def99bc84257f9d506d99566b"` [INFO] running `"docker" "rm" "-f" "beb1bff1832f5fc624356118d8e6a139243c5d1def99bc84257f9d506d99566b"` [INFO] [stdout] beb1bff1832f5fc624356118d8e6a139243c5d1def99bc84257f9d506d99566b