[INFO] updating cached repository bchallenor/drawbridge
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bchallenor/drawbridge
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bchallenor/drawbridge" "work/ex/clippy-test-run/sources/stable/gh/bchallenor/drawbridge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bchallenor/drawbridge'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bchallenor/drawbridge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bchallenor/drawbridge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bchallenor/drawbridge'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b4166613291a409f1a6ace820f50474fe5e685f8
[INFO] sha for GitHub repo bchallenor/drawbridge: b4166613291a409f1a6ace820f50474fe5e685f8
[INFO] validating manifest of bchallenor/drawbridge on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bchallenor/drawbridge on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bchallenor/drawbridge
[INFO] finished frobbing bchallenor/drawbridge
[INFO] frobbed toml for bchallenor/drawbridge written to work/ex/clippy-test-run/sources/stable/gh/bchallenor/drawbridge/Cargo.toml
[INFO] started frobbing bchallenor/drawbridge
[INFO] finished frobbing bchallenor/drawbridge
[INFO] frobbed toml for bchallenor/drawbridge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bchallenor/drawbridge/Cargo.toml
[INFO] crate bchallenor/drawbridge has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting bchallenor/drawbridge against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bchallenor/drawbridge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e500f9ec62506a2ed53d71e98f4e655f2d73d2e2a563a59281a09795011bfd3e
[INFO] running `"docker" "start" "-a" "e500f9ec62506a2ed53d71e98f4e655f2d73d2e2a563a59281a09795011bfd3e"`
[INFO] [stderr]     Checking ipnet v1.0.0
[INFO] [stderr]     Checking tokio-executor v0.1.1
[INFO] [stderr]    Compiling rusoto_core v0.32.0
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking tokio-threadpool v0.1.1
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio v0.1.4
[INFO] [stderr]     Checking tokio-core v0.1.16
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.11.24
[INFO] [stderr]     Checking hyper-tls v0.1.3
[INFO] [stderr]     Checking rusoto_credential v0.11.0
[INFO] [stderr]     Checking rusoto_ec2 v0.32.0
[INFO] [stderr]     Checking rusoto_route53 v0.32.0
[INFO] [stderr]     Checking drawbridge v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cloud/aws/firewall.rs:193:9
[INFO] [stderr]     |
[INFO] [stderr] 193 |         ip_ranges: ip_ranges,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_ranges`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cloud/aws/firewall.rs:194:9
[INFO] [stderr]     |
[INFO] [stderr] 194 |         ipv_6_ranges: ipv_6_ranges,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ipv_6_ranges`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cloud/aws/instance.rs:48:21
[INFO] [stderr]    |
[INFO] [stderr] 48 |                     id: id,
[INFO] [stderr]    |                     ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cloud/aws/firewall.rs:193:9
[INFO] [stderr]     |
[INFO] [stderr] 193 |         ip_ranges: ip_ranges,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip_ranges`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cloud/aws/firewall.rs:194:9
[INFO] [stderr]     |
[INFO] [stderr] 194 |         ipv_6_ranges: ipv_6_ranges,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ipv_6_ranges`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cloud/aws/instance.rs:48:21
[INFO] [stderr]    |
[INFO] [stderr] 48 |                     id: id,
[INFO] [stderr]    |                     ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cli/dispatch.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 | /                 if let &Some(ref instance_type) = instance_type {
[INFO] [stderr] 65 | |                     instance.try_ensure_instance_type(instance_type)?;
[INFO] [stderr] 66 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 if let Some(ref instance_type) = *instance_type {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/cloud/aws/firewall.rs:165:45
[INFO] [stderr]     |
[INFO] [stderr] 165 |       let (ip_protocol, from_port, to_port) = match ip_protocol {
[INFO] [stderr]     |  _____________________________________________^
[INFO] [stderr] 166 | |         &IpProtocol::Tcp(IpPortRange(from, to)) => ("tcp", from, to),
[INFO] [stderr] 167 | |         &IpProtocol::Udp(IpPortRange(from, to)) => ("udp", from, to),
[INFO] [stderr] 168 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 165 |     let (ip_protocol, from_port, to_port) = match *ip_protocol {
[INFO] [stderr] 166 |         IpProtocol::Tcp(IpPortRange(from, to)) => ("tcp", from, to),
[INFO] [stderr] 167 |         IpProtocol::Udp(IpPortRange(from, to)) => ("udp", from, to),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/iprules.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         match self {
[INFO] [stderr] 54 | |             &IpProtocol::Tcp(ref range) => write!(f, "{}/tcp", range),
[INFO] [stderr] 55 | |             &IpProtocol::Udp(ref range) => write!(f, "{}/udp", range),
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 53 |         match *self {
[INFO] [stderr] 54 |             IpProtocol::Tcp(ref range) => write!(f, "{}/tcp", range),
[INFO] [stderr] 55 |             IpProtocol::Udp(ref range) => write!(f, "{}/udp", range),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/cli/dispatch.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 | /                 if let &Some(ref instance_type) = instance_type {
[INFO] [stderr] 65 | |                     instance.try_ensure_instance_type(instance_type)?;
[INFO] [stderr] 66 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 if let Some(ref instance_type) = *instance_type {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/cli/dispatch.rs:293:9
[INFO] [stderr]     |
[INFO] [stderr] 293 | /         if let &Some(ref instance_type) = &instance_type {
[INFO] [stderr] 294 | |             assert_eq!(*instance_type, running_state.unwrap().instance_type);
[INFO] [stderr] 295 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 293 |         if let Some(ref instance_type) = instance_type {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/cloud/aws/firewall.rs:165:45
[INFO] [stderr]     |
[INFO] [stderr] 165 |       let (ip_protocol, from_port, to_port) = match ip_protocol {
[INFO] [stderr]     |  _____________________________________________^
[INFO] [stderr] 166 | |         &IpProtocol::Tcp(IpPortRange(from, to)) => ("tcp", from, to),
[INFO] [stderr] 167 | |         &IpProtocol::Udp(IpPortRange(from, to)) => ("udp", from, to),
[INFO] [stderr] 168 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 165 |     let (ip_protocol, from_port, to_port) = match *ip_protocol {
[INFO] [stderr] 166 |         IpProtocol::Tcp(IpPortRange(from, to)) => ("tcp", from, to),
[INFO] [stderr] 167 |         IpProtocol::Udp(IpPortRange(from, to)) => ("udp", from, to),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/iprules.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         match self {
[INFO] [stderr] 54 | |             &IpProtocol::Tcp(ref range) => write!(f, "{}/tcp", range),
[INFO] [stderr] 55 | |             &IpProtocol::Udp(ref range) => write!(f, "{}/udp", range),
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 53 |         match *self {
[INFO] [stderr] 54 |             IpProtocol::Tcp(ref range) => write!(f, "{}/tcp", range),
[INFO] [stderr] 55 |             IpProtocol::Udp(ref range) => write!(f, "{}/udp", range),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 17s
[INFO] running `"docker" "inspect" "e500f9ec62506a2ed53d71e98f4e655f2d73d2e2a563a59281a09795011bfd3e"`
[INFO] running `"docker" "rm" "-f" "e500f9ec62506a2ed53d71e98f4e655f2d73d2e2a563a59281a09795011bfd3e"`
[INFO] [stdout] e500f9ec62506a2ed53d71e98f4e655f2d73d2e2a563a59281a09795011bfd3e