[INFO] updating cached repository bbqbaron/automaton-rustler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bbqbaron/automaton-rustler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bbqbaron/automaton-rustler" "work/ex/clippy-test-run/sources/stable/gh/bbqbaron/automaton-rustler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bbqbaron/automaton-rustler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bbqbaron/automaton-rustler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bbqbaron/automaton-rustler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bbqbaron/automaton-rustler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b2814d07c4858f98b3c3a3aedac2a6ebb716b615 [INFO] sha for GitHub repo bbqbaron/automaton-rustler: b2814d07c4858f98b3c3a3aedac2a6ebb716b615 [INFO] validating manifest of bbqbaron/automaton-rustler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bbqbaron/automaton-rustler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bbqbaron/automaton-rustler [INFO] finished frobbing bbqbaron/automaton-rustler [INFO] frobbed toml for bbqbaron/automaton-rustler written to work/ex/clippy-test-run/sources/stable/gh/bbqbaron/automaton-rustler/Cargo.toml [INFO] started frobbing bbqbaron/automaton-rustler [INFO] finished frobbing bbqbaron/automaton-rustler [INFO] frobbed toml for bbqbaron/automaton-rustler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bbqbaron/automaton-rustler/Cargo.toml [INFO] crate bbqbaron/automaton-rustler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bbqbaron/automaton-rustler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bbqbaron/automaton-rustler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8d455c32d011b601061a6cd78581b95ce74aa16e0e87ed0859e93732d6e5c9a [INFO] running `"docker" "start" "-a" "f8d455c32d011b601061a6cd78581b95ce74aa16e0e87ed0859e93732d6e5c9a"` [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.81.0 [INFO] [stderr] Checking rustlife v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `x_` is used to index `world` [INFO] [stderr] --> src/main.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | for x_ in (max(1, x) - 1)..min(x + 2, WORLD_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (x_, ) in world.iter().enumerate().take(min(x + 2, WORLD_SIZE)).skip((max(1, x) - 1)) { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | ct = ct + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ct += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `world`. [INFO] [stderr] --> src/main.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for x in 0..WORLD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for in world.iter_mut().take(WORLD_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if frame_ctr as f64 >= max_fps as f64 * evt_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(frame_ctr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `world` [INFO] [stderr] --> src/main.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | for x in 0..WORLD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (x, ) in world.iter().enumerate().take(WORLD_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x_` is used to index `world` [INFO] [stderr] --> src/main.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | for x_ in (max(1, x) - 1)..min(x + 2, WORLD_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (x_, ) in world.iter().enumerate().take(min(x + 2, WORLD_SIZE)).skip((max(1, x) - 1)) { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | ct = ct + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ct += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `world`. [INFO] [stderr] --> src/main.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for x in 0..WORLD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for in world.iter_mut().take(WORLD_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if frame_ctr as f64 >= max_fps as f64 * evt_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(frame_ctr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `world` [INFO] [stderr] --> src/main.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | for x in 0..WORLD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (x, ) in world.iter().enumerate().take(WORLD_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.35s [INFO] running `"docker" "inspect" "f8d455c32d011b601061a6cd78581b95ce74aa16e0e87ed0859e93732d6e5c9a"` [INFO] running `"docker" "rm" "-f" "f8d455c32d011b601061a6cd78581b95ce74aa16e0e87ed0859e93732d6e5c9a"` [INFO] [stdout] f8d455c32d011b601061a6cd78581b95ce74aa16e0e87ed0859e93732d6e5c9a