[INFO] updating cached repository baskerville/sketch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/baskerville/sketch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/baskerville/sketch" "work/ex/clippy-test-run/sources/stable/gh/baskerville/sketch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/baskerville/sketch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/baskerville/sketch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baskerville/sketch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baskerville/sketch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6eb22ebae2f45b9887f719b97a3dcf709e698bb4 [INFO] sha for GitHub repo baskerville/sketch: 6eb22ebae2f45b9887f719b97a3dcf709e698bb4 [INFO] validating manifest of baskerville/sketch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of baskerville/sketch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing baskerville/sketch [INFO] finished frobbing baskerville/sketch [INFO] frobbed toml for baskerville/sketch written to work/ex/clippy-test-run/sources/stable/gh/baskerville/sketch/Cargo.toml [INFO] started frobbing baskerville/sketch [INFO] finished frobbing baskerville/sketch [INFO] frobbed toml for baskerville/sketch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baskerville/sketch/Cargo.toml [INFO] crate baskerville/sketch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting baskerville/sketch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/baskerville/sketch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fbf114c4c07f9895c2c6807286a57b78092ef3754444df2fb07a97cc215a505 [INFO] running `"docker" "start" "-a" "5fbf114c4c07f9895c2c6807286a57b78092ef3754444df2fb07a97cc215a505"` [INFO] [stderr] Checking sketch v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | min: min, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | events: events, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `events` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | dims: dims, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:197:33 [INFO] [stderr] | [INFO] [stderr] 197 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:199:33 [INFO] [stderr] | [INFO] [stderr] 199 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:207:29 [INFO] [stderr] | [INFO] [stderr] 207 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 214 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:216:25 [INFO] [stderr] | [INFO] [stderr] 216 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:227:20 [INFO] [stderr] | [INFO] [stderr] 227 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:229:20 [INFO] [stderr] | [INFO] [stderr] 229 | frame_size: frame_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | set_pixel_rgb: set_pixel_rgb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `set_pixel_rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | as_rgb: as_rgb, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `as_rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | var_info: var_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `var_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | fix_info: fix_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `fix_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | waveform_mode: waveform_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `waveform_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | update_mode: update_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `update_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | update_marker: update_marker, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `update_marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | alt_buffer_data: alt_buffer_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alt_buffer_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | pt: pt, [INFO] [stderr] | ^^^^^^ help: replace it with: `pt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fb: fb, [INFO] [stderr] | ^^^^^^ help: replace it with: `fb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | events: events, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `events` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | dims: dims, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:197:33 [INFO] [stderr] | [INFO] [stderr] 197 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:199:33 [INFO] [stderr] | [INFO] [stderr] 199 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:207:29 [INFO] [stderr] | [INFO] [stderr] 207 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 214 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:216:25 [INFO] [stderr] | [INFO] [stderr] 216 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:227:20 [INFO] [stderr] | [INFO] [stderr] 227 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:229:20 [INFO] [stderr] | [INFO] [stderr] 229 | frame_size: frame_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | set_pixel_rgb: set_pixel_rgb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `set_pixel_rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | as_rgb: as_rgb, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `as_rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | var_info: var_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `var_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | fix_info: fix_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `fix_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | waveform_mode: waveform_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `waveform_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | update_mode: update_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `update_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | update_marker: update_marker, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `update_marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | alt_buffer_data: alt_buffer_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alt_buffer_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | pt: pt, [INFO] [stderr] | ^^^^^^ help: replace it with: `pt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fb: fb, [INFO] [stderr] | ^^^^^^ help: replace it with: `fb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sketch.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/geom.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 65 | | if self.y.is_positive() { [INFO] [stderr] 66 | | Dir::South [INFO] [stderr] 67 | | } else { [INFO] [stderr] 68 | | Dir::North [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if self.y.is_positive() { [INFO] [stderr] 65 | Dir::South [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | Dir::North [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/input.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | } else if evt.kind == EV_KEY { [INFO] [stderr] | ________________^ [INFO] [stderr] 222 | | if evt.code == KEY_POWER { [INFO] [stderr] 223 | | ty.send(DeviceEvent::Button { [INFO] [stderr] 224 | | time: seconds(evt.time), [INFO] [stderr] ... | [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | } else if evt.kind == EV_KEY && evt.code == KEY_POWER { [INFO] [stderr] 222 | ty.send(DeviceEvent::Button { [INFO] [stderr] 223 | time: seconds(evt.time), [INFO] [stderr] 224 | code: ButtonCode::Power, [INFO] [stderr] 225 | status: if evt.value == 1 { ButtonStatus::Pressed } else [INFO] [stderr] 226 | { ButtonStatus::Released }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:23:42 [INFO] [stderr] | [INFO] [stderr] 23 | const MXCFB_SEND_UPDATE: libc::c_ulong = 0x4044462E; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4044_462E` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:24:55 [INFO] [stderr] | [INFO] [stderr] 24 | const MXCFB_WAIT_FOR_UPDATE_COMPLETE: libc::c_ulong = 0x4004462F; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4004_462F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:400:51 [INFO] [stderr] | [INFO] [stderr] 400 | *spot.offset(0) = rgb[2] >> 3 | (rgb[1] & 0b00011100) << 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:401:37 [INFO] [stderr] | [INFO] [stderr] 401 | *spot.offset(1) = (rgb[0] & 0b11111000) | rgb[1] >> 5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:428:27 [INFO] [stderr] | [INFO] [stderr] 428 | let r = pair[1] & 0b11111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:429:29 [INFO] [stderr] | [INFO] [stderr] 429 | let g = ((pair[1] & 0b00000111) << 5) | ((pair[0] & 0b11100000) >> 3); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:429:61 [INFO] [stderr] | [INFO] [stderr] 429 | let g = ((pair[1] & 0b00000111) << 5) | ((pair[0] & 0b11100000) >> 3); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:430:28 [INFO] [stderr] | [INFO] [stderr] 430 | let b = (pair[0] & 0b00011111) << 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/geom.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 65 | | if self.y.is_positive() { [INFO] [stderr] 66 | | Dir::South [INFO] [stderr] 67 | | } else { [INFO] [stderr] 68 | | Dir::North [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 64 | } else if self.y.is_positive() { [INFO] [stderr] 65 | Dir::South [INFO] [stderr] 66 | } else { [INFO] [stderr] 67 | Dir::North [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/input.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | } else if evt.kind == EV_KEY { [INFO] [stderr] | ________________^ [INFO] [stderr] 222 | | if evt.code == KEY_POWER { [INFO] [stderr] 223 | | ty.send(DeviceEvent::Button { [INFO] [stderr] 224 | | time: seconds(evt.time), [INFO] [stderr] ... | [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | } else if evt.kind == EV_KEY && evt.code == KEY_POWER { [INFO] [stderr] 222 | ty.send(DeviceEvent::Button { [INFO] [stderr] 223 | time: seconds(evt.time), [INFO] [stderr] 224 | code: ButtonCode::Power, [INFO] [stderr] 225 | status: if evt.value == 1 { ButtonStatus::Pressed } else [INFO] [stderr] 226 | { ButtonStatus::Released }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:23:42 [INFO] [stderr] | [INFO] [stderr] 23 | const MXCFB_SEND_UPDATE: libc::c_ulong = 0x4044462E; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4044_462E` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:24:55 [INFO] [stderr] | [INFO] [stderr] 24 | const MXCFB_WAIT_FOR_UPDATE_COMPLETE: libc::c_ulong = 0x4004462F; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4004_462F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:400:51 [INFO] [stderr] | [INFO] [stderr] 400 | *spot.offset(0) = rgb[2] >> 3 | (rgb[1] & 0b00011100) << 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:401:37 [INFO] [stderr] | [INFO] [stderr] 401 | *spot.offset(1) = (rgb[0] & 0b11111000) | rgb[1] >> 5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:428:27 [INFO] [stderr] | [INFO] [stderr] 428 | let r = pair[1] & 0b11111000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:429:29 [INFO] [stderr] | [INFO] [stderr] 429 | let g = ((pair[1] & 0b00000111) << 5) | ((pair[0] & 0b11100000) >> 3); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:429:61 [INFO] [stderr] | [INFO] [stderr] 429 | let g = ((pair[1] & 0b00000111) << 5) | ((pair[0] & 0b11100000) >> 3); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/framebuffer.rs:430:28 [INFO] [stderr] | [INFO] [stderr] 430 | let b = (pair[0] & 0b00011111) << 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/geom.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn contains(&self, pt: &Point) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overlaps` [INFO] [stderr] --> src/geom.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn overlaps(&self, rect: &Rectangle) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `absorb` [INFO] [stderr] --> src/geom.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn absorb(&mut self, rect: &Rectangle) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `intersection` [INFO] [stderr] --> src/geom.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn intersection(&self, rect: &Rectangle) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `KEY_HOME` [INFO] [stderr] --> src/input.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | pub const KEY_HOME: u16 = 102; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/geom.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn contains(&self, pt: &Point) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overlaps` [INFO] [stderr] --> src/geom.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn overlaps(&self, rect: &Rectangle) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `absorb` [INFO] [stderr] --> src/geom.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn absorb(&mut self, rect: &Rectangle) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `intersection` [INFO] [stderr] --> src/geom.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn intersection(&self, rect: &Rectangle) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `KEY_HOME` [INFO] [stderr] --> src/input.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | pub const KEY_HOME: u16 = 102; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_INIT` [INFO] [stderr] --> src/framebuffer.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | const NTX_WFM_MODE_INIT: u32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_DU` [INFO] [stderr] --> src/framebuffer.rs:151:1 [INFO] [stderr] | [INFO] [stderr] 151 | const NTX_WFM_MODE_DU: u32 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GC4` [INFO] [stderr] --> src/framebuffer.rs:153:1 [INFO] [stderr] | [INFO] [stderr] 153 | const NTX_WFM_MODE_GC4: u32 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GL16` [INFO] [stderr] --> src/framebuffer.rs:155:1 [INFO] [stderr] | [INFO] [stderr] 155 | const NTX_WFM_MODE_GL16: u32 = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GLR16` [INFO] [stderr] --> src/framebuffer.rs:156:1 [INFO] [stderr] | [INFO] [stderr] 156 | const NTX_WFM_MODE_GLR16: u32 = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GLD16` [INFO] [stderr] --> src/framebuffer.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | const NTX_WFM_MODE_GLD16: u32 = 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `EPDC_FLAG_FORCE_MONOCHROME` [INFO] [stderr] --> src/framebuffer.rs:165:1 [INFO] [stderr] | [INFO] [stderr] 165 | const EPDC_FLAG_FORCE_MONOCHROME: libc::c_uint = 0x02; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Partial` [INFO] [stderr] --> src/framebuffer.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | Partial, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Gui` [INFO] [stderr] --> src/framebuffer.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | Gui, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_disk` [INFO] [stderr] --> src/framebuffer.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn draw_disk(&mut self, center: &Point, radius: u32, gray: u8) -> Rectangle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_INIT` [INFO] [stderr] --> src/framebuffer.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | const NTX_WFM_MODE_INIT: u32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: method is never used: `toggle_monochrome` [INFO] [stderr] --> src/framebuffer.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | pub fn toggle_monochrome(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: method is never used: `id` [INFO] [stderr] --> src/framebuffer.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | pub fn id(&self) -> Cow { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length` [INFO] [stderr] --> src/framebuffer.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | pub fn length(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_DU` [INFO] [stderr] --> src/framebuffer.rs:151:1 [INFO] [stderr] | [INFO] [stderr] 151 | const NTX_WFM_MODE_DU: u32 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GC4` [INFO] [stderr] --> src/framebuffer.rs:153:1 [INFO] [stderr] | [INFO] [stderr] 153 | const NTX_WFM_MODE_GC4: u32 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GL16` [INFO] [stderr] --> src/framebuffer.rs:155:1 [INFO] [stderr] | [INFO] [stderr] 155 | const NTX_WFM_MODE_GL16: u32 = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GLR16` [INFO] [stderr] --> src/framebuffer.rs:156:1 [INFO] [stderr] | [INFO] [stderr] 156 | const NTX_WFM_MODE_GLR16: u32 = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NTX_WFM_MODE_GLD16` [INFO] [stderr] --> src/framebuffer.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | const NTX_WFM_MODE_GLD16: u32 = 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `EPDC_FLAG_FORCE_MONOCHROME` [INFO] [stderr] --> src/framebuffer.rs:165:1 [INFO] [stderr] | [INFO] [stderr] 165 | const EPDC_FLAG_FORCE_MONOCHROME: libc::c_uint = 0x02; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Partial` [INFO] [stderr] --> src/framebuffer.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | Partial, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Gui` [INFO] [stderr] --> src/framebuffer.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | Gui, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_disk` [INFO] [stderr] --> src/framebuffer.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn draw_disk(&mut self, center: &Point, radius: u32, gray: u8) -> Rectangle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `toggle_monochrome` [INFO] [stderr] --> src/framebuffer.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | pub fn toggle_monochrome(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `id` [INFO] [stderr] --> src/framebuffer.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | pub fn id(&self) -> Cow { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length` [INFO] [stderr] --> src/framebuffer.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | pub fn length(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn opposite(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn axis(&self) -> Axis { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn dist2(&self, pt: &Point) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn dist2(&self, pt: &Point) -> u32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn angle(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn dir(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn opposite(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn axis(&self) -> Axis { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn dist2(&self, pt: &Point) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn dist2(&self, pt: &Point) -> u32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn angle(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:57:16 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn dir(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn from_point(pt: &Point) -> Rectangle { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn contains(&self, pt: &Point) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn from_point(pt: &Point) -> Rectangle { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn contains(&self, pt: &Point) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn merge(&mut self, pt: &Point) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn merge(&mut self, pt: &Point) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/device.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let product = env::var("PRODUCT").unwrap_or("trilogy".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "trilogy".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/device.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let product = env::var("PRODUCT").unwrap_or("trilogy".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "trilogy".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/framebuffer.rs:245:41 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn draw_disk(&mut self, center: &Point, radius: u32, gray: u8) -> Rectangle { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/framebuffer.rs:263:48 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn draw_line_segment(&mut self, start: &Point, end: &Point, gray: u8) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/framebuffer.rs:263:61 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn draw_line_segment(&mut self, start: &Point, end: &Point, gray: u8) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/framebuffer.rs:286:18 [INFO] [stderr] | [INFO] [stderr] 286 | for x in x0..(x1 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `x0..=x1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/framebuffer.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | y = y + y_step; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `y += y_step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/framebuffer.rs:245:41 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn draw_disk(&mut self, center: &Point, radius: u32, gray: u8) -> Rectangle { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/framebuffer.rs:263:48 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn draw_line_segment(&mut self, start: &Point, end: &Point, gray: u8) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/framebuffer.rs:263:61 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn draw_line_segment(&mut self, start: &Point, end: &Point, gray: u8) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/framebuffer.rs:286:18 [INFO] [stderr] | [INFO] [stderr] 286 | for x in x0..(x1 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `x0..=x1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/framebuffer.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | y = y + y_step; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `y += y_step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.14s [INFO] running `"docker" "inspect" "5fbf114c4c07f9895c2c6807286a57b78092ef3754444df2fb07a97cc215a505"` [INFO] running `"docker" "rm" "-f" "5fbf114c4c07f9895c2c6807286a57b78092ef3754444df2fb07a97cc215a505"` [INFO] [stdout] 5fbf114c4c07f9895c2c6807286a57b78092ef3754444df2fb07a97cc215a505