[INFO] updating cached repository bartolsthoorn/simhash-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bartolsthoorn/simhash-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bartolsthoorn/simhash-rs" "work/ex/clippy-test-run/sources/stable/gh/bartolsthoorn/simhash-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bartolsthoorn/simhash-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bartolsthoorn/simhash-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bartolsthoorn/simhash-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bartolsthoorn/simhash-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7fc44d12901beb7c1a3de66e2a83b89cc298dded [INFO] sha for GitHub repo bartolsthoorn/simhash-rs: 7fc44d12901beb7c1a3de66e2a83b89cc298dded [INFO] validating manifest of bartolsthoorn/simhash-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bartolsthoorn/simhash-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bartolsthoorn/simhash-rs [INFO] finished frobbing bartolsthoorn/simhash-rs [INFO] frobbed toml for bartolsthoorn/simhash-rs written to work/ex/clippy-test-run/sources/stable/gh/bartolsthoorn/simhash-rs/Cargo.toml [INFO] started frobbing bartolsthoorn/simhash-rs [INFO] finished frobbing bartolsthoorn/simhash-rs [INFO] frobbed toml for bartolsthoorn/simhash-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bartolsthoorn/simhash-rs/Cargo.toml [INFO] crate bartolsthoorn/simhash-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bartolsthoorn/simhash-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bartolsthoorn/simhash-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6219c95cfe96d257881303626bf73f3eb42e09a62f2ff15a5ceaca1fd2f72cb [INFO] running `"docker" "start" "-a" "c6219c95cfe96d257881303626bf73f3eb42e09a62f2ff15a5ceaca1fd2f72cb"` [INFO] [stderr] Checking bencher v0.1.2 [INFO] [stderr] Checking simhash v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is used to index `v` [INFO] [stderr] --> src/lib.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 0..64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (i, ) in v.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `q` is used to index `v` [INFO] [stderr] --> src/lib.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for q in 0..64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for (q, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | let distance: f64 = hamming_distance(hash1, hash2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(hamming_distance(hash1, hash2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:97:51 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(simhash("The cat sat on the mat"), 2595200813813010837); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `2_595_200_813_813_010_837` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:98:54 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(simhash("The cat sat under the mat"), 2595269945604666783); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `2_595_269_945_604_666_783` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(simhash("Why the lucky stiff"), 1155526875459215761); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_155_526_875_459_215_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:33 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(hamming_distance(0b0000000u64, 0b0000000u64), 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:47 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(hamming_distance(0b0000000u64, 0b0000000u64), 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(hamming_distance(0b1111111u64, 0b0000000u64), 7); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b111_1111u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:113:47 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(hamming_distance(0b1111111u64, 0b0000000u64), 7); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:33 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(hamming_distance(0b0100101u64, 0b1100110u64), 3); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b010_0101u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:47 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(hamming_distance(0b0100101u64, 0b1100110u64), 3); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b110_0110u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `v` [INFO] [stderr] --> src/lib.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 0..64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (i, ) in v.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `q` is used to index `v` [INFO] [stderr] --> src/lib.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for q in 0..64 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for (q, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> benches/simhash.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | for paragraph in ALICE.split("\n").cycle().take(1000) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | let distance: f64 = hamming_distance(hash1, hash2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(hamming_distance(hash1, hash2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> benches/simhash.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | benchmark_main!(benches); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(hash_similarity(0u64, 0u64), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(hash_similarity(0u64, 0u64), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(hash_similarity(!0u64, 0u64), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(hash_similarity(!0u64, 0u64), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:32 [INFO] [stderr] | [INFO] [stderr] 121 | assert_eq!(hash_similarity(!0u32 as u64, 0u64), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(!0u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | assert_eq!(hash_similarity(!0u32 as u64, 0u64), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | assert_eq!(hash_similarity(!0u32 as u64, 0u64), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(similarity("Stop hammertime", "Stop hammertime"), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(similarity("Stop hammertime", "Stop hammertime"), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Could not compile `simhash`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `simhash`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c6219c95cfe96d257881303626bf73f3eb42e09a62f2ff15a5ceaca1fd2f72cb"` [INFO] running `"docker" "rm" "-f" "c6219c95cfe96d257881303626bf73f3eb42e09a62f2ff15a5ceaca1fd2f72cb"` [INFO] [stdout] c6219c95cfe96d257881303626bf73f3eb42e09a62f2ff15a5ceaca1fd2f72cb