[INFO] updating cached repository bartnv/portlurker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bartnv/portlurker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bartnv/portlurker" "work/ex/clippy-test-run/sources/stable/gh/bartnv/portlurker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bartnv/portlurker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bartnv/portlurker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bartnv/portlurker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bartnv/portlurker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] abb0b5a068edc03ee1326801877d79bb81e14e6b [INFO] sha for GitHub repo bartnv/portlurker: abb0b5a068edc03ee1326801877d79bb81e14e6b [INFO] validating manifest of bartnv/portlurker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bartnv/portlurker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bartnv/portlurker [INFO] finished frobbing bartnv/portlurker [INFO] frobbed toml for bartnv/portlurker written to work/ex/clippy-test-run/sources/stable/gh/bartnv/portlurker/Cargo.toml [INFO] started frobbing bartnv/portlurker [INFO] finished frobbing bartnv/portlurker [INFO] frobbed toml for bartnv/portlurker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bartnv/portlurker/Cargo.toml [INFO] crate bartnv/portlurker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bartnv/portlurker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bartnv/portlurker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fca730cb3dd7a47b810d5daa720e484c3cb9ab09c7d4e0802fe7406feb848b3f [INFO] running `"docker" "start" "-a" "fca730cb3dd7a47b810d5daa720e484c3cb9ab09c7d4e0802fe7406feb848b3f"` [INFO] [stderr] Compiling libsqlite3-sys v0.8.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking rusqlite v0.12.0 [INFO] [stderr] Checking portlurker v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:168:3 [INFO] [stderr] | [INFO] [stderr] 168 | return app; // send our config to the main function [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `app` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | / if !config["general"]["print_ascii"].is_badvalue() { [INFO] [stderr] 133 | | if config["general"]["print_ascii"].as_bool().unwrap() { [INFO] [stderr] 134 | | app.print_ascii = true; [INFO] [stderr] 135 | | println!("Printing ASCII"); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 132 | if !config["general"]["print_ascii"].is_badvalue() && config["general"]["print_ascii"].as_bool().unwrap() { [INFO] [stderr] 133 | app.print_ascii = true; [INFO] [stderr] 134 | println!("Printing ASCII"); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:138:3 [INFO] [stderr] | [INFO] [stderr] 138 | / if !config["general"]["print_binary"].is_badvalue() { [INFO] [stderr] 139 | | if config["general"]["print_binary"].as_bool().unwrap() { [INFO] [stderr] 140 | | app.print_binary = true; [INFO] [stderr] 141 | | println!("Printing binary in hexadecimal"); [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if !config["general"]["print_binary"].is_badvalue() && config["general"]["print_binary"].as_bool().unwrap() { [INFO] [stderr] 139 | app.print_binary = true; [INFO] [stderr] 140 | println!("Printing binary in hexadecimal"); [INFO] [stderr] 141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:144:3 [INFO] [stderr] | [INFO] [stderr] 144 | / if !config["general"]["file_logging"].is_badvalue() { [INFO] [stderr] 145 | | if config["general"]["file_logging"].as_bool().unwrap() { [INFO] [stderr] 146 | | app.file_logging = true; [INFO] [stderr] 147 | | println!("Logging to local text file"); [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 144 | if !config["general"]["file_logging"].is_badvalue() && config["general"]["file_logging"].as_bool().unwrap() { [INFO] [stderr] 145 | app.file_logging = true; [INFO] [stderr] 146 | println!("Logging to local text file"); [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | / if !config["general"]["sql_logging"].is_badvalue() { [INFO] [stderr] 151 | | if config["general"]["sql_logging"].as_bool().unwrap() { [INFO] [stderr] 152 | | match Connection::open("portlurker.sqlite") { [INFO] [stderr] 153 | | Ok(conn) => { app.sql_logging = true; [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 150 | if !config["general"]["sql_logging"].is_badvalue() && config["general"]["sql_logging"].as_bool().unwrap() { [INFO] [stderr] 151 | match Connection::open("portlurker.sqlite") { [INFO] [stderr] 152 | Ok(conn) => { app.sql_logging = true; [INFO] [stderr] 153 | println!("Logging to local SQL database file portlurker.sqlite"); [INFO] [stderr] 154 | conn.execute("CREATE TABLE IF NOT EXISTS connections ( [INFO] [stderr] 155 | id INTEGER PRIMARY KEY, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | else { [INFO] [stderr] | __________________________^ [INFO] [stderr] 282 | | if found { [INFO] [stderr] 283 | | if i-start == 1 { [INFO] [stderr] 284 | | if (start > 0) && (buf[start-1] == 0) { [INFO] [stderr] ... | [INFO] [stderr] 295 | | } [INFO] [stderr] 296 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 281 | else if found { [INFO] [stderr] 282 | if i-start == 1 { [INFO] [stderr] 283 | if (start > 0) && (buf[start-1] == 0) { [INFO] [stderr] 284 | mbstring.push(buf[i-1] as char); [INFO] [stderr] 285 | if !mbfound { mbfound = true; } [INFO] [stderr] 286 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:168:3 [INFO] [stderr] | [INFO] [stderr] 168 | return app; // send our config to the main function [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `app` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | / if !config["general"]["print_ascii"].is_badvalue() { [INFO] [stderr] 133 | | if config["general"]["print_ascii"].as_bool().unwrap() { [INFO] [stderr] 134 | | app.print_ascii = true; [INFO] [stderr] 135 | | println!("Printing ASCII"); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 132 | if !config["general"]["print_ascii"].is_badvalue() && config["general"]["print_ascii"].as_bool().unwrap() { [INFO] [stderr] 133 | app.print_ascii = true; [INFO] [stderr] 134 | println!("Printing ASCII"); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:138:3 [INFO] [stderr] | [INFO] [stderr] 138 | / if !config["general"]["print_binary"].is_badvalue() { [INFO] [stderr] 139 | | if config["general"]["print_binary"].as_bool().unwrap() { [INFO] [stderr] 140 | | app.print_binary = true; [INFO] [stderr] 141 | | println!("Printing binary in hexadecimal"); [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if !config["general"]["print_binary"].is_badvalue() && config["general"]["print_binary"].as_bool().unwrap() { [INFO] [stderr] 139 | app.print_binary = true; [INFO] [stderr] 140 | println!("Printing binary in hexadecimal"); [INFO] [stderr] 141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:144:3 [INFO] [stderr] | [INFO] [stderr] 144 | / if !config["general"]["file_logging"].is_badvalue() { [INFO] [stderr] 145 | | if config["general"]["file_logging"].as_bool().unwrap() { [INFO] [stderr] 146 | | app.file_logging = true; [INFO] [stderr] 147 | | println!("Logging to local text file"); [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 144 | if !config["general"]["file_logging"].is_badvalue() && config["general"]["file_logging"].as_bool().unwrap() { [INFO] [stderr] 145 | app.file_logging = true; [INFO] [stderr] 146 | println!("Logging to local text file"); [INFO] [stderr] 147 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | / if !config["general"]["sql_logging"].is_badvalue() { [INFO] [stderr] 151 | | if config["general"]["sql_logging"].as_bool().unwrap() { [INFO] [stderr] 152 | | match Connection::open("portlurker.sqlite") { [INFO] [stderr] 153 | | Ok(conn) => { app.sql_logging = true; [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 150 | if !config["general"]["sql_logging"].is_badvalue() && config["general"]["sql_logging"].as_bool().unwrap() { [INFO] [stderr] 151 | match Connection::open("portlurker.sqlite") { [INFO] [stderr] 152 | Ok(conn) => { app.sql_logging = true; [INFO] [stderr] 153 | println!("Logging to local SQL database file portlurker.sqlite"); [INFO] [stderr] 154 | conn.execute("CREATE TABLE IF NOT EXISTS connections ( [INFO] [stderr] 155 | id INTEGER PRIMARY KEY, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | else { [INFO] [stderr] | __________________________^ [INFO] [stderr] 282 | | if found { [INFO] [stderr] 283 | | if i-start == 1 { [INFO] [stderr] 284 | | if (start > 0) && (buf[start-1] == 0) { [INFO] [stderr] ... | [INFO] [stderr] 295 | | } [INFO] [stderr] 296 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 281 | else if found { [INFO] [stderr] 282 | if i-start == 1 { [INFO] [stderr] 283 | if (start > 0) && (buf[start-1] == 0) { [INFO] [stderr] 284 | mbstring.push(buf[i-1] as char); [INFO] [stderr] 285 | if !mbfound { mbfound = true; } [INFO] [stderr] 286 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:99:6 [INFO] [stderr] | [INFO] [stderr] 99 | if dotline.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dotline.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:176:39 [INFO] [stderr] | [INFO] [stderr] 176 | for &(_, pattern) in BINARY_MATCHES.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/main.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | thread::spawn(move || { [INFO] [stderr] | _________________________^ [INFO] [stderr] 247 | | if banner.len() > 0 { [INFO] [stderr] 248 | | match stream.write((*banner).as_bytes()) { [INFO] [stderr] 249 | | Ok(_) => { [INFO] [stderr] ... | [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:99:6 [INFO] [stderr] | [INFO] [stderr] 99 | if dotline.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dotline.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:176:39 [INFO] [stderr] | [INFO] [stderr] 176 | for &(_, pattern) in BINARY_MATCHES.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/main.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | thread::spawn(move || { [INFO] [stderr] | _________________________^ [INFO] [stderr] 247 | | if banner.len() > 0 { [INFO] [stderr] 248 | | match stream.write((*banner).as_bytes()) { [INFO] [stderr] 249 | | Ok(_) => { [INFO] [stderr] ... | [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: Could not compile `portlurker`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `portlurker`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fca730cb3dd7a47b810d5daa720e484c3cb9ab09c7d4e0802fe7406feb848b3f"` [INFO] running `"docker" "rm" "-f" "fca730cb3dd7a47b810d5daa720e484c3cb9ab09c7d4e0802fe7406feb848b3f"` [INFO] [stdout] fca730cb3dd7a47b810d5daa720e484c3cb9ab09c7d4e0802fe7406feb848b3f