[INFO] updating cached repository barrelll/picksmid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/barrelll/picksmid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/barrelll/picksmid" "work/ex/clippy-test-run/sources/stable/gh/barrelll/picksmid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/barrelll/picksmid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/barrelll/picksmid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/barrelll/picksmid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/barrelll/picksmid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5381f25072c90816fd8d23004cc33fca9a27ffa9 [INFO] sha for GitHub repo barrelll/picksmid: 5381f25072c90816fd8d23004cc33fca9a27ffa9 [INFO] validating manifest of barrelll/picksmid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of barrelll/picksmid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing barrelll/picksmid [INFO] finished frobbing barrelll/picksmid [INFO] frobbed toml for barrelll/picksmid written to work/ex/clippy-test-run/sources/stable/gh/barrelll/picksmid/Cargo.toml [INFO] started frobbing barrelll/picksmid [INFO] finished frobbing barrelll/picksmid [INFO] frobbed toml for barrelll/picksmid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/barrelll/picksmid/Cargo.toml [INFO] crate barrelll/picksmid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting barrelll/picksmid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/barrelll/picksmid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11bb3c15c0007a0a7c2c4d361dd8b1bf77402d6466fd02d8d85c0f4cc74b1cdd [INFO] running `"docker" "start" "-a" "11bb3c15c0007a0a7c2c4d361dd8b1bf77402d6466fd02d8d85c0f4cc74b1cdd"` [INFO] [stderr] Checking bitvec v0.8.0 [INFO] [stderr] Checking imf-streamer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `BigEndian`, `ReadBytesExt` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | use byteorder::{BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Cursor` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | use std::io::Cursor; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ReadBytesExt` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | use byteorder::{BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Cursor` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | use std::io::Cursor; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slen` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let slen = s.len(); [INFO] [stderr] | ^^^^ help: consider using `_slen` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bit_position` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let mut bit_position = 0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bit_position` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `slen` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let slen = s.len(); [INFO] [stderr] | ^^^^ help: consider using `_slen` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bit_position` [INFO] [stderr] --> src/objects/visual_object_sequence.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let mut bit_position = 0; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_bit_position` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/objects/visual_object_sequence.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let mut bit_position = 0; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:43:54 [INFO] [stderr] | [INFO] [stderr] 43 | let objecttypeindication = Cursor::new(&data[cursor..cursor + 1]).read_u8().ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `cursor..=cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (2..8).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | for idx in (2..8).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let reserved = Some(byte & (1 << 0) > 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (8..24).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | for idx in (8..24).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (0..5).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/esdescr.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | for idx in (0..5).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base_descriptors/esdescr.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | url_length = Cursor::new(&data[cursor..cursor + 1]).read_u8().ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `cursor..=cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (6..16).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/initobjdescr.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | for i in (6..16).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (6..16).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/objdescr.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | for i in (6..16).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base_descriptors/mod.rs:132:38 [INFO] [stderr] | [INFO] [stderr] 132 | let size = Cursor::new(&data[c..c + 1]) [INFO] [stderr] | ^^^^^^^^ help: use: `c..=c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/objects/visual_object_sequence.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let mut bit_position = 0; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/iso_p12/tkhd.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | Some(Cursor::new(&data[12..16]).read_u32::().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Cursor::new(&data[12..16]).read_u32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/iso_p12/tkhd.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Cursor::new(&data[16..20]).read_u32::().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Cursor::new(&data[16..20]).read_u32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/iso_p12/tkhd.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | duration = Some(Cursor::new(&data[28..32]).read_u32::().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Cursor::new(&data[28..32]).read_u32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:43:54 [INFO] [stderr] | [INFO] [stderr] 43 | let objecttypeindication = Cursor::new(&data[cursor..cursor + 1]).read_u8().ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `cursor..=cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (2..8).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | for idx in (2..8).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let reserved = Some(byte & (1 << 0) > 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (8..24).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/decoderconfigdescr.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | for idx in (8..24).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (0..5).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/esdescr.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | for idx in (0..5).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base_descriptors/esdescr.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | url_length = Cursor::new(&data[cursor..cursor + 1]).read_u8().ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `cursor..=cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/sample_entries/mod.rs:256:64 [INFO] [stderr] | [INFO] [stderr] 256 | let se = Box::new(SampleEntry::build(data).expect( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 257 | | format!("samplefactory: {} : Error reading sample entry", any).as_ref(), [INFO] [stderr] 258 | | )) as Box; [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| panic!("samplefactory: {} : Error reading sample entry", any))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (6..16).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/initobjdescr.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | for i in (6..16).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (6..16).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/base_descriptors/objdescr.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | for i in (6..16).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | T::build(&buf[..]).ok_or(Error::new( [INFO] [stderr] | ________________________^ [INFO] [stderr] 99 | | ErrorKind::InvalidData, [INFO] [stderr] 100 | | format!("Data can't be read properly?"), [INFO] [stderr] 101 | | )) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | T::build(&buf[..]).ok_or_else(|| Error::new( [INFO] [stderr] 99 | ErrorKind::InvalidData, [INFO] [stderr] 100 | format!("Data can't be read properly?"), [INFO] [stderr] 101 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | format!("Data can't be read properly?"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Data can't be read properly?".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | let _ = handle.read_exact(&mut buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | val as u64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (0..24).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:206:24 [INFO] [stderr] | [INFO] [stderr] 206 | for idx in (0..24).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base_descriptors/mod.rs:132:38 [INFO] [stderr] | [INFO] [stderr] 132 | let size = Cursor::new(&data[c..c + 1]) [INFO] [stderr] | ^^^^^^^^ help: use: `c..=c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/iso_p12/tkhd.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | Some(Cursor::new(&data[12..16]).read_u32::().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Cursor::new(&data[12..16]).read_u32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/iso_p12/tkhd.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | Some(Cursor::new(&data[16..20]).read_u32::().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Cursor::new(&data[16..20]).read_u32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/iso_p12/tkhd.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | duration = Some(Cursor::new(&data[28..32]).read_u32::().unwrap() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Cursor::new(&data[28..32]).read_u32::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/sample_entries/mod.rs:256:64 [INFO] [stderr] | [INFO] [stderr] 256 | let se = Box::new(SampleEntry::build(data).expect( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 257 | | format!("samplefactory: {} : Error reading sample entry", any).as_ref(), [INFO] [stderr] 258 | | )) as Box; [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| panic!("samplefactory: {} : Error reading sample entry", any))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tests/objects.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match sample.downcast_ref::<::sample_entries::MP4VisualSampleEntry>() { [INFO] [stderr] 14 | | Some(val) => { [INFO] [stderr] 15 | | let val: &::sample_entries::MP4VisualSampleEntry = val; [INFO] [stderr] 16 | | for descr in &val.esds_box.as_ref().unwrap().es.as_ref().unwrap().descriptors { [INFO] [stderr] ... | [INFO] [stderr] 24 | | None => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(val) = sample.downcast_ref::<::sample_entries::MP4VisualSampleEntry>() { [INFO] [stderr] 14 | let val: &::sample_entries::MP4VisualSampleEntry = val; [INFO] [stderr] 15 | for descr in &val.esds_box.as_ref().unwrap().es.as_ref().unwrap().descriptors { [INFO] [stderr] 16 | let decconfig: &::base_descriptors::DecoderConfigDescriptor = descr.downcast_ref::<::base_descriptors::DecoderConfigDescriptor>().unwrap(); [INFO] [stderr] 17 | for descr in &decconfig.descriptors { [INFO] [stderr] 18 | let decspec: &::base_descriptors::DecoderSpecificInfo = descr.downcast_ref::<::base_descriptors::DecoderSpecificInfo>().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | T::build(&buf[..]).ok_or(Error::new( [INFO] [stderr] | ________________________^ [INFO] [stderr] 99 | | ErrorKind::InvalidData, [INFO] [stderr] 100 | | format!("Data can't be read properly?"), [INFO] [stderr] 101 | | )) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | T::build(&buf[..]).ok_or_else(|| Error::new( [INFO] [stderr] 99 | ErrorKind::InvalidData, [INFO] [stderr] 100 | format!("Data can't be read properly?"), [INFO] [stderr] 101 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | format!("Data can't be read properly?"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Data can't be read properly?".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | let _ = handle.read_exact(&mut buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | val as u64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `arr_idx` is used as a loop counter. Consider using `for (arr_idx, item) in (0..24).rev().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:206:24 [INFO] [stderr] | [INFO] [stderr] 206 | for idx in (0..24).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.60s [INFO] running `"docker" "inspect" "11bb3c15c0007a0a7c2c4d361dd8b1bf77402d6466fd02d8d85c0f4cc74b1cdd"` [INFO] running `"docker" "rm" "-f" "11bb3c15c0007a0a7c2c4d361dd8b1bf77402d6466fd02d8d85c0f4cc74b1cdd"` [INFO] [stdout] 11bb3c15c0007a0a7c2c4d361dd8b1bf77402d6466fd02d8d85c0f4cc74b1cdd