[INFO] updating cached repository barbeque/duplicate-attrs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/barbeque/duplicate-attrs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/barbeque/duplicate-attrs" "work/ex/clippy-test-run/sources/stable/gh/barbeque/duplicate-attrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/barbeque/duplicate-attrs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/barbeque/duplicate-attrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/barbeque/duplicate-attrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/barbeque/duplicate-attrs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 50f147accd06659fe14efb457c407cc05198ca0a [INFO] sha for GitHub repo barbeque/duplicate-attrs: 50f147accd06659fe14efb457c407cc05198ca0a [INFO] validating manifest of barbeque/duplicate-attrs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of barbeque/duplicate-attrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing barbeque/duplicate-attrs [INFO] finished frobbing barbeque/duplicate-attrs [INFO] frobbed toml for barbeque/duplicate-attrs written to work/ex/clippy-test-run/sources/stable/gh/barbeque/duplicate-attrs/Cargo.toml [INFO] started frobbing barbeque/duplicate-attrs [INFO] finished frobbing barbeque/duplicate-attrs [INFO] frobbed toml for barbeque/duplicate-attrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/barbeque/duplicate-attrs/Cargo.toml [INFO] crate barbeque/duplicate-attrs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting barbeque/duplicate-attrs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/barbeque/duplicate-attrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4145084b31af5be388f5e251d49b03d3127c2bfd4bf2c8ff4a4d72d89b09c562 [INFO] running `"docker" "start" "-a" "4145084b31af5be388f5e251d49b03d3127c2bfd4bf2c8ff4a4d72d89b09c562"` [INFO] [stderr] Checking duplicate-attrs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:21:57 [INFO] [stderr] | [INFO] [stderr] 21 | fn detect_duplicates(element_name : &OwnedName, attrs : &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:21:57 [INFO] [stderr] | [INFO] [stderr] 21 | fn detect_duplicates(element_name : &OwnedName, attrs : &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OwnedAttribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | fn check_file(file_path : &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | fn check_file(file_path : &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "4145084b31af5be388f5e251d49b03d3127c2bfd4bf2c8ff4a4d72d89b09c562"` [INFO] running `"docker" "rm" "-f" "4145084b31af5be388f5e251d49b03d3127c2bfd4bf2c8ff4a4d72d89b09c562"` [INFO] [stdout] 4145084b31af5be388f5e251d49b03d3127c2bfd4bf2c8ff4a4d72d89b09c562