[INFO] updating cached repository baransu/pbrt-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/baransu/pbrt-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/baransu/pbrt-rs" "work/ex/clippy-test-run/sources/stable/gh/baransu/pbrt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/baransu/pbrt-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/baransu/pbrt-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baransu/pbrt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baransu/pbrt-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bba24d7e9371c6c1c38446b9946e34b23b6b0230 [INFO] sha for GitHub repo baransu/pbrt-rs: bba24d7e9371c6c1c38446b9946e34b23b6b0230 [INFO] validating manifest of baransu/pbrt-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of baransu/pbrt-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing baransu/pbrt-rs [INFO] finished frobbing baransu/pbrt-rs [INFO] frobbed toml for baransu/pbrt-rs written to work/ex/clippy-test-run/sources/stable/gh/baransu/pbrt-rs/Cargo.toml [INFO] started frobbing baransu/pbrt-rs [INFO] finished frobbing baransu/pbrt-rs [INFO] frobbed toml for baransu/pbrt-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baransu/pbrt-rs/Cargo.toml [INFO] crate baransu/pbrt-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting baransu/pbrt-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/baransu/pbrt-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9bf4cb3c15941d977dbaae62f1c54c1551c413ed6707aab75ea38df60a307a7 [INFO] running `"docker" "start" "-a" "e9bf4cb3c15941d977dbaae62f1c54c1551c413ed6707aab75ea38df60a307a7"` [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.14.5 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pbrt-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Intersectable` [INFO] [stderr] --> src/main.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use pbrt::rendering::{Intersectable, Ray}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Intersectable` [INFO] [stderr] --> src/main.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use pbrt::rendering::{Intersectable, Ray}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `black` [INFO] [stderr] --> src/pbrt/scene.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn black() -> Color { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:14:47 [INFO] [stderr] | [INFO] [stderr] 14 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/pbrt/scene.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new<'b>(distance: f64, object: &'b Element) -> Intersecion<'b> { [INFO] [stderr] 86 | | Intersecion { distance, object } [INFO] [stderr] 87 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: method is never used: `black` [INFO] [stderr] --> src/pbrt/scene.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn black() -> Color { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:14:47 [INFO] [stderr] | [INFO] [stderr] 14 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pbrt/rendering.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/pbrt/scene.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new<'b>(distance: f64, object: &'b Element) -> Intersecion<'b> { [INFO] [stderr] 86 | | Intersecion { distance, object } [INFO] [stderr] 87 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.75s [INFO] running `"docker" "inspect" "e9bf4cb3c15941d977dbaae62f1c54c1551c413ed6707aab75ea38df60a307a7"` [INFO] running `"docker" "rm" "-f" "e9bf4cb3c15941d977dbaae62f1c54c1551c413ed6707aab75ea38df60a307a7"` [INFO] [stdout] e9bf4cb3c15941d977dbaae62f1c54c1551c413ed6707aab75ea38df60a307a7