[INFO] updating cached repository banditpig/AoC_2015_Rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/banditpig/AoC_2015_Rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/banditpig/AoC_2015_Rust" "work/ex/clippy-test-run/sources/stable/gh/banditpig/AoC_2015_Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/banditpig/AoC_2015_Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/banditpig/AoC_2015_Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/banditpig/AoC_2015_Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/banditpig/AoC_2015_Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c17ec8b7ed670bd99b4299a2c73fb4787a1c2604
[INFO] sha for GitHub repo banditpig/AoC_2015_Rust: c17ec8b7ed670bd99b4299a2c73fb4787a1c2604
[INFO] validating manifest of banditpig/AoC_2015_Rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of banditpig/AoC_2015_Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing banditpig/AoC_2015_Rust
[INFO] finished frobbing banditpig/AoC_2015_Rust
[INFO] frobbed toml for banditpig/AoC_2015_Rust written to work/ex/clippy-test-run/sources/stable/gh/banditpig/AoC_2015_Rust/Cargo.toml
[INFO] started frobbing banditpig/AoC_2015_Rust
[INFO] finished frobbing banditpig/AoC_2015_Rust
[INFO] frobbed toml for banditpig/AoC_2015_Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/banditpig/AoC_2015_Rust/Cargo.toml
[INFO] crate banditpig/AoC_2015_Rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting banditpig/AoC_2015_Rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/banditpig/AoC_2015_Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 306578e5ba836d98c5b5842891b0620459935142b7936ee65ecbf8c4e1cac90a
[INFO] running `"docker" "start" "-a" "306578e5ba836d98c5b5842891b0620459935142b7936ee65ecbf8c4e1cac90a"`
[INFO] [stderr]     Checking rust-crypto v0.2.36
[INFO] [stderr]     Checking rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::thread`
[INFO] [stderr]  --> src/main.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::thread;
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `Switch`
[INFO] [stderr]    --> src/day6.rs:104:1
[INFO] [stderr]     |
[INFO] [stderr] 104 | / enum Op {
[INFO] [stderr] 105 | |     SwitchOn { start: Location, end: Location },
[INFO] [stderr] 106 | |     SwitchOff { start: Location, end: Location },
[INFO] [stderr] 107 | |     SwitchToggle { start: Location, end: Location }
[INFO] [stderr] 108 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day6.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     return op;
[INFO] [stderr]     |     ^^^^^^^^^^ help: remove `return` as shown: `op`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/day6.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 |     loc
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/day6.rs:141:15
[INFO] [stderr]     |
[INFO] [stderr] 141 |     let loc = Location { row: r, col: c };
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::thread`
[INFO] [stderr]  --> src/main.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::thread;
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `Switch`
[INFO] [stderr]    --> src/day6.rs:104:1
[INFO] [stderr]     |
[INFO] [stderr] 104 | / enum Op {
[INFO] [stderr] 105 | |     SwitchOn { start: Location, end: Location },
[INFO] [stderr] 106 | |     SwitchOff { start: Location, end: Location },
[INFO] [stderr] 107 | |     SwitchToggle { start: Location, end: Location }
[INFO] [stderr] 108 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/day6.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     return op;
[INFO] [stderr]     |     ^^^^^^^^^^ help: remove `return` as shown: `op`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/day6.rs:142:5
[INFO] [stderr]     |
[INFO] [stderr] 142 |     loc
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/day6.rs:141:15
[INFO] [stderr]     |
[INFO] [stderr] 141 |     let loc = Location { row: r, col: c };
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `has_duplicates`
[INFO] [stderr]   --> src/utils.rs:11:1
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn has_duplicates<T: Eq + Ord + Clone>(v: &Vec<T>) -> bool {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:10:13
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn part1(s: &String){
[INFO] [stderr]    |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn part2(s: &String){
[INFO] [stderr]    |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:28:20
[INFO] [stderr]    |
[INFO] [stderr] 28 |             '(' => net_value = net_value + 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `net_value += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:29:20
[INFO] [stderr]    |
[INFO] [stderr] 29 |             _   => net_value = net_value - 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `net_value -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:43:20
[INFO] [stderr]    |
[INFO] [stderr] 43 |             '(' => location = location + 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `location += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:44:20
[INFO] [stderr]    |
[INFO] [stderr] 44 |             _   => location = location - 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `location -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day2.rs:9:13
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn part2(s: &String){
[INFO] [stderr]   |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 |         sum_area = sum_area + area2(sort(tpl));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_area += area2(sort(tpl))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 | fn part1(s: &String){
[INFO] [stderr]    |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         sum_area = sum_area + area(tpl);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_area += area(tpl)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day2.rs:60:28
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let vec = triple.split("x").collect::<Vec<&str>>();
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day3.rs:24:15
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn part2(str: &String) {
[INFO] [stderr]    |               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:39:24
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 94  => y = y - 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `y -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:40:24
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 118 => y = y + 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `y += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:41:24
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 60  => x = x - 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `x -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:42:24
[INFO] [stderr]    |
[INFO] [stderr] 42 |                 62  => x = x + 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day3.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn part1(str: &String) {
[INFO] [stderr]    |               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:68:20
[INFO] [stderr]    |
[INFO] [stderr] 68 |             '^' => y = y - 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `y -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |             'v' => y = y + 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `y += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |             '<' => x = x - 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `x -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:71:20
[INFO] [stderr]    |
[INFO] [stderr] 71 |             '>' => x = x + 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/day4.rs:22:15
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let key = "yzbqklnj".as_bytes();
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"yzbqklnj"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day4.rs:39:40
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn starts_with_n_zeroes(n: usize, str: &String) -> bool {
[INFO] [stderr]    |                                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/day5.rs:29:23
[INFO] [stderr]    |
[INFO] [stderr] 29 |     for pair in PAIRS.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/day6.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         match op {
[INFO] [stderr] 16 | |             &Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 17 | |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 18 | |                     for c in start.col..end.col + 1 {
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |             }
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 15 |         match *op {
[INFO] [stderr] 16 |             Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 17 |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 18 |                     for c in start.col..end.col + 1 {
[INFO] [stderr] 19 |                         let v = self[r][c];
[INFO] [stderr] 20 |                         self[r][c] = v + 1;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:18:30
[INFO] [stderr]    |
[INFO] [stderr] 18 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:26:30
[INFO] [stderr]    |
[INFO] [stderr] 26 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:35:30
[INFO] [stderr]    |
[INFO] [stderr] 35 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day6.rs:46:56
[INFO] [stderr]    |
[INFO] [stderr] 46 |         self.iter().for_each(|s| s.iter().for_each(|v| sum = sum + (*v as i64)));
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += (*v as i64)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/day6.rs:46:68
[INFO] [stderr]    |
[INFO] [stderr] 46 |         self.iter().for_each(|s| s.iter().for_each(|v| sum = sum + (*v as i64)));
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^ help: try: `i64::from(*v)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/day6.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         match op {
[INFO] [stderr] 54 | |             &Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 55 | |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 56 | |                     for c in start.col..end.col + 1 {
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |             }
[INFO] [stderr] 79 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 53 |         match *op {
[INFO] [stderr] 54 |             Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 55 |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 56 |                     for c in start.col..end.col + 1 {
[INFO] [stderr] 57 |                         self[r][c] = State::On;
[INFO] [stderr] 58 |                     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:55:26
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:55:26
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:56:30
[INFO] [stderr]    |
[INFO] [stderr] 56 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:63:30
[INFO] [stderr]    |
[INFO] [stderr] 63 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:69:26
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:69:26
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:70:30
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6.rs:129:28
[INFO] [stderr]     |
[INFO] [stderr] 129 | fn run_ops_gen<'a, T>(ops: &AllOps, lights: &'a mut Switchable<T>) -> &'a mut Switchable<T> {
[INFO] [stderr]     |                            ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/day6.rs:138:23
[INFO] [stderr]     |
[INFO] [stderr] 138 |     let vec = s.split(",").collect::<Vec<&str>>();
[INFO] [stderr]     |                       ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6.rs:161:19
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn part2(all_ops: &AllOps) {
[INFO] [stderr]     |                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6.rs:167:19
[INFO] [stderr]     |
[INFO] [stderr] 167 | fn part1(all_ops: &AllOps) {
[INFO] [stderr]     |                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:11:47
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn has_duplicates<T: Eq + Ord + Clone>(v: &Vec<T>) -> bool {
[INFO] [stderr]    |                                               ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/utils.rs:12:8
[INFO] [stderr]    |
[INFO] [stderr] 12 |     if v.len() == 0 { return false; }
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: function is never used: `has_duplicates`
[INFO] [stderr]   --> src/utils.rs:11:1
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn has_duplicates<T: Eq + Ord + Clone>(v: &Vec<T>) -> bool {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:10:13
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn part1(s: &String){
[INFO] [stderr]    |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day1.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn part2(s: &String){
[INFO] [stderr]    |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:28:20
[INFO] [stderr]    |
[INFO] [stderr] 28 |             '(' => net_value = net_value + 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `net_value += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:29:20
[INFO] [stderr]    |
[INFO] [stderr] 29 |             _   => net_value = net_value - 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `net_value -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:43:20
[INFO] [stderr]    |
[INFO] [stderr] 43 |             '(' => location = location + 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `location += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day1.rs:44:20
[INFO] [stderr]    |
[INFO] [stderr] 44 |             _   => location = location - 1,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `location -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day2.rs:9:13
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn part2(s: &String){
[INFO] [stderr]   |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:13:9
[INFO] [stderr]    |
[INFO] [stderr] 13 |         sum_area = sum_area + area2(sort(tpl));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_area += area2(sort(tpl))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 | fn part1(s: &String){
[INFO] [stderr]    |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 |         sum_area = sum_area + area(tpl);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_area += area(tpl)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day2.rs:60:28
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let vec = triple.split("x").collect::<Vec<&str>>();
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day3.rs:24:15
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn part2(str: &String) {
[INFO] [stderr]    |               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:39:24
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 94  => y = y - 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `y -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:40:24
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 118 => y = y + 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `y += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:41:24
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 60  => x = x - 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `x -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:42:24
[INFO] [stderr]    |
[INFO] [stderr] 42 |                 62  => x = x + 1,
[INFO] [stderr]    |                        ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day3.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn part1(str: &String) {
[INFO] [stderr]    |               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:68:20
[INFO] [stderr]    |
[INFO] [stderr] 68 |             '^' => y = y - 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `y -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |             'v' => y = y + 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `y += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |             '<' => x = x - 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `x -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day3.rs:71:20
[INFO] [stderr]    |
[INFO] [stderr] 71 |             '>' => x = x + 1,
[INFO] [stderr]    |                    ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/day4.rs:22:15
[INFO] [stderr]    |
[INFO] [stderr] 22 |     let key = "yzbqklnj".as_bytes();
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"yzbqklnj"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day4.rs:39:40
[INFO] [stderr]    |
[INFO] [stderr] 39 | fn starts_with_n_zeroes(n: usize, str: &String) -> bool {
[INFO] [stderr]    |                                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/day5.rs:29:23
[INFO] [stderr]    |
[INFO] [stderr] 29 |     for pair in PAIRS.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/day6.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         match op {
[INFO] [stderr] 16 | |             &Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 17 | |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 18 | |                     for c in start.col..end.col + 1 {
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |             }
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 15 |         match *op {
[INFO] [stderr] 16 |             Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 17 |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 18 |                     for c in start.col..end.col + 1 {
[INFO] [stderr] 19 |                         let v = self[r][c];
[INFO] [stderr] 20 |                         self[r][c] = v + 1;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:17:26
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:18:30
[INFO] [stderr]    |
[INFO] [stderr] 18 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:26:30
[INFO] [stderr]    |
[INFO] [stderr] 26 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:35:30
[INFO] [stderr]    |
[INFO] [stderr] 35 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day6.rs:46:56
[INFO] [stderr]    |
[INFO] [stderr] 46 |         self.iter().for_each(|s| s.iter().for_each(|v| sum = sum + (*v as i64)));
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += (*v as i64)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/day6.rs:46:68
[INFO] [stderr]    |
[INFO] [stderr] 46 |         self.iter().for_each(|s| s.iter().for_each(|v| sum = sum + (*v as i64)));
[INFO] [stderr]    |                                                                    ^^^^^^^^^^^ help: try: `i64::from(*v)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/day6.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 | /         match op {
[INFO] [stderr] 54 | |             &Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 55 | |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 56 | |                     for c in start.col..end.col + 1 {
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |             }
[INFO] [stderr] 79 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 53 |         match *op {
[INFO] [stderr] 54 |             Op::SwitchOn { ref start, ref end } => {
[INFO] [stderr] 55 |                 for r in start.row..end.row + 1 {
[INFO] [stderr] 56 |                     for c in start.col..end.col + 1 {
[INFO] [stderr] 57 |                         self[r][c] = State::On;
[INFO] [stderr] 58 |                     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:55:26
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:55:26
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:56:30
[INFO] [stderr]    |
[INFO] [stderr] 56 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:63:30
[INFO] [stderr]    |
[INFO] [stderr] 63 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `r` is only used to index `self`.
[INFO] [stderr]   --> src/day6.rs:69:26
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 for <item> in self.iter_mut().take(end.row + 1).skip(start.row) {
[INFO] [stderr]    |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:69:26
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 for r in start.row..end.row + 1 {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.row..=end.row`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/day6.rs:70:30
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     for c in start.col..end.col + 1 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^ help: use: `start.col..=end.col`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6.rs:129:28
[INFO] [stderr]     |
[INFO] [stderr] 129 | fn run_ops_gen<'a, T>(ops: &AllOps, lights: &'a mut Switchable<T>) -> &'a mut Switchable<T> {
[INFO] [stderr]     |                            ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/day6.rs:138:23
[INFO] [stderr]     |
[INFO] [stderr] 138 |     let vec = s.split(",").collect::<Vec<&str>>();
[INFO] [stderr]     |                       ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6.rs:161:19
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn part2(all_ops: &AllOps) {
[INFO] [stderr]     |                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6.rs:167:19
[INFO] [stderr]     |
[INFO] [stderr] 167 | fn part1(all_ops: &AllOps) {
[INFO] [stderr]     |                   ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:11:47
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn has_duplicates<T: Eq + Ord + Clone>(v: &Vec<T>) -> bool {
[INFO] [stderr]    |                                               ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/utils.rs:12:8
[INFO] [stderr]    |
[INFO] [stderr] 12 |     if v.len() == 0 { return false; }
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "306578e5ba836d98c5b5842891b0620459935142b7936ee65ecbf8c4e1cac90a"`
[INFO] running `"docker" "rm" "-f" "306578e5ba836d98c5b5842891b0620459935142b7936ee65ecbf8c4e1cac90a"`
[INFO] [stdout] 306578e5ba836d98c5b5842891b0620459935142b7936ee65ecbf8c4e1cac90a