[INFO] updating cached repository bamorim/rust-chess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bamorim/rust-chess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bamorim/rust-chess" "work/ex/clippy-test-run/sources/stable/gh/bamorim/rust-chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bamorim/rust-chess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bamorim/rust-chess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bamorim/rust-chess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bamorim/rust-chess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a28720a12a83694743f0475973ba13ba0847eead [INFO] sha for GitHub repo bamorim/rust-chess: a28720a12a83694743f0475973ba13ba0847eead [INFO] validating manifest of bamorim/rust-chess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bamorim/rust-chess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bamorim/rust-chess [INFO] finished frobbing bamorim/rust-chess [INFO] frobbed toml for bamorim/rust-chess written to work/ex/clippy-test-run/sources/stable/gh/bamorim/rust-chess/Cargo.toml [INFO] started frobbing bamorim/rust-chess [INFO] finished frobbing bamorim/rust-chess [INFO] frobbed toml for bamorim/rust-chess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bamorim/rust-chess/Cargo.toml [INFO] crate bamorim/rust-chess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bamorim/rust-chess against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bamorim/rust-chess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98c1d7df81e6930d951a319e17b978963febbcbde46b46639993536a1c5ad123 [INFO] running `"docker" "start" "-a" "98c1d7df81e6930d951a319e17b978963febbcbde46b46639993536a1c5ad123"` [INFO] [stderr] Compiling strcursor v0.2.5 [INFO] [stderr] Compiling scan-rules v0.2.0 [INFO] [stderr] Checking chess v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/display.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return strings.join(" "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strings.join(" ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/display.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return (0..8).zip(board).map(|(i, ref row)| format!("{} {}", i, row_to_string(row))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(0..8).zip(board).map(|(i, ref row)| format!("{} {}", i, row_to_string(row))).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/display.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return strings.join(" "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strings.join(" ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board/display.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return (0..8).zip(board).map(|(i, ref row)| format!("{} {}", i, row_to_string(row))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(0..8).zip(board).map(|(i, ref row)| format!("{} {}", i, row_to_string(row))).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/display.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | / match self { [INFO] [stderr] 8 | | &super::Color::White => write!(f,"W"), [INFO] [stderr] 9 | | &super::Color::Black => write!(f,"B"), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 7 | match *self { [INFO] [stderr] 8 | super::Color::White => write!(f,"W"), [INFO] [stderr] 9 | super::Color::Black => write!(f,"B"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/display.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &super::PieceKind::King => write!(f,"K"), [INFO] [stderr] 18 | | &super::PieceKind::Queen => write!(f,"Q"), [INFO] [stderr] 19 | | &super::PieceKind::Rook => write!(f,"R"), [INFO] [stderr] ... | [INFO] [stderr] 22 | | &super::PieceKind::Pawn => write!(f,"P"), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | super::PieceKind::King => write!(f,"K"), [INFO] [stderr] 18 | super::PieceKind::Queen => write!(f,"Q"), [INFO] [stderr] 19 | super::PieceKind::Rook => write!(f,"R"), [INFO] [stderr] 20 | super::PieceKind::Bishop => write!(f,"B"), [INFO] [stderr] 21 | super::PieceKind::Knight => write!(f,"N"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board/display.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | let strings : Vec<_> = row.into_iter().map(|square| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/display.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match square { [INFO] [stderr] 30 | | &None => "--".to_string(), [INFO] [stderr] 31 | | &Some((ref c, ref k)) => format!("{}{}", c, k) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *square { [INFO] [stderr] 30 | None => "--".to_string(), [INFO] [stderr] 31 | Some((ref c, ref k)) => format!("{}{}", c, k) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/board/mod.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | fn flatten(ref vect: Vec>) -> Vec where T : Clone{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board/mod.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | i = i+di; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `i += di` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board/mod.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | j = j+dj; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `j += dj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/display.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | / match self { [INFO] [stderr] 8 | | &super::Color::White => write!(f,"W"), [INFO] [stderr] 9 | | &super::Color::Black => write!(f,"B"), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 7 | match *self { [INFO] [stderr] 8 | super::Color::White => write!(f,"W"), [INFO] [stderr] 9 | super::Color::Black => write!(f,"B"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/display.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &super::PieceKind::King => write!(f,"K"), [INFO] [stderr] 18 | | &super::PieceKind::Queen => write!(f,"Q"), [INFO] [stderr] 19 | | &super::PieceKind::Rook => write!(f,"R"), [INFO] [stderr] ... | [INFO] [stderr] 22 | | &super::PieceKind::Pawn => write!(f,"P"), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | super::PieceKind::King => write!(f,"K"), [INFO] [stderr] 18 | super::PieceKind::Queen => write!(f,"Q"), [INFO] [stderr] 19 | super::PieceKind::Rook => write!(f,"R"), [INFO] [stderr] 20 | super::PieceKind::Bishop => write!(f,"B"), [INFO] [stderr] 21 | super::PieceKind::Knight => write!(f,"N"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board/display.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | let strings : Vec<_> = row.into_iter().map(|square| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/board/display.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match square { [INFO] [stderr] 30 | | &None => "--".to_string(), [INFO] [stderr] 31 | | &Some((ref c, ref k)) => format!("{}{}", c, k) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *square { [INFO] [stderr] 30 | None => "--".to_string(), [INFO] [stderr] 31 | Some((ref c, ref k)) => format!("{}{}", c, k) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/board/mod.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | fn flatten(ref vect: Vec>) -> Vec where T : Clone{ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board/mod.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | i = i+di; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `i += di` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board/mod.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | j = j+dj; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `j += dj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: Could not compile `chess`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chess`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "98c1d7df81e6930d951a319e17b978963febbcbde46b46639993536a1c5ad123"` [INFO] running `"docker" "rm" "-f" "98c1d7df81e6930d951a319e17b978963febbcbde46b46639993536a1c5ad123"` [INFO] [stdout] 98c1d7df81e6930d951a319e17b978963febbcbde46b46639993536a1c5ad123