[INFO] updating cached repository balthild/minitrue_bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/balthild/minitrue_bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/balthild/minitrue_bot" "work/ex/clippy-test-run/sources/stable/gh/balthild/minitrue_bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/balthild/minitrue_bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/balthild/minitrue_bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/balthild/minitrue_bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/balthild/minitrue_bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93effa89dddcca7f952c8367113ab604d80623c0 [INFO] sha for GitHub repo balthild/minitrue_bot: 93effa89dddcca7f952c8367113ab604d80623c0 [INFO] validating manifest of balthild/minitrue_bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of balthild/minitrue_bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing balthild/minitrue_bot [INFO] finished frobbing balthild/minitrue_bot [INFO] frobbed toml for balthild/minitrue_bot written to work/ex/clippy-test-run/sources/stable/gh/balthild/minitrue_bot/Cargo.toml [INFO] started frobbing balthild/minitrue_bot [INFO] finished frobbing balthild/minitrue_bot [INFO] frobbed toml for balthild/minitrue_bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/balthild/minitrue_bot/Cargo.toml [INFO] crate balthild/minitrue_bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting balthild/minitrue_bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/balthild/minitrue_bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 115b2a5a2300e4ec4d58f6eb01cad277ec743402272460cf7eb35da4ded8f0de [INFO] running `"docker" "start" "-a" "115b2a5a2300e4ec4d58f6eb01cad277ec743402272460cf7eb35da4ded8f0de"` [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking telegram-bot-raw v0.6.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking telegram-bot v0.6.1 [INFO] [stderr] Checking minitrue_bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 64 | | if muted_groups.contains(&chat_id) { [INFO] [stderr] 65 | | api.spawn(message.delete()); [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | } else if muted_groups.contains(&chat_id) { [INFO] [stderr] 64 | api.spawn(message.delete()); [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | if !message.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | let mut cmd = message.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 24 | let mut cmd = &(*message).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 24 | let mut cmd = &str::clone(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | cmd = cmd.rsplitn(2, '@').skip(1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `minitrue_bot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 64 | | if muted_groups.contains(&chat_id) { [INFO] [stderr] 65 | | api.spawn(message.delete()); [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | } else if muted_groups.contains(&chat_id) { [INFO] [stderr] 64 | api.spawn(message.delete()); [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | if !message.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | let mut cmd = message.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 24 | let mut cmd = &(*message).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 24 | let mut cmd = &str::clone(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | cmd = cmd.rsplitn(2, '@').skip(1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `minitrue_bot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "115b2a5a2300e4ec4d58f6eb01cad277ec743402272460cf7eb35da4ded8f0de"` [INFO] running `"docker" "rm" "-f" "115b2a5a2300e4ec4d58f6eb01cad277ec743402272460cf7eb35da4ded8f0de"` [INFO] [stdout] 115b2a5a2300e4ec4d58f6eb01cad277ec743402272460cf7eb35da4ded8f0de