[INFO] updating cached repository bahamas10/rust-manta [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bahamas10/rust-manta [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bahamas10/rust-manta" "work/ex/clippy-test-run/sources/stable/gh/bahamas10/rust-manta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bahamas10/rust-manta'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bahamas10/rust-manta" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahamas10/rust-manta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahamas10/rust-manta'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6cabcf9041df6b1aa6c880d9213f90415f5723f4 [INFO] sha for GitHub repo bahamas10/rust-manta: 6cabcf9041df6b1aa6c880d9213f90415f5723f4 [INFO] validating manifest of bahamas10/rust-manta on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bahamas10/rust-manta on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bahamas10/rust-manta [INFO] finished frobbing bahamas10/rust-manta [INFO] frobbed toml for bahamas10/rust-manta written to work/ex/clippy-test-run/sources/stable/gh/bahamas10/rust-manta/Cargo.toml [INFO] started frobbing bahamas10/rust-manta [INFO] finished frobbing bahamas10/rust-manta [INFO] frobbed toml for bahamas10/rust-manta written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bahamas10/rust-manta/Cargo.toml [INFO] crate bahamas10/rust-manta has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bahamas10/rust-manta against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bahamas10/rust-manta:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71c8d87d2e211befdaad8bfdfab3408069fb83a507b8f20e226bc4dc40d21411 [INFO] running `"docker" "start" "-a" "71c8d87d2e211befdaad8bfdfab3408069fb83a507b8f20e226bc4dc40d21411"` [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Checking rust-manta v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh_agent_client.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | stream: stream [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh_identity.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | md5_fp: md5_fp, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `md5_fp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh_identity.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | sha256_fp: sha256_fp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sha256_fp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh_agent_client.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | stream: stream [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh_identity.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | md5_fp: md5_fp, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `md5_fp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh_identity.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | sha256_fp: sha256_fp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sha256_fp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | idx = idx + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `idx += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | idx = idx + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `idx += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | idx = idx + identity.raw_key.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += identity.raw_key.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | idx = idx + data.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += data.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | idx = idx + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `idx += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:182:6 [INFO] [stderr] | [INFO] [stderr] 182 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ssh_agent_client.rs:182:11 [INFO] [stderr] | [INFO] [stderr] 182 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:183:6 [INFO] [stderr] | [INFO] [stderr] 183 | ((buf[offset + 1] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:184:6 [INFO] [stderr] | [INFO] [stderr] 184 | ((buf[offset + 2] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buf[offset + 3] as u32)` [INFO] [stderr] --> src/ssh_agent_client.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:185:6 [INFO] [stderr] | [INFO] [stderr] 185 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/ssh_agent_client.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `buf[offset..(bytes.len() + offset)].clone_from_slice(&bytes[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ssh_agent_client.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | buf[offset + 0] = ((num >> 24) % (1 << 8)) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `num` [INFO] [stderr] --> src/ssh_agent_client.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | buf[offset + 3] = ((num >> 0) % (1 << 8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:76:6 [INFO] [stderr] | [INFO] [stderr] 76 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ssh_identity.rs:76:11 [INFO] [stderr] | [INFO] [stderr] 76 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:77:6 [INFO] [stderr] | [INFO] [stderr] 77 | ((buf[offset + 1] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:78:6 [INFO] [stderr] | [INFO] [stderr] 78 | ((buf[offset + 2] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buf[offset + 3] as u32)` [INFO] [stderr] --> src/ssh_identity.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:86:45 [INFO] [stderr] | [INFO] [stderr] 86 | .arg(format!("{}", date_header)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `date_header.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:94:37 [INFO] [stderr] | [INFO] [stderr] 94 | let files = stdout.trim().split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | idx = idx + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `idx += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | idx = idx + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `idx += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | idx = idx + identity.raw_key.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += identity.raw_key.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | idx = idx + data.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += data.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | idx = idx + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `idx += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ssh_agent_client.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | idx = idx + 4; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:182:6 [INFO] [stderr] | [INFO] [stderr] 182 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ssh_agent_client.rs:182:11 [INFO] [stderr] | [INFO] [stderr] 182 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:183:6 [INFO] [stderr] | [INFO] [stderr] 183 | ((buf[offset + 1] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:184:6 [INFO] [stderr] | [INFO] [stderr] 184 | ((buf[offset + 2] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buf[offset + 3] as u32)` [INFO] [stderr] --> src/ssh_agent_client.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_agent_client.rs:185:6 [INFO] [stderr] | [INFO] [stderr] 185 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/ssh_agent_client.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `buf[offset..(bytes.len() + offset)].clone_from_slice(&bytes[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ssh_agent_client.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | buf[offset + 0] = ((num >> 24) % (1 << 8)) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `num` [INFO] [stderr] --> src/ssh_agent_client.rs:202:24 [INFO] [stderr] | [INFO] [stderr] 202 | buf[offset + 3] = ((num >> 0) % (1 << 8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:76:6 [INFO] [stderr] | [INFO] [stderr] 76 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/ssh_identity.rs:76:11 [INFO] [stderr] | [INFO] [stderr] 76 | ((buf[offset + 0] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:77:6 [INFO] [stderr] | [INFO] [stderr] 77 | ((buf[offset + 1] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:78:6 [INFO] [stderr] | [INFO] [stderr] 78 | ((buf[offset + 2] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buf[offset + 3] as u32)` [INFO] [stderr] --> src/ssh_identity.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ssh_identity.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | ((buf[offset + 3] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(buf[offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:86:45 [INFO] [stderr] | [INFO] [stderr] 86 | .arg(format!("{}", date_header)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `date_header.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:94:37 [INFO] [stderr] | [INFO] [stderr] 94 | let files = stdout.trim().split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.38s [INFO] running `"docker" "inspect" "71c8d87d2e211befdaad8bfdfab3408069fb83a507b8f20e226bc4dc40d21411"` [INFO] running `"docker" "rm" "-f" "71c8d87d2e211befdaad8bfdfab3408069fb83a507b8f20e226bc4dc40d21411"` [INFO] [stdout] 71c8d87d2e211befdaad8bfdfab3408069fb83a507b8f20e226bc4dc40d21411