[INFO] updating cached repository badouralix/advent-of-code-2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/badouralix/advent-of-code-2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/badouralix/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/badouralix/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/badouralix/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/badouralix/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badouralix/advent-of-code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badouralix/advent-of-code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b14cd20da9325df640451fa18ea1f0b4994f01c3
[INFO] sha for GitHub repo badouralix/advent-of-code-2018: b14cd20da9325df640451fa18ea1f0b4994f01c3
[INFO] validating manifest of badouralix/advent-of-code-2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of badouralix/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing badouralix/advent-of-code-2018
[INFO] finished frobbing badouralix/advent-of-code-2018
[INFO] frobbed toml for badouralix/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/badouralix/advent-of-code-2018/Cargo.toml
[INFO] started frobbing badouralix/advent-of-code-2018
[INFO] finished frobbing badouralix/advent-of-code-2018
[INFO] frobbed toml for badouralix/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badouralix/advent-of-code-2018/Cargo.toml
[INFO] crate badouralix/advent-of-code-2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting badouralix/advent-of-code-2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/badouralix/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 61b8e598e3bea63d542db4d975cef2adf41da1558d6d9dbb68ddefc60c9f0e1d
[INFO] running `"docker" "start" "-a" "61b8e598e3bea63d542db4d975cef2adf41da1558d6d9dbb68ddefc60c9f0e1d"`
[INFO] [stderr]     Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> day-05/part-1/remicalixte.rs:29:31
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn react(c1: Option<&u8>, c2: &u8) -> bool {
[INFO] [stderr]    |                               ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `chars`.
[INFO] [stderr]   --> day-02/part-1/remicalixte.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for i in 0..26 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for <item> in &mut chars {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `HashMap`, `HashSet`
[INFO] [stderr]  --> day-03/part-2/remicalixte.rs:2:24
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::collections::{HashMap, HashSet};
[INFO] [stderr]   |                        ^^^^^^^  ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:21:25
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let i1 = s.find("@").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 |         let i2 = s.find(",").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let i3 = s.find(":").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let i4 = s.find("x").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> day-05/part-1/remicalixte.rs:29:31
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn react(c1: Option<&u8>, c2: &u8) -> bool {
[INFO] [stderr]    |                               ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> day-05/part-2/remicalixte.rs:42:27
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn react_string_ignore(s: &String, i: u8) -> usize {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> day-05/part-2/remicalixte.rs:59:31
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn react(c1: Option<&u8>, c2: &u8) -> bool {
[INFO] [stderr]    |                               ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `chars`.
[INFO] [stderr]   --> day-02/part-1/remicalixte.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for i in 0..26 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 12 |         for <item> in &mut chars {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `HashMap`, `HashSet`
[INFO] [stderr]  --> day-03/part-2/remicalixte.rs:2:24
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::collections::{HashMap, HashSet};
[INFO] [stderr]   |                        ^^^^^^^  ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `run_hashmap`
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:78:1
[INFO] [stderr]    |
[INFO] [stderr] 78 | fn run_hashmap(input: String) -> String {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:21:25
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let i1 = s.find("@").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 |         let i2 = s.find(",").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let i3 = s.find(":").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let i4 = s.find("x").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 | /             match rect1.interset(rect2) {
[INFO] [stderr] 61 | |                 Some(surface) => intersections.push(surface),
[INFO] [stderr] 62 | |                 None => (),
[INFO] [stderr] 63 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(surface) = rect1.interset(rect2) { intersections.push(surface) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:21:25
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let i1 = s.find("@").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 |         let i2 = s.find(",").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let i3 = s.find(":").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-2/remicalixte.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let i4 = s.find("x").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> day-05/part-2/remicalixte.rs:42:27
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn react_string_ignore(s: &String, i: u8) -> usize {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> day-05/part-2/remicalixte.rs:59:31
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn react(c1: Option<&u8>, c2: &u8) -> bool {
[INFO] [stderr]    |                               ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `run_hashmap`
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:78:1
[INFO] [stderr]    |
[INFO] [stderr] 78 | fn run_hashmap(input: String) -> String {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:21:25
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let i1 = s.find("@").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:22:25
[INFO] [stderr]    |
[INFO] [stderr] 22 |         let i2 = s.find(",").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let i3 = s.find(":").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:24:25
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let i4 = s.find("x").ok_or("fail")?;
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `'x'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> day-03/part-1/remicalixte.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 | /             match rect1.interset(rect2) {
[INFO] [stderr] 61 | |                 Some(surface) => intersections.push(surface),
[INFO] [stderr] 62 | |                 None => (),
[INFO] [stderr] 63 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(surface) = rect1.interset(rect2) { intersections.push(surface) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.06s
[INFO] running `"docker" "inspect" "61b8e598e3bea63d542db4d975cef2adf41da1558d6d9dbb68ddefc60c9f0e1d"`
[INFO] running `"docker" "rm" "-f" "61b8e598e3bea63d542db4d975cef2adf41da1558d6d9dbb68ddefc60c9f0e1d"`
[INFO] [stdout] 61b8e598e3bea63d542db4d975cef2adf41da1558d6d9dbb68ddefc60c9f0e1d