[INFO] updating cached repository badlydrawnrod/timeliner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/badlydrawnrod/timeliner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/badlydrawnrod/timeliner" "work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/timeliner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/timeliner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/badlydrawnrod/timeliner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badlydrawnrod/timeliner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badlydrawnrod/timeliner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5baf2d8e674d6e4875992c02349b23d15fadee57 [INFO] sha for GitHub repo badlydrawnrod/timeliner: 5baf2d8e674d6e4875992c02349b23d15fadee57 [INFO] validating manifest of badlydrawnrod/timeliner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of badlydrawnrod/timeliner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing badlydrawnrod/timeliner [INFO] finished frobbing badlydrawnrod/timeliner [INFO] frobbed toml for badlydrawnrod/timeliner written to work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/timeliner/Cargo.toml [INFO] started frobbing badlydrawnrod/timeliner [INFO] finished frobbing badlydrawnrod/timeliner [INFO] frobbed toml for badlydrawnrod/timeliner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badlydrawnrod/timeliner/Cargo.toml [INFO] crate badlydrawnrod/timeliner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting badlydrawnrod/timeliner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/timeliner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eccf60dbd67e4a8ed0941b9b6c5e826a159a8a16c4ab5451de69ab2fd182a201 [INFO] running `"docker" "start" "-a" "eccf60dbd67e4a8ed0941b9b6c5e826a159a8a16c4ab5451de69ab2fd182a201"` [INFO] [stderr] Checking encoding_rs v0.8.4 [INFO] [stderr] Checking timeliner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/utf8_line_reader.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | reader.read(&mut bom)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/utf8_line_reader.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | self.reader.read(&mut b)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utf8_line_reader.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utf8_line_reader.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | if self.line.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utf8_line_reader.rs:64:36 [INFO] [stderr] | [INFO] [stderr] 64 | if self.line.ends_with("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `timeliner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/utf8_line_reader.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | reader.read(&mut bom)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/utf8_line_reader.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | self.reader.read(&mut b)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utf8_line_reader.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utf8_line_reader.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | if self.line.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utf8_line_reader.rs:64:36 [INFO] [stderr] | [INFO] [stderr] 64 | if self.line.ends_with("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `timeliner`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eccf60dbd67e4a8ed0941b9b6c5e826a159a8a16c4ab5451de69ab2fd182a201"` [INFO] running `"docker" "rm" "-f" "eccf60dbd67e4a8ed0941b9b6c5e826a159a8a16c4ab5451de69ab2fd182a201"` [INFO] [stdout] eccf60dbd67e4a8ed0941b9b6c5e826a159a8a16c4ab5451de69ab2fd182a201