[INFO] updating cached repository badlydrawnrod/hexdmp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/badlydrawnrod/hexdmp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/badlydrawnrod/hexdmp" "work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/hexdmp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/hexdmp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/badlydrawnrod/hexdmp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badlydrawnrod/hexdmp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badlydrawnrod/hexdmp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a4be9b2a4d4fc818858c3b195588ec2a24b1491b [INFO] sha for GitHub repo badlydrawnrod/hexdmp: a4be9b2a4d4fc818858c3b195588ec2a24b1491b [INFO] validating manifest of badlydrawnrod/hexdmp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of badlydrawnrod/hexdmp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing badlydrawnrod/hexdmp [INFO] finished frobbing badlydrawnrod/hexdmp [INFO] frobbed toml for badlydrawnrod/hexdmp written to work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/hexdmp/Cargo.toml [INFO] started frobbing badlydrawnrod/hexdmp [INFO] finished frobbing badlydrawnrod/hexdmp [INFO] frobbed toml for badlydrawnrod/hexdmp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badlydrawnrod/hexdmp/Cargo.toml [INFO] crate badlydrawnrod/hexdmp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting badlydrawnrod/hexdmp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/badlydrawnrod/hexdmp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c0377a234e42f7b770c123ad06aac1b9b734840f8bb305a724f585a720173550 [INFO] running `"docker" "start" "-a" "c0377a234e42f7b770c123ad06aac1b9b734840f8bb305a724f585a720173550"` [INFO] [stderr] Checking hexdmp v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/args.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | .map(|f| String::from(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/args.rs:125:33 [INFO] [stderr] | [INFO] [stderr] 125 | } else if input.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/main.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if (i & 7) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i.trailing_zeros() >= 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/args.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | .map(|f| String::from(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/args.rs:125:33 [INFO] [stderr] | [INFO] [stderr] 125 | } else if input.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/main.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if (i & 7) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i.trailing_zeros() >= 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "c0377a234e42f7b770c123ad06aac1b9b734840f8bb305a724f585a720173550"` [INFO] running `"docker" "rm" "-f" "c0377a234e42f7b770c123ad06aac1b9b734840f8bb305a724f585a720173550"` [INFO] [stdout] c0377a234e42f7b770c123ad06aac1b9b734840f8bb305a724f585a720173550