[INFO] updating cached repository badboy/red [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/badboy/red [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/badboy/red" "work/ex/clippy-test-run/sources/stable/gh/badboy/red"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/badboy/red'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/badboy/red" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/red"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/red'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2711f9677a5074e33802ad0a0c88e590706d95df [INFO] sha for GitHub repo badboy/red: 2711f9677a5074e33802ad0a0c88e590706d95df [INFO] validating manifest of badboy/red on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of badboy/red on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing badboy/red [INFO] finished frobbing badboy/red [INFO] frobbed toml for badboy/red written to work/ex/clippy-test-run/sources/stable/gh/badboy/red/Cargo.toml [INFO] started frobbing badboy/red [INFO] finished frobbing badboy/red [INFO] frobbed toml for badboy/red written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/badboy/red/Cargo.toml [INFO] crate badboy/red has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting badboy/red against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/badboy/red:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80a90468df6ea607d5c6bfd8c53ba8d467393342ed6e1cac0d8c2ed585ffb095 [INFO] running `"docker" "start" "-a" "80a90468df6ea607d5c6bfd8c53ba8d467393342ed6e1cac0d8c2ed585ffb095"` [INFO] [stderr] Checking utf8parse v0.1.0 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking rustyline v2.0.1 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking exitfailure v0.5.1 [INFO] [stderr] Checking red-editor v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokenizer.rs:89:24 [INFO] [stderr] | [INFO] [stderr] 89 | if arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokenizer.rs:89:24 [INFO] [stderr] | [INFO] [stderr] 89 | if arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.54s [INFO] running `"docker" "inspect" "80a90468df6ea607d5c6bfd8c53ba8d467393342ed6e1cac0d8c2ed585ffb095"` [INFO] running `"docker" "rm" "-f" "80a90468df6ea607d5c6bfd8c53ba8d467393342ed6e1cac0d8c2ed585ffb095"` [INFO] [stdout] 80a90468df6ea607d5c6bfd8c53ba8d467393342ed6e1cac0d8c2ed585ffb095