[INFO] updating cached repository backuitist/smart-runner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/backuitist/smart-runner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/backuitist/smart-runner" "work/ex/clippy-test-run/sources/stable/gh/backuitist/smart-runner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/backuitist/smart-runner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/backuitist/smart-runner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/backuitist/smart-runner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/backuitist/smart-runner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9150032d7fd5f699664c5b8a3f92ded0729e4d6d [INFO] sha for GitHub repo backuitist/smart-runner: 9150032d7fd5f699664c5b8a3f92ded0729e4d6d [INFO] validating manifest of backuitist/smart-runner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of backuitist/smart-runner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing backuitist/smart-runner [INFO] finished frobbing backuitist/smart-runner [INFO] frobbed toml for backuitist/smart-runner written to work/ex/clippy-test-run/sources/stable/gh/backuitist/smart-runner/Cargo.toml [INFO] started frobbing backuitist/smart-runner [INFO] finished frobbing backuitist/smart-runner [INFO] frobbed toml for backuitist/smart-runner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/backuitist/smart-runner/Cargo.toml [INFO] crate backuitist/smart-runner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting backuitist/smart-runner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/backuitist/smart-runner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] becdf1df1a769769aac7c902fec73536ebc8d389c7ced3cc8ff7a2379ff6921c [INFO] running `"docker" "start" "-a" "becdf1df1a769769aac7c902fec73536ebc8d389c7ced3cc8ff7a2379ff6921c"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking itertools v0.7.6 [INFO] [stderr] Checking num-rational v0.1.41 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking hamcrest v0.1.5 [INFO] [stderr] Checking smart-runner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Placeholders` [INFO] [stderr] --> src/suggestion.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | use command::{Command, Commands, Placeholders}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/screen.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | self.auto_complete.get(idx).unwrap().clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.auto_complete[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/screen.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | / match vk { [INFO] [stderr] 223 | | &ValidatedKeyword::Valid(ref kw) => [INFO] [stderr] 224 | | write_highlighted!(terminal, kw, color::Green)?, [INFO] [stderr] 225 | | [INFO] [stderr] ... | [INFO] [stderr] 228 | | [INFO] [stderr] 229 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *vk { [INFO] [stderr] 223 | ValidatedKeyword::Valid(ref kw) => [INFO] [stderr] 224 | write_highlighted!(terminal, kw, color::Green)?, [INFO] [stderr] 225 | [INFO] [stderr] 226 | ValidatedKeyword::Invalid(ref kw) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/screen.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | write!(colorized, "{}{}{}", color::Fg(color), msg, color::Fg(color::Reset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/command.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn some_description<'a>(self: &'a Command) -> &'a str { [INFO] [stderr] 71 | | self.description.as_ref().map_or("", String::as_str) [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command.rs:82:71 [INFO] [stderr] | [INFO] [stderr] 82 | let commands: Vec> = vec_commands.into_iter().map(|cmd| Rc::new(cmd)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/command.rs:90:53 [INFO] [stderr] | [INFO] [stderr] 90 | let set = kwd2cmd.entry(kw.clone()).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:163:33 [INFO] [stderr] | [INFO] [stderr] 163 | .filter_map(|v| match v { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 164 | | &ValidatedKeyword::Valid(ref kw) => Some(kw), [INFO] [stderr] 165 | | _ => None [INFO] [stderr] 166 | | }).collect(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | .filter_map(|v| match *v { [INFO] [stderr] 164 | ValidatedKeyword::Valid(ref kw) => Some(kw), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/screen.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | self.auto_complete.get(idx).unwrap().clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.auto_complete[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/screen.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | / match vk { [INFO] [stderr] 223 | | &ValidatedKeyword::Valid(ref kw) => [INFO] [stderr] 224 | | write_highlighted!(terminal, kw, color::Green)?, [INFO] [stderr] 225 | | [INFO] [stderr] ... | [INFO] [stderr] 228 | | [INFO] [stderr] 229 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *vk { [INFO] [stderr] 223 | ValidatedKeyword::Valid(ref kw) => [INFO] [stderr] 224 | write_highlighted!(terminal, kw, color::Green)?, [INFO] [stderr] 225 | [INFO] [stderr] 226 | ValidatedKeyword::Invalid(ref kw) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/screen.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | write!(colorized, "{}{}{}", color::Fg(color), msg, color::Fg(color::Reset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/command.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn some_description<'a>(self: &'a Command) -> &'a str { [INFO] [stderr] 71 | | self.description.as_ref().map_or("", String::as_str) [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command.rs:82:71 [INFO] [stderr] | [INFO] [stderr] 82 | let commands: Vec> = vec_commands.into_iter().map(|cmd| Rc::new(cmd)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Rc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/command.rs:90:53 [INFO] [stderr] | [INFO] [stderr] 90 | let set = kwd2cmd.entry(kw.clone()).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:163:33 [INFO] [stderr] | [INFO] [stderr] 163 | .filter_map(|v| match v { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 164 | | &ValidatedKeyword::Valid(ref kw) => Some(kw), [INFO] [stderr] 165 | | _ => None [INFO] [stderr] 166 | | }).collect(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | .filter_map(|v| match *v { [INFO] [stderr] 164 | ValidatedKeyword::Valid(ref kw) => Some(kw), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.97s [INFO] running `"docker" "inspect" "becdf1df1a769769aac7c902fec73536ebc8d389c7ced3cc8ff7a2379ff6921c"` [INFO] running `"docker" "rm" "-f" "becdf1df1a769769aac7c902fec73536ebc8d389c7ced3cc8ff7a2379ff6921c"` [INFO] [stdout] becdf1df1a769769aac7c902fec73536ebc8d389c7ced3cc8ff7a2379ff6921c