[INFO] updating cached repository baby/Rust-Discord [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/baby/Rust-Discord [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/baby/Rust-Discord" "work/ex/clippy-test-run/sources/stable/gh/baby/Rust-Discord"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/baby/Rust-Discord'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/baby/Rust-Discord" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baby/Rust-Discord"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baby/Rust-Discord'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75ac8a5902585247f4f2b81c0bb25f692456f889 [INFO] sha for GitHub repo baby/Rust-Discord: 75ac8a5902585247f4f2b81c0bb25f692456f889 [INFO] validating manifest of baby/Rust-Discord on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of baby/Rust-Discord on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing baby/Rust-Discord [INFO] finished frobbing baby/Rust-Discord [INFO] frobbed toml for baby/Rust-Discord written to work/ex/clippy-test-run/sources/stable/gh/baby/Rust-Discord/Cargo.toml [INFO] started frobbing baby/Rust-Discord [INFO] finished frobbing baby/Rust-Discord [INFO] frobbed toml for baby/Rust-Discord written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/baby/Rust-Discord/Cargo.toml [INFO] crate baby/Rust-Discord has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting baby/Rust-Discord against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/baby/Rust-Discord:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b9ad9f20578ffbbdc4a41b68dd27512a60a27dddc1a6c6a7e219ff6dfd48a19 [INFO] running `"docker" "start" "-a" "6b9ad9f20578ffbbdc4a41b68dd27512a60a27dddc1a6c6a7e219ff6dfd48a19"` [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking discord_bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `chrono::Local` [INFO] [stderr] --> src/commands/general.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use chrono::Local; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `serenity::model::channel::EmbedAuthor` [INFO] [stderr] --> src/commands/general.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use serenity::model::channel::EmbedAuthor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serenity::utils::Colour` [INFO] [stderr] --> src/commands/general.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use serenity::utils::Colour; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/framework/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod framework; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/framework/framework.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/framework/framework.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/framework/framework.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | let client = Client::new(&token, Handler).expect("Error creating client object"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `chrono::Local` [INFO] [stderr] --> src/commands/general.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use chrono::Local; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `serenity::model::channel::EmbedAuthor` [INFO] [stderr] --> src/commands/general.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use serenity::model::channel::EmbedAuthor; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `serenity::utils::Colour` [INFO] [stderr] --> src/commands/general.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use serenity::utils::Colour; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/framework/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod framework; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/framework/framework.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/framework/framework.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | client [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/framework/framework.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | let client = Client::new(&token, Handler).expect("Error creating client object"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'serenity::utils::Colour::red': Use the constant instead [INFO] [stderr] --> src/framework/framework.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | .color(Colour::red()))) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'serenity::utils::Colour::red': Use the constant instead [INFO] [stderr] --> src/framework/framework.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | .color(Colour::red()))) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/framework/framework.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .before(|ctx, msg, command_name| { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `g_id` [INFO] [stderr] --> src/framework/framework.rs:20:52 [INFO] [stderr] | [INFO] [stderr] 20 | fn guild_member_addition(&self, _ctx: Context, g_id: model::id::GuildId, member: model::guild::Member) { [INFO] [stderr] | ^^^^ help: consider using `_g_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/framework/framework.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .before(|ctx, msg, command_name| { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `g_id` [INFO] [stderr] --> src/framework/framework.rs:20:52 [INFO] [stderr] | [INFO] [stderr] 20 | fn guild_member_addition(&self, _ctx: Context, g_id: model::id::GuildId, member: model::guild::Member) { [INFO] [stderr] | ^^^^ help: consider using `_g_id` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/framework/framework.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn create_client(token: &String) -> Client { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/framework/framework.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn create_client(token: &String) -> Client { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.65s [INFO] running `"docker" "inspect" "6b9ad9f20578ffbbdc4a41b68dd27512a60a27dddc1a6c6a7e219ff6dfd48a19"` [INFO] running `"docker" "rm" "-f" "6b9ad9f20578ffbbdc4a41b68dd27512a60a27dddc1a6c6a7e219ff6dfd48a19"` [INFO] [stdout] 6b9ad9f20578ffbbdc4a41b68dd27512a60a27dddc1a6c6a7e219ff6dfd48a19