[INFO] updating cached repository b-r-oleary/passwords [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/b-r-oleary/passwords [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/b-r-oleary/passwords" "work/ex/clippy-test-run/sources/stable/gh/b-r-oleary/passwords"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/b-r-oleary/passwords'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/b-r-oleary/passwords" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/b-r-oleary/passwords"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/b-r-oleary/passwords'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c85100139d8301f72c6948b672e98247571c8a51 [INFO] sha for GitHub repo b-r-oleary/passwords: c85100139d8301f72c6948b672e98247571c8a51 [INFO] validating manifest of b-r-oleary/passwords on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of b-r-oleary/passwords on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing b-r-oleary/passwords [INFO] finished frobbing b-r-oleary/passwords [INFO] frobbed toml for b-r-oleary/passwords written to work/ex/clippy-test-run/sources/stable/gh/b-r-oleary/passwords/Cargo.toml [INFO] started frobbing b-r-oleary/passwords [INFO] finished frobbing b-r-oleary/passwords [INFO] frobbed toml for b-r-oleary/passwords written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/b-r-oleary/passwords/Cargo.toml [INFO] crate b-r-oleary/passwords has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting b-r-oleary/passwords against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/b-r-oleary/passwords:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fab5df879088a9f3a25252aeabcfd726793855f1708c315764bd0f7d7c3f165 [INFO] running `"docker" "start" "-a" "8fab5df879088a9f3a25252aeabcfd726793855f1708c315764bd0f7d7c3f165"` [INFO] [stderr] Checking Inflector v0.11.3 [INFO] [stderr] Checking passwords v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generators/base.rs:53:55 [INFO] [stderr] | [INFO] [stderr] 53 | PasswordIterator { generator: Box::new(self), rng: rng } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generators/random_string.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | characters: characters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generators/base.rs:53:55 [INFO] [stderr] | [INFO] [stderr] 53 | PasswordIterator { generator: Box::new(self), rng: rng } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generators/random_string.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | characters: characters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `characters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/generators/defects.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/defects.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | / s.chars() [INFO] [stderr] 45 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `s.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/defects.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | let chars: Vec = seed.chars().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `seed.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generators/defects.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | let options = self.defects.get(&c).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.defects[&c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generators/phrase.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if seed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!seed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `passwords`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/base.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | let mut iter = passwords.iterator().into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `passwords.iterator()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/generators/defects.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/defects.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | / s.chars() [INFO] [stderr] 45 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `s.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/defects.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | let chars: Vec = seed.chars().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `seed.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generators/defects.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | let options = self.defects.get(&c).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.defects[&c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generators/phrase.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if seed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!seed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generators/phrase.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | assert!(result.unwrap().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generators/phrase.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | assert!(result.unwrap().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generators/phrase.rs:194:17 [INFO] [stderr] | [INFO] [stderr] 194 | assert!(passwords.words.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!passwords.words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generators/phrase.rs:211:51 [INFO] [stderr] | [INFO] [stderr] 211 | let words: Vec<&str> = password.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/generators/phrase.rs:214:46 [INFO] [stderr] | [INFO] [stderr] 214 | words.into_iter().all(|word| { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 215 | | word.len() >= 5 && passwords.words.contains(&word.to_string()) [INFO] [stderr] 216 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generators/phrase.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | assert!(passwords.phrases.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!passwords.phrases.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/generators/phrase.rs:240:51 [INFO] [stderr] | [INFO] [stderr] 240 | let words: Vec<&str> = password.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let characters =` [INFO] [stderr] --> src/generators/random_string.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | let characters = RandomString::new(5).characters.sort(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let expected_characters =` [INFO] [stderr] --> src/generators/random_string.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / let expected_characters = format!( [INFO] [stderr] 73 | | "{}{}{}", DIGITS, ASCII_LOWERCASE, ASCII_UPPERCASE [INFO] [stderr] 74 | | ).chars().into_iter().collect::>().sort(); [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/random_string.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | let expected_characters = format!( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | "{}{}{}", DIGITS, ASCII_LOWERCASE, ASCII_UPPERCASE [INFO] [stderr] 74 | | ).chars().into_iter().collect::>().sort(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 72 | let expected_characters = format!( [INFO] [stderr] 73 | "{}{}{}", DIGITS, ASCII_LOWERCASE, ASCII_UPPERCASE [INFO] [stderr] 74 | ).chars().collect::>().sort(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/generators/random_string.rs:124:58 [INFO] [stderr] | [INFO] [stderr] 124 | assert!(password.chars().into_iter().all(|c| { characters.contains(&c) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/random_string.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | assert!(password.chars().into_iter().all(|c| { characters.contains(&c) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `password.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/generators/random_string.rs:141:63 [INFO] [stderr] | [INFO] [stderr] 141 | assert!(password[3..].chars().into_iter().all(|c| { characters.contains(&c) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generators/random_string.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | assert!(password[3..].chars().into_iter().all(|c| { characters.contains(&c) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `password[3..].chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `passwords`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8fab5df879088a9f3a25252aeabcfd726793855f1708c315764bd0f7d7c3f165"` [INFO] running `"docker" "rm" "-f" "8fab5df879088a9f3a25252aeabcfd726793855f1708c315764bd0f7d7c3f165"` [INFO] [stdout] 8fab5df879088a9f3a25252aeabcfd726793855f1708c315764bd0f7d7c3f165