[INFO] updating cached repository b-m-f/rust_playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/b-m-f/rust_playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/b-m-f/rust_playground" "work/ex/clippy-test-run/sources/stable/gh/b-m-f/rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/b-m-f/rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/b-m-f/rust_playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/b-m-f/rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/b-m-f/rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd5f5c1e312db99abdf4b07d809f0735db153586 [INFO] sha for GitHub repo b-m-f/rust_playground: fd5f5c1e312db99abdf4b07d809f0735db153586 [INFO] validating manifest of b-m-f/rust_playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of b-m-f/rust_playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing b-m-f/rust_playground [INFO] finished frobbing b-m-f/rust_playground [INFO] frobbed toml for b-m-f/rust_playground written to work/ex/clippy-test-run/sources/stable/gh/b-m-f/rust_playground/Cargo.toml [INFO] started frobbing b-m-f/rust_playground [INFO] finished frobbing b-m-f/rust_playground [INFO] frobbed toml for b-m-f/rust_playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/b-m-f/rust_playground/Cargo.toml [INFO] crate b-m-f/rust_playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting b-m-f/rust_playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/b-m-f/rust_playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c11079c6909b309a7e0640915fe1b1475d885a95ae00228cf12f27013a21808 [INFO] running `"docker" "start" "-a" "7c11079c6909b309a7e0640915fe1b1475d885a95ae00228cf12f27013a21808"` [INFO] [stderr] Checking term v0.4.4 [INFO] [stderr] Checking fs_examples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | return n * factorial_recursive(n-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n * factorial_recursive(n-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return sum * ( n + 1 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum * ( n + 1 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `factorial_recursive` [INFO] [stderr] --> src/math.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn factorial_recursive(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `factorial` [INFO] [stderr] --> src/math.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn factorial (n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | return n * factorial_recursive(n-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n * factorial_recursive(n-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return sum * ( n + 1 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum * ( n + 1 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `factorial_recursive` [INFO] [stderr] --> src/math.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn factorial_recursive(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `factorial` [INFO] [stderr] --> src/math.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn factorial (n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.98s [INFO] running `"docker" "inspect" "7c11079c6909b309a7e0640915fe1b1475d885a95ae00228cf12f27013a21808"` [INFO] running `"docker" "rm" "-f" "7c11079c6909b309a7e0640915fe1b1475d885a95ae00228cf12f27013a21808"` [INFO] [stdout] 7c11079c6909b309a7e0640915fe1b1475d885a95ae00228cf12f27013a21808