[INFO] updating cached repository azizunsal/waveformrs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/azizunsal/waveformrs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/azizunsal/waveformrs" "work/ex/clippy-test-run/sources/stable/gh/azizunsal/waveformrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/azizunsal/waveformrs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/azizunsal/waveformrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azizunsal/waveformrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azizunsal/waveformrs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d93c523d240714a19dbca095c424a587758e817 [INFO] sha for GitHub repo azizunsal/waveformrs: 1d93c523d240714a19dbca095c424a587758e817 [INFO] validating manifest of azizunsal/waveformrs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of azizunsal/waveformrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing azizunsal/waveformrs [INFO] finished frobbing azizunsal/waveformrs [INFO] frobbed toml for azizunsal/waveformrs written to work/ex/clippy-test-run/sources/stable/gh/azizunsal/waveformrs/Cargo.toml [INFO] started frobbing azizunsal/waveformrs [INFO] finished frobbing azizunsal/waveformrs [INFO] frobbed toml for azizunsal/waveformrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azizunsal/waveformrs/Cargo.toml [INFO] crate azizunsal/waveformrs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting azizunsal/waveformrs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/azizunsal/waveformrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44a28cc64e9386b58e833c007c5eb4603cd4e283d189e1bf6684b66f2d61f794 [INFO] running `"docker" "start" "-a" "44a28cc64e9386b58e833c007c5eb4603cd4e283d189e1bf6684b66f2d61f794"` [INFO] [stderr] Checking hound v3.1.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking itertools v0.6.1 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking alga v0.5.1 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking nalgebra v0.11.2 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking imageproc v0.9.0 [INFO] [stderr] Checking waveformrs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | theme: theme, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | samples_per_pixel: samples_per_pixel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `samples_per_pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:177:51 [INFO] [stderr] | [INFO] [stderr] 177 | samples_overview.push(SampleOverview {min: min, max: max, rms: rms}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:177:61 [INFO] [stderr] | [INFO] [stderr] 177 | samples_overview.push(SampleOverview {min: min, max: max, rms: rms}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:177:71 [INFO] [stderr] | [INFO] [stderr] 177 | samples_overview.push(SampleOverview {min: min, max: max, rms: rms}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | theme: theme, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | samples_per_pixel: samples_per_pixel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `samples_per_pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:177:51 [INFO] [stderr] | [INFO] [stderr] 177 | samples_overview.push(SampleOverview {min: min, max: max, rms: rms}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:177:61 [INFO] [stderr] | [INFO] [stderr] 177 | samples_overview.push(SampleOverview {min: min, max: max, rms: rms}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:177:71 [INFO] [stderr] | [INFO] [stderr] 177 | samples_overview.push(SampleOverview {min: min, max: max, rms: rms}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | fn calculate_rms(samples: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:149:55 [INFO] [stderr] | [INFO] [stderr] 149 | fn extract_samples(filename: &str, samples_per_pixel: &u32, width: &u32) -> WavFileSummary { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:149:68 [INFO] [stderr] | [INFO] [stderr] 149 | fn extract_samples(filename: &str, samples_per_pixel: &u32, width: &u32) -> WavFileSummary { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | let file_duration = reader.duration() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.duration())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | let total_time = file_duration / spec.sample_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:185:77 [INFO] [stderr] | [INFO] [stderr] 185 | let image_duration = total_time as f64/ samples_overview.len() as f64 * *width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(*width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:206:27 [INFO] [stderr] | [INFO] [stderr] 206 | fn draw_waveform(samples: &Vec, filename: &str, width: u32, height: u32, theme: &WaveformThemes) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[SampleOverview]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | let ref sample_overview = samples[index]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^------------------ help: try: `let sample_overview = &samples[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | min = min + 32768; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `min += 32768` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | max = max + 32768; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `max += 32768` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | rms = rms + 32768f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rms += 32768f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / match theme { [INFO] [stderr] 246 | | &WaveformThemes::Line => { [INFO] [stderr] 247 | | draw_line_segment_mut(&mut img, (x as f32, low_y as f32), (x as f32, high_y as f32), audocity_waveform_color); [INFO] [stderr] 248 | | // Draw RMS for this sample group. [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 245 | match *theme { [INFO] [stderr] 246 | WaveformThemes::Line => { [INFO] [stderr] 247 | draw_line_segment_mut(&mut img, (x as f32, low_y as f32), (x as f32, high_y as f32), audocity_waveform_color); [INFO] [stderr] 248 | // Draw RMS for this sample group. [INFO] [stderr] 249 | draw_line_segment_mut(&mut img, (x as f32, low_rms_y), (x as f32, rms_y), audocity_rms_color); [INFO] [stderr] 250 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | fn calculate_rms(samples: &Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:149:55 [INFO] [stderr] | [INFO] [stderr] 149 | fn extract_samples(filename: &str, samples_per_pixel: &u32, width: &u32) -> WavFileSummary { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:149:68 [INFO] [stderr] | [INFO] [stderr] 149 | fn extract_samples(filename: &str, samples_per_pixel: &u32, width: &u32) -> WavFileSummary { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | let file_duration = reader.duration() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(reader.duration())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | let total_time = file_duration / spec.sample_rate as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:185:77 [INFO] [stderr] | [INFO] [stderr] 185 | let image_duration = total_time as f64/ samples_overview.len() as f64 * *width as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(*width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:206:27 [INFO] [stderr] | [INFO] [stderr] 206 | fn draw_waveform(samples: &Vec, filename: &str, width: u32, height: u32, theme: &WaveformThemes) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[SampleOverview]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | let ref sample_overview = samples[index]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^------------------ help: try: `let sample_overview = &samples[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | min = min + 32768; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `min += 32768` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | max = max + 32768; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `max += 32768` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | rms = rms + 32768f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rms += 32768f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / match theme { [INFO] [stderr] 246 | | &WaveformThemes::Line => { [INFO] [stderr] 247 | | draw_line_segment_mut(&mut img, (x as f32, low_y as f32), (x as f32, high_y as f32), audocity_waveform_color); [INFO] [stderr] 248 | | // Draw RMS for this sample group. [INFO] [stderr] ... | [INFO] [stderr] 257 | | } [INFO] [stderr] 258 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 245 | match *theme { [INFO] [stderr] 246 | WaveformThemes::Line => { [INFO] [stderr] 247 | draw_line_segment_mut(&mut img, (x as f32, low_y as f32), (x as f32, high_y as f32), audocity_waveform_color); [INFO] [stderr] 248 | // Draw RMS for this sample group. [INFO] [stderr] 249 | draw_line_segment_mut(&mut img, (x as f32, low_rms_y), (x as f32, rms_y), audocity_rms_color); [INFO] [stderr] 250 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.68s [INFO] running `"docker" "inspect" "44a28cc64e9386b58e833c007c5eb4603cd4e283d189e1bf6684b66f2d61f794"` [INFO] running `"docker" "rm" "-f" "44a28cc64e9386b58e833c007c5eb4603cd4e283d189e1bf6684b66f2d61f794"` [INFO] [stdout] 44a28cc64e9386b58e833c007c5eb4603cd4e283d189e1bf6684b66f2d61f794