[INFO] updating cached repository azdle/tplink-smart-home [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/azdle/tplink-smart-home [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/azdle/tplink-smart-home" "work/ex/clippy-test-run/sources/stable/gh/azdle/tplink-smart-home"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/azdle/tplink-smart-home'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/azdle/tplink-smart-home" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azdle/tplink-smart-home"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azdle/tplink-smart-home'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b02ae2eb527441433e02382f0920c4314199615c [INFO] sha for GitHub repo azdle/tplink-smart-home: b02ae2eb527441433e02382f0920c4314199615c [INFO] validating manifest of azdle/tplink-smart-home on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of azdle/tplink-smart-home on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing azdle/tplink-smart-home [INFO] finished frobbing azdle/tplink-smart-home [INFO] frobbed toml for azdle/tplink-smart-home written to work/ex/clippy-test-run/sources/stable/gh/azdle/tplink-smart-home/Cargo.toml [INFO] started frobbing azdle/tplink-smart-home [INFO] finished frobbing azdle/tplink-smart-home [INFO] frobbed toml for azdle/tplink-smart-home written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/azdle/tplink-smart-home/Cargo.toml [INFO] crate azdle/tplink-smart-home has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting azdle/tplink-smart-home against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/azdle/tplink-smart-home:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba4ff578b994157eed1f77961fa869c254e85b87f3a4920ef6a566309e2a2d72 [INFO] running `"docker" "start" "-a" "ba4ff578b994157eed1f77961fa869c254e85b87f3a4920ef6a566309e2a2d72"` [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.10 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking tplink-smart-home v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codec.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | last = b ^ last; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `last ^= b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/message.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | System(System), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 6 | System(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codec.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | last = b ^ last; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `last ^= b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/message.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | System(System), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 6 | System(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | response.ok_or(io::Error::new(io::ErrorKind::TimedOut, "timeout waiting for response")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::TimedOut, "timeout waiting for response"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | response.ok_or(io::Error::new(io::ErrorKind::TimedOut, "timeout waiting for response")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::TimedOut, "timeout waiting for response"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | writeln!(io::stderr(), "error: {}", e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | writeln!(io::stderr(), "error: {}", e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.40s [INFO] running `"docker" "inspect" "ba4ff578b994157eed1f77961fa869c254e85b87f3a4920ef6a566309e2a2d72"` [INFO] running `"docker" "rm" "-f" "ba4ff578b994157eed1f77961fa869c254e85b87f3a4920ef6a566309e2a2d72"` [INFO] [stdout] ba4ff578b994157eed1f77961fa869c254e85b87f3a4920ef6a566309e2a2d72