[INFO] updating cached repository ayazhafiz/xela-lang [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ayazhafiz/xela-lang [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ayazhafiz/xela-lang" "work/ex/clippy-test-run/sources/stable/gh/ayazhafiz/xela-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ayazhafiz/xela-lang'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ayazhafiz/xela-lang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ayazhafiz/xela-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ayazhafiz/xela-lang'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 21996448093fed6dd893e6293f9cec3e29362238 [INFO] sha for GitHub repo ayazhafiz/xela-lang: 21996448093fed6dd893e6293f9cec3e29362238 [INFO] validating manifest of ayazhafiz/xela-lang on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ayazhafiz/xela-lang on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ayazhafiz/xela-lang [INFO] finished frobbing ayazhafiz/xela-lang [INFO] frobbed toml for ayazhafiz/xela-lang written to work/ex/clippy-test-run/sources/stable/gh/ayazhafiz/xela-lang/Cargo.toml [INFO] started frobbing ayazhafiz/xela-lang [INFO] finished frobbing ayazhafiz/xela-lang [INFO] frobbed toml for ayazhafiz/xela-lang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ayazhafiz/xela-lang/Cargo.toml [INFO] crate ayazhafiz/xela-lang has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ayazhafiz/xela-lang against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ayazhafiz/xela-lang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b719df365b31723675d6bc53b90109a223c589207239dc6aff1190228221021 [INFO] running `"docker" "start" "-a" "7b719df365b31723675d6bc53b90109a223c589207239dc6aff1190228221021"` [INFO] [stderr] Checking flang v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flang/ast.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flang/ast.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flang/parser/parser.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flang/ast.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flang/ast.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flang/parser/parser.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/flang/interpreter/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod interpreter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/interpreter/interpreter.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return match self.visit(&tree) { [INFO] [stderr] 31 | | Ok(_) => Ok(()), [INFO] [stderr] 32 | | Err(e) => Err(e), [INFO] [stderr] 33 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | match self.visit(&tree) { [INFO] [stderr] 31 | Ok(_) => Ok(()), [INFO] [stderr] 32 | Err(e) => Err(e), [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:127:26 [INFO] [stderr] | [INFO] [stderr] 127 | "@define" => return Ok(Token::DEFINE), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::DEFINE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | "@let" => return Ok(Token::LET), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::LET)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | "fn" => return Ok(Token::FN), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::FN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | "begin" => return Ok(Token::BEGIN), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BEGIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | "end" => return Ok(Token::END), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::END)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | "uint" => return Ok(Token::UintT), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::UintT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | "real" => return Ok(Token::RealT), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::RealT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return Ok(Token::ID(result)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::ID(result))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/flang/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(ASTNode::from(token, vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:95:30 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(_) => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:96:31 [INFO] [stderr] | [INFO] [stderr] 96 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(_) => return Ok(program_node), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(program_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:116:37 [INFO] [stderr] | [INFO] [stderr] 116 | Token::BEGIN => return self.build_statement_lists(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.build_statement_lists()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | Token::ID(_) => return self.parse_assignment(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_assignment()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | _ => return Ok(ASTNode::from(Token::NONE, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(Token::NONE, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / return Err(ProgramError::of( [INFO] [stderr] 174 | | "UnexpectedIdentifier", [INFO] [stderr] 175 | | "Unexpected identifier found in a position after semicolon.", [INFO] [stderr] 176 | | )) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 173 | Err(ProgramError::of( [INFO] [stderr] 174 | "UnexpectedIdentifier", [INFO] [stderr] 175 | "Unexpected identifier found in a position after semicolon.", [INFO] [stderr] 176 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | _ => return Ok(nodes), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(nodes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | return Ok(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | / return Err(ProgramError::of( [INFO] [stderr] 218 | | "UnexpectedType", [INFO] [stderr] 219 | | "Unexpected type declaration.", [INFO] [stderr] 220 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 217 | Err(ProgramError::of( [INFO] [stderr] 218 | "UnexpectedType", [INFO] [stderr] 219 | "Unexpected type declaration.", [INFO] [stderr] 220 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/variable.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(_) => return Ok(ASTNode::from(token, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/variable.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/flang/interpreter/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod interpreter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/interpreter/interpreter.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return match self.visit(&tree) { [INFO] [stderr] 31 | | Ok(_) => Ok(()), [INFO] [stderr] 32 | | Err(e) => Err(e), [INFO] [stderr] 33 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | match self.visit(&tree) { [INFO] [stderr] 31 | Ok(_) => Ok(()), [INFO] [stderr] 32 | Err(e) => Err(e), [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:127:26 [INFO] [stderr] | [INFO] [stderr] 127 | "@define" => return Ok(Token::DEFINE), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::DEFINE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | "@let" => return Ok(Token::LET), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::LET)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:129:21 [INFO] [stderr] | [INFO] [stderr] 129 | "fn" => return Ok(Token::FN), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::FN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | "begin" => return Ok(Token::BEGIN), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BEGIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | "end" => return Ok(Token::END), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::END)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | "uint" => return Ok(Token::UintT), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::UintT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | "real" => return Ok(Token::RealT), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::RealT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/lexer.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return Ok(Token::ID(result)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::ID(result))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/flang/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(ASTNode::from(token, vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(ASTNode::from(token, vec![n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![n]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:95:30 [INFO] [stderr] | [INFO] [stderr] 95 | Ok(_) => return node, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/math.rs:96:31 [INFO] [stderr] | [INFO] [stderr] 96 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(_) => return Ok(program_node), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(program_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:116:37 [INFO] [stderr] | [INFO] [stderr] 116 | Token::BEGIN => return self.build_statement_lists(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.build_statement_lists()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | Token::ID(_) => return self.parse_assignment(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_assignment()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | _ => return Ok(ASTNode::from(Token::NONE, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(Token::NONE, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / return Err(ProgramError::of( [INFO] [stderr] 174 | | "UnexpectedIdentifier", [INFO] [stderr] 175 | | "Unexpected identifier found in a position after semicolon.", [INFO] [stderr] 176 | | )) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 173 | Err(ProgramError::of( [INFO] [stderr] 174 | "UnexpectedIdentifier", [INFO] [stderr] 175 | "Unexpected identifier found in a position after semicolon.", [INFO] [stderr] 176 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | _ => return Ok(nodes), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(nodes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | return Ok(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/statement.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | / return Err(ProgramError::of( [INFO] [stderr] 218 | | "UnexpectedType", [INFO] [stderr] 219 | | "Unexpected type declaration.", [INFO] [stderr] 220 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 217 | Err(ProgramError::of( [INFO] [stderr] 218 | "UnexpectedType", [INFO] [stderr] 219 | "Unexpected type declaration.", [INFO] [stderr] 220 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/variable.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | Ok(_) => return Ok(ASTNode::from(token, vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ASTNode::from(token, vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/flang/parser/builder/variable.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match node.token() { [INFO] [stderr] 16 | | &Token::REAL(_) | &Token::UINT(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 17 | | &Token::MULTIPLY | [INFO] [stderr] 18 | | &Token::DIVIDE | [INFO] [stderr] ... | [INFO] [stderr] 37 | | )), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *node.token() { [INFO] [stderr] 16 | Token::REAL(_) | Token::UINT(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 17 | Token::MULTIPLY | [INFO] [stderr] 18 | Token::DIVIDE | [INFO] [stderr] 19 | Token::DIVIDEINT | [INFO] [stderr] 20 | Token::MODULO | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | if &node.children().len() == &2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 24 | if node.children().len() == 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match node.token() { [INFO] [stderr] 51 | | &Token::REAL(i) => Ok(i as f64), [INFO] [stderr] 52 | | &Token::UINT(i) => Ok(i as f64), [INFO] [stderr] 53 | | _ => Err(ProgramError::of( [INFO] [stderr] ... | [INFO] [stderr] 59 | | )), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *node.token() { [INFO] [stderr] 51 | Token::REAL(i) => Ok(i as f64), [INFO] [stderr] 52 | Token::UINT(i) => Ok(i as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match node.token() { [INFO] [stderr] 68 | | &Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 69 | | &Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 70 | | &Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] ... | [INFO] [stderr] 78 | | )), [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *node.token() { [INFO] [stderr] 68 | Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 69 | Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 70 | Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] 71 | Token::DIVIDE => Ok(left as f64 / right as f64), [INFO] [stderr] 72 | Token::DIVIDEINT => Ok((left as isize / right as isize) as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match node.token() { [INFO] [stderr] 86 | | &Token::PLUS => Ok(expr as f64), [INFO] [stderr] 87 | | &Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 88 | | &Token::FACTORIAL => { [INFO] [stderr] ... | [INFO] [stderr] 106 | | )), [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *node.token() { [INFO] [stderr] 86 | Token::PLUS => Ok(expr as f64), [INFO] [stderr] 87 | Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 88 | Token::FACTORIAL => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/statement.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match node.token() { [INFO] [stderr] 15 | | &Token::LIST => self.visit_list(node), [INFO] [stderr] 16 | | &Token::ASSIGN => self.visit_assign(node), [INFO] [stderr] 17 | | &Token::FACTORY(_) => self.visit_block(&node.children()[0]), [INFO] [stderr] ... | [INFO] [stderr] 22 | | )), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *node.token() { [INFO] [stderr] 15 | Token::LIST => self.visit_list(node), [INFO] [stderr] 16 | Token::ASSIGN => self.visit_assign(node), [INFO] [stderr] 17 | Token::FACTORY(_) => self.visit_block(&node.children()[0]), [INFO] [stderr] 18 | Token::FUNCTION(_) => self.visit_fn(node), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flang/interpreter/visitor/statement.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | Some(value) => Ok(value.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flang/interpreter/visitor/statement.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | let variable = match &node.children()[0].token().clone() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 89 | | &Token::ID(ref v) => v.clone(), [INFO] [stderr] 90 | | _ => { [INFO] [stderr] 91 | | return Err(ProgramError::of( [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | let variable = match node.children()[0].token().clone() { [INFO] [stderr] 89 | Token::ID(ref v) => v.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match node.token() { [INFO] [stderr] 18 | | &Token::LIST | [INFO] [stderr] 19 | | &Token::ASSIGN| [INFO] [stderr] 20 | | &Token::FACTORY(_) => match self.visit_statement(node) { [INFO] [stderr] ... | [INFO] [stderr] 27 | | )), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *node.token() { [INFO] [stderr] 18 | Token::LIST | [INFO] [stderr] 19 | Token::ASSIGN| [INFO] [stderr] 20 | Token::FACTORY(_) => match self.visit_statement(node) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flang/lexer.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | fn peek_ahead(&self, amt: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/flang/symbol_table.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / if !self.table.contains_key(&variable) { [INFO] [stderr] 18 | | self.table.insert(variable, value); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ help: consider using: `self.table.entry(variable).or_insert(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match node.token() { [INFO] [stderr] 16 | | &Token::REAL(_) | &Token::UINT(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 17 | | &Token::MULTIPLY | [INFO] [stderr] 18 | | &Token::DIVIDE | [INFO] [stderr] ... | [INFO] [stderr] 37 | | )), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *node.token() { [INFO] [stderr] 16 | Token::REAL(_) | Token::UINT(_) => Ok(self.visit_number(node).unwrap()), [INFO] [stderr] 17 | Token::MULTIPLY | [INFO] [stderr] 18 | Token::DIVIDE | [INFO] [stderr] 19 | Token::DIVIDEINT | [INFO] [stderr] 20 | Token::MODULO | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | if &node.children().len() == &2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 24 | if node.children().len() == 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match node.token() { [INFO] [stderr] 51 | | &Token::REAL(i) => Ok(i as f64), [INFO] [stderr] 52 | | &Token::UINT(i) => Ok(i as f64), [INFO] [stderr] 53 | | _ => Err(ProgramError::of( [INFO] [stderr] ... | [INFO] [stderr] 59 | | )), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *node.token() { [INFO] [stderr] 51 | Token::REAL(i) => Ok(i as f64), [INFO] [stderr] 52 | Token::UINT(i) => Ok(i as f64), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match node.token() { [INFO] [stderr] 68 | | &Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 69 | | &Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 70 | | &Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] ... | [INFO] [stderr] 78 | | )), [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *node.token() { [INFO] [stderr] 68 | Token::PLUS => Ok((left + right) as f64), [INFO] [stderr] 69 | Token::MINUS => Ok((left - right) as f64), [INFO] [stderr] 70 | Token::MULTIPLY => Ok((left * right) as f64), [INFO] [stderr] 71 | Token::DIVIDE => Ok(left as f64 / right as f64), [INFO] [stderr] 72 | Token::DIVIDEINT => Ok((left as isize / right as isize) as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match node.token() { [INFO] [stderr] 86 | | &Token::PLUS => Ok(expr as f64), [INFO] [stderr] 87 | | &Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 88 | | &Token::FACTORIAL => { [INFO] [stderr] ... | [INFO] [stderr] 106 | | )), [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *node.token() { [INFO] [stderr] 86 | Token::PLUS => Ok(expr as f64), [INFO] [stderr] 87 | Token::MINUS => Ok(-expr as f64), [INFO] [stderr] 88 | Token::FACTORIAL => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/flang/interpreter/visitor/math.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | (1..(val + 1)).fold(1, |acc, value| acc * value) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/statement.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match node.token() { [INFO] [stderr] 15 | | &Token::LIST => self.visit_list(node), [INFO] [stderr] 16 | | &Token::ASSIGN => self.visit_assign(node), [INFO] [stderr] 17 | | &Token::FACTORY(_) => self.visit_block(&node.children()[0]), [INFO] [stderr] ... | [INFO] [stderr] 22 | | )), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *node.token() { [INFO] [stderr] 15 | Token::LIST => self.visit_list(node), [INFO] [stderr] 16 | Token::ASSIGN => self.visit_assign(node), [INFO] [stderr] 17 | Token::FACTORY(_) => self.visit_block(&node.children()[0]), [INFO] [stderr] 18 | Token::FUNCTION(_) => self.visit_fn(node), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/flang/interpreter/visitor/statement.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | Some(value) => Ok(value.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/flang/interpreter/visitor/statement.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | let variable = match &node.children()[0].token().clone() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 89 | | &Token::ID(ref v) => v.clone(), [INFO] [stderr] 90 | | _ => { [INFO] [stderr] 91 | | return Err(ProgramError::of( [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | let variable = match node.children()[0].token().clone() { [INFO] [stderr] 89 | Token::ID(ref v) => v.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/flang/interpreter/visitor/mod.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match node.token() { [INFO] [stderr] 18 | | &Token::LIST | [INFO] [stderr] 19 | | &Token::ASSIGN| [INFO] [stderr] 20 | | &Token::FACTORY(_) => match self.visit_statement(node) { [INFO] [stderr] ... | [INFO] [stderr] 27 | | )), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *node.token() { [INFO] [stderr] 18 | Token::LIST | [INFO] [stderr] 19 | Token::ASSIGN| [INFO] [stderr] 20 | Token::FACTORY(_) => match self.visit_statement(node) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flang/lexer.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | fn peek_ahead(&self, amt: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/flang/symbol_table.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / if !self.table.contains_key(&variable) { [INFO] [stderr] 18 | | self.table.insert(variable, value); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ help: consider using: `self.table.entry(variable).or_insert(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/interpreter.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(*variables.get("a").unwrap(), 10.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/interpreter.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(*variables.get("a").unwrap(), 10.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flang`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "7b719df365b31723675d6bc53b90109a223c589207239dc6aff1190228221021"` [INFO] running `"docker" "rm" "-f" "7b719df365b31723675d6bc53b90109a223c589207239dc6aff1190228221021"` [INFO] [stdout] 7b719df365b31723675d6bc53b90109a223c589207239dc6aff1190228221021