[INFO] updating cached repository axelmagn/angicourt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/axelmagn/angicourt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/axelmagn/angicourt" "work/ex/clippy-test-run/sources/stable/gh/axelmagn/angicourt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/axelmagn/angicourt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/axelmagn/angicourt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/axelmagn/angicourt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/axelmagn/angicourt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a38abf1bf49ed9c874e0a43aa4676d651cc5421 [INFO] sha for GitHub repo axelmagn/angicourt: 1a38abf1bf49ed9c874e0a43aa4676d651cc5421 [INFO] validating manifest of axelmagn/angicourt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of axelmagn/angicourt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing axelmagn/angicourt [INFO] finished frobbing axelmagn/angicourt [INFO] frobbed toml for axelmagn/angicourt written to work/ex/clippy-test-run/sources/stable/gh/axelmagn/angicourt/Cargo.toml [INFO] started frobbing axelmagn/angicourt [INFO] finished frobbing axelmagn/angicourt [INFO] frobbed toml for axelmagn/angicourt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/axelmagn/angicourt/Cargo.toml [INFO] crate axelmagn/angicourt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting axelmagn/angicourt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/axelmagn/angicourt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13dd0df85a42c565f2c2d498822579fb226e2129cf348e5ca51f7bf48fcc379d [INFO] running `"docker" "start" "-a" "13dd0df85a42c565f2c2d498822579fb226e2129cf348e5ca51f7bf48fcc379d"` [INFO] [stderr] Compiling serde v0.9.7 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking pistoncore-event_loop v0.31.3 [INFO] [stderr] Checking piston v0.31.3 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking piston-gfx_texture v0.22.0 [INFO] [stderr] Compiling serde_json v0.9.6 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Compiling libloading v0.3.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking angicourt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_map.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | let job = RenderJob { dx: dx, dy: dy }; [INFO] [stderr] | ^^^^^^ help: replace it with: `dx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_map.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | let job = RenderJob { dx: dx, dy: dy }; [INFO] [stderr] | ^^^^^^ help: replace it with: `dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_map.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | let job = RenderJob { dx: dx, dy: dy }; [INFO] [stderr] | ^^^^^^ help: replace it with: `dx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_map.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | let job = RenderJob { dx: dx, dy: dy }; [INFO] [stderr] | ^^^^^^ help: replace it with: `dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `UpdateArgs` [INFO] [stderr] --> src/rect.rs:3:33 [INFO] [stderr] | [INFO] [stderr] 3 | use piston_window::{RenderArgs, UpdateArgs}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `multiply`, `translate` [INFO] [stderr] --> src/simple_map.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | use piston_window::math::{Vec2d, translate, multiply}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread_rng` [INFO] [stderr] --> src/simple_map.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | use rand::{thread_rng, Rng, SeedableRng, StdRng}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/rect.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | fn render(&self, args: RenderArgs, context: Context, graphics: &mut G2d) -> RenderResult { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/simple_map.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | fn render(&self, args: RenderArgs, context: Context, graphics: &mut G2d) -> RenderResult { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `UpdateResult` [INFO] [stderr] --> src/event_traits.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub type UpdateResult = Result<(), ()>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simple_map.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | self.sprites[i].render(args, c, graphics); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match e { [INFO] [stderr] 75 | | Input::Render(args) => { [INFO] [stderr] 76 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 77 | | clear([0.5, 0.5, 0.5, 1.0], g); [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => {} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let Input::Render(args) = e { [INFO] [stderr] 75 | window.draw_2d(&e, |c, g| { [INFO] [stderr] 76 | clear([0.5, 0.5, 0.5, 1.0], g); [INFO] [stderr] 77 | r.render(args, c, g); [INFO] [stderr] 78 | m.render(args, c, g); [INFO] [stderr] 79 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | r.render(args, c, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | m.render(args, c, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `UpdateArgs` [INFO] [stderr] --> src/rect.rs:3:33 [INFO] [stderr] | [INFO] [stderr] 3 | use piston_window::{RenderArgs, UpdateArgs}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `multiply`, `translate` [INFO] [stderr] --> src/simple_map.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | use piston_window::math::{Vec2d, translate, multiply}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread_rng` [INFO] [stderr] --> src/simple_map.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | use rand::{thread_rng, Rng, SeedableRng, StdRng}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/rect.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | fn render(&self, args: RenderArgs, context: Context, graphics: &mut G2d) -> RenderResult { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/simple_map.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | fn render(&self, args: RenderArgs, context: Context, graphics: &mut G2d) -> RenderResult { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `UpdateResult` [INFO] [stderr] --> src/event_traits.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub type UpdateResult = Result<(), ()>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/simple_map.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | self.sprites[i].render(args, c, graphics); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match e { [INFO] [stderr] 75 | | Input::Render(args) => { [INFO] [stderr] 76 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 77 | | clear([0.5, 0.5, 0.5, 1.0], g); [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => {} [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let Input::Render(args) = e { [INFO] [stderr] 75 | window.draw_2d(&e, |c, g| { [INFO] [stderr] 76 | clear([0.5, 0.5, 0.5, 1.0], g); [INFO] [stderr] 77 | r.render(args, c, g); [INFO] [stderr] 78 | m.render(args, c, g); [INFO] [stderr] 79 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | r.render(args, c, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | m.render(args, c, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.28s [INFO] running `"docker" "inspect" "13dd0df85a42c565f2c2d498822579fb226e2129cf348e5ca51f7bf48fcc379d"` [INFO] running `"docker" "rm" "-f" "13dd0df85a42c565f2c2d498822579fb226e2129cf348e5ca51f7bf48fcc379d"` [INFO] [stdout] 13dd0df85a42c565f2c2d498822579fb226e2129cf348e5ca51f7bf48fcc379d