[INFO] updating cached repository awslabs/fast-pseudoprimes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/awslabs/fast-pseudoprimes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/awslabs/fast-pseudoprimes" "work/ex/clippy-test-run/sources/stable/gh/awslabs/fast-pseudoprimes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/awslabs/fast-pseudoprimes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/awslabs/fast-pseudoprimes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/awslabs/fast-pseudoprimes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/awslabs/fast-pseudoprimes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b8560223174e16f4866e330a4f083e2f35a15606 [INFO] sha for GitHub repo awslabs/fast-pseudoprimes: b8560223174e16f4866e330a4f083e2f35a15606 [INFO] validating manifest of awslabs/fast-pseudoprimes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of awslabs/fast-pseudoprimes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing awslabs/fast-pseudoprimes [INFO] finished frobbing awslabs/fast-pseudoprimes [INFO] frobbed toml for awslabs/fast-pseudoprimes written to work/ex/clippy-test-run/sources/stable/gh/awslabs/fast-pseudoprimes/Cargo.toml [INFO] started frobbing awslabs/fast-pseudoprimes [INFO] finished frobbing awslabs/fast-pseudoprimes [INFO] frobbed toml for awslabs/fast-pseudoprimes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/awslabs/fast-pseudoprimes/Cargo.toml [INFO] crate awslabs/fast-pseudoprimes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting awslabs/fast-pseudoprimes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/awslabs/fast-pseudoprimes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a352e72a92492202ef8f1b119ea82eb3cb1626e891e0817b3eaea5ac98eed5f [INFO] running `"docker" "start" "-a" "9a352e72a92492202ef8f1b119ea82eb3cb1626e891e0817b3eaea5ac98eed5f"` [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.9 [INFO] [stderr] Compiling rug v1.2.2 [INFO] [stderr] Checking modinverse v0.1.0 [INFO] [stderr] Checking pseudoprimes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/conc_bloom.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/conc_bloom.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/mod.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return filtermap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `filtermap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/mod.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return results; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/mod.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | return results; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gray_prod_iter.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return Some((cur_gray, cur_val)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((cur_gray, cur_val))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/magic_numbers.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub const M: u64 = 11908862398227544750; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `11_908_862_398_227_544_750` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/magic_numbers.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | pub const MAX_R: u64 = 1152921504606846976; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_152_921_504_606_846_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/magic_numbers.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / if check_divisor(candidate) { [INFO] [stderr] 69 | | if !results.contains(&candidate) { [INFO] [stderr] 70 | | results.push(candidate); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | if check_divisor(candidate) && !results.contains(&candidate) { [INFO] [stderr] 69 | results.push(candidate); [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/magic_numbers.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/magic_numbers.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | return values_to_multiply; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `values_to_multiply` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/magic_numbers.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bitset/stable.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return BitSet { bits }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitSet { bits }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bitset/stable.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return self.bits[block].load(Ordering::Relaxed) & (1usize << bit) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bits[block].load(Ordering::Relaxed) & (1usize << bit) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/modulus.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return (((a as u128) + (b as u128)) % (self.modulus as u128)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((a as u128) + (b as u128)) % (self.modulus as u128)) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/modulus.rs:89:24 [INFO] [stderr] | [INFO] [stderr] 89 | const M_RECIP : u128 = 0x18c8acd8d948f58b6a0fb2d6e1aaecf8u128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x18c8_acd8_d948_f58b_6a0f_b2d6_e1aa_ecf8u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/modulus.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | return diff as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `diff as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/modulus.rs:248:21 [INFO] [stderr] | [INFO] [stderr] 248 | for _ in 0..1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bloomfilter/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let (node_id, mut f2) = filters.pop().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ expected struct `bloomfilter::conc_bloom::BloomFilter`, found tuple [INFO] [stderr] | [INFO] [stderr] = note: expected type `bloomfilter::conc_bloom::BloomFilter` [INFO] [stderr] found type `(_, _)` [INFO] [stderr] [INFO] [stderr] error[E0609]: no field `1` on type `bloomfilter::conc_bloom::BloomFilter` [INFO] [stderr] --> src/bloomfilter/mod.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | filters[0].1.cross_or(&mut f2); [INFO] [stderr] | ^ unknown field [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bloomfilter/mod.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | for (node, filter) in filters.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ expected struct `bloomfilter::conc_bloom::BloomFilter`, found tuple [INFO] [stderr] | [INFO] [stderr] = note: expected type `bloomfilter::conc_bloom::BloomFilter` [INFO] [stderr] found type `(_, _)` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/conc_bloom.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/conc_bloom.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bloomfilter/conc_bloom.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | for i in 10000..200000 { [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/mod.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return filtermap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `filtermap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/mod.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return results; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bloomfilter/mod.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | return results; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gray_prod_iter.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return Some((cur_gray, cur_val)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((cur_gray, cur_val))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gray_prod_iter.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/magic_numbers.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | pub const M: u64 = 11908862398227544750; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `11_908_862_398_227_544_750` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/magic_numbers.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | pub const MAX_R: u64 = 1152921504606846976; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_152_921_504_606_846_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/magic_numbers.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / if check_divisor(candidate) { [INFO] [stderr] 69 | | if !results.contains(&candidate) { [INFO] [stderr] 70 | | results.push(candidate); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | if check_divisor(candidate) && !results.contains(&candidate) { [INFO] [stderr] 69 | results.push(candidate); [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/magic_numbers.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/magic_numbers.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | return values_to_multiply; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `values_to_multiply` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/magic_numbers.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bitset/stable.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return BitSet { bits }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BitSet { bits }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bitset/stable.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return self.bits[block].load(Ordering::Relaxed) & (1usize << bit) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bits[block].load(Ordering::Relaxed) & (1usize << bit) != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/modulus.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return (((a as u128) + (b as u128)) % (self.modulus as u128)) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(((a as u128) + (b as u128)) % (self.modulus as u128)) as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/modulus.rs:89:24 [INFO] [stderr] | [INFO] [stderr] 89 | const M_RECIP : u128 = 0x18c8acd8d948f58b6a0fb2d6e1aaecf8u128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x18c8_acd8_d948_f58b_6a0f_b2d6_e1aa_ecf8u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/modulus.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | return diff as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `diff as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/modulus.rs:248:21 [INFO] [stderr] | [INFO] [stderr] 248 | for _ in 0..1000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bloomfilter/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let (node_id, mut f2) = filters.pop().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ expected struct `bloomfilter::conc_bloom::BloomFilter`, found tuple [INFO] [stderr] | [INFO] [stderr] = note: expected type `bloomfilter::conc_bloom::BloomFilter` [INFO] [stderr] found type `(_, _)` [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0308, E0609. [INFO] [stderr] For more information about an error, try `rustc --explain E0308`. [INFO] [stderr] error[E0609]: no field `1` on type `bloomfilter::conc_bloom::BloomFilter` [INFO] [stderr] --> src/bloomfilter/mod.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | filters[0].1.cross_or(&mut f2); [INFO] [stderr] | ^ unknown field [INFO] [stderr] [INFO] [stderr] error: Could not compile `pseudoprimes`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bloomfilter/mod.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | for (node, filter) in filters.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ expected struct `bloomfilter::conc_bloom::BloomFilter`, found tuple [INFO] [stderr] | [INFO] [stderr] = note: expected type `bloomfilter::conc_bloom::BloomFilter` [INFO] [stderr] found type `(_, _)` [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0308, E0609. [INFO] [stderr] For more information about an error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `pseudoprimes`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9a352e72a92492202ef8f1b119ea82eb3cb1626e891e0817b3eaea5ac98eed5f"` [INFO] running `"docker" "rm" "-f" "9a352e72a92492202ef8f1b119ea82eb3cb1626e891e0817b3eaea5ac98eed5f"` [INFO] [stdout] 9a352e72a92492202ef8f1b119ea82eb3cb1626e891e0817b3eaea5ac98eed5f