[INFO] updating cached repository avranju/vsan [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/avranju/vsan [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/avranju/vsan" "work/ex/clippy-test-run/sources/stable/gh/avranju/vsan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/avranju/vsan'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/avranju/vsan" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avranju/vsan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avranju/vsan'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3aeafc17169479ad8146ac1903f5609af7f73a13 [INFO] sha for GitHub repo avranju/vsan: 3aeafc17169479ad8146ac1903f5609af7f73a13 [INFO] validating manifest of avranju/vsan on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of avranju/vsan on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing avranju/vsan [INFO] finished frobbing avranju/vsan [INFO] frobbed toml for avranju/vsan written to work/ex/clippy-test-run/sources/stable/gh/avranju/vsan/Cargo.toml [INFO] started frobbing avranju/vsan [INFO] finished frobbing avranju/vsan [INFO] frobbed toml for avranju/vsan written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avranju/vsan/Cargo.toml [INFO] crate avranju/vsan has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting avranju/vsan against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/avranju/vsan:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89cf820ce61984cfb22f608fb8019ff74e36d8aa968743eb69d817ef80db71ee [INFO] running `"docker" "start" "-a" "89cf820ce61984cfb22f608fb8019ff74e36d8aa968743eb69d817ef80db71ee"` [INFO] [stderr] Compiling libc v0.2.36 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Compiling caseless v0.2.0 [INFO] [stderr] Checking vsan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sln_parser.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match PROJECT_RE.captures(&line) { [INFO] [stderr] 14 | | Some(caps) => if caps.len() == 4 { [INFO] [stderr] 15 | | projects.push(VSProject::new(&caps[3], &caps[1], &caps[2])); [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | _ => () [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(caps) = PROJECT_RE.captures(&line) { if caps.len() == 4 { [INFO] [stderr] 14 | projects.push(VSProject::new(&caps[3], &caps[1], &caps[2])); [INFO] [stderr] 15 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sln_parser.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match PROJECT_RE.captures(&line) { [INFO] [stderr] 14 | | Some(caps) => if caps.len() == 4 { [INFO] [stderr] 15 | | projects.push(VSProject::new(&caps[3], &caps[1], &caps[2])); [INFO] [stderr] 16 | | }, [INFO] [stderr] 17 | | _ => () [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | if let Some(caps) = PROJECT_RE.captures(&line) { if caps.len() == 4 { [INFO] [stderr] 14 | projects.push(VSProject::new(&caps[3], &caps[1], &caps[2])); [INFO] [stderr] 15 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.38s [INFO] running `"docker" "inspect" "89cf820ce61984cfb22f608fb8019ff74e36d8aa968743eb69d817ef80db71ee"` [INFO] running `"docker" "rm" "-f" "89cf820ce61984cfb22f608fb8019ff74e36d8aa968743eb69d817ef80db71ee"` [INFO] [stdout] 89cf820ce61984cfb22f608fb8019ff74e36d8aa968743eb69d817ef80db71ee