[INFO] updating cached repository avalarin/elasticsearch-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/avalarin/elasticsearch-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/avalarin/elasticsearch-cli" "work/ex/clippy-test-run/sources/stable/gh/avalarin/elasticsearch-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/avalarin/elasticsearch-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/avalarin/elasticsearch-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avalarin/elasticsearch-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avalarin/elasticsearch-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff7b2eb2eb7d57c9d97b6fb900a0b9e386f02fd9 [INFO] sha for GitHub repo avalarin/elasticsearch-cli: ff7b2eb2eb7d57c9d97b6fb900a0b9e386f02fd9 [INFO] validating manifest of avalarin/elasticsearch-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of avalarin/elasticsearch-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing avalarin/elasticsearch-cli [INFO] finished frobbing avalarin/elasticsearch-cli [INFO] frobbed toml for avalarin/elasticsearch-cli written to work/ex/clippy-test-run/sources/stable/gh/avalarin/elasticsearch-cli/Cargo.toml [INFO] started frobbing avalarin/elasticsearch-cli [INFO] finished frobbing avalarin/elasticsearch-cli [INFO] frobbed toml for avalarin/elasticsearch-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avalarin/elasticsearch-cli/Cargo.toml [INFO] crate avalarin/elasticsearch-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting avalarin/elasticsearch-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/avalarin/elasticsearch-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b4000bed075c88b9011821b5c4598f482b9d2e630c9f4c878b5c4d6bbdf2287 [INFO] running `"docker" "start" "-a" "1b4000bed075c88b9011821b5c4598f482b9d2e630c9f4c878b5c4d6bbdf2287"` [INFO] [stderr] Compiling serde v1.0.35 [INFO] [stderr] Compiling quick-error v1.2.1 [INFO] [stderr] Compiling nom v2.2.1 [INFO] [stderr] Checking elastic_requests v0.20.9 [INFO] [stderr] Compiling time v0.1.39 [INFO] [stderr] Compiling num-integer v0.1.36 [INFO] [stderr] Checking chrono v0.4.1 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Checking openssl-sys v0.9.27 [INFO] [stderr] Checking stderrlog v0.3.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-threadpool v0.1.1 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking geo v0.4.13 [INFO] [stderr] Checking elastic_responses v0.20.9 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Checking spade v1.4.0 [INFO] [stderr] Checking tokio v0.1.4 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking geohash v0.4.0 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Compiling serde_json v1.0.13 [INFO] [stderr] Checking geo v0.6.3 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling elastic_types_derive_internals v0.20.9 [INFO] [stderr] Compiling elastic_types_derive v0.20.9 [INFO] [stderr] Compiling elastic_derive v0.20.9 [INFO] [stderr] Checking geojson v0.9.1 [INFO] [stderr] Checking hyper v0.11.24 [INFO] [stderr] Checking elastic_types v0.20.9 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking elastic_reqwest v0.20.9 [INFO] [stderr] Checking elastic v0.20.9 [INFO] [stderr] Checking elastic-cli v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/search.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | buffer_size: buffer_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/search.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/search.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | output_format: output_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/search.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | buffer_size: buffer_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/search.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/search.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | output_format: output_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod config; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config/config.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / return self.servers.iter().find(|server| server.name == server_name) [INFO] [stderr] 75 | | .ok_or(config::GetServerError::ServerNotFound(server_name.clone())) [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | self.servers.iter().find(|server| server.name == server_name) [INFO] [stderr] 75 | .ok_or(config::GetServerError::ServerNotFound(server_name.clone())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod config; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config/config.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / return self.servers.iter().find(|server| server.name == server_name) [INFO] [stderr] 75 | | .ok_or(config::GetServerError::ServerNotFound(server_name.clone())) [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | self.servers.iter().find(|server| server.name == server_name) [INFO] [stderr] 75 | .ok_or(config::GetServerError::ServerNotFound(server_name.clone())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/config.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/config.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | .ok_or(config::GetServerError::ServerNotFound(server_name.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| config::GetServerError::ServerNotFound(server_name.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/commands/search.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | .or(self.server_config.default_index.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.server_config.default_index.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/commands/search.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | self.from = self.from + result_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.from += result_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/commands/search.rs:164:68 [INFO] [stderr] | [INFO] [stderr] 164 | println!("{}", strfmt(format, &self.collect(item)).unwrap_or("Cannot format item".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Cannot format item".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/search.rs:171:58 [INFO] [stderr] | [INFO] [stderr] 171 | &serde_json::Value::String(ref str_value) => format!("{}", str_value), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `str_value.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/commands/search.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | Some(value.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/commands/config.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | if self.config.servers.iter().find(|server| server.name == name).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|server| server.name == name).is_some()` with `any(|server| server.name == name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/commands/config.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | address.map(|addr| server.server = addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(addr) = address { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match run_application() { [INFO] [stderr] 24 | | Err(cause) => { [INFO] [stderr] 25 | | error!("{}", cause); [INFO] [stderr] 26 | | std::process::exit(1); [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | _ => { } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(cause) = run_application() { [INFO] [stderr] 24 | error!("{}", cause); [INFO] [stderr] 25 | std::process::exit(1); [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:88:63 [INFO] [stderr] | [INFO] [stderr] 88 | let fields = sub_match.value_of("fields").map(|f| f.split(",").collect()); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config/config.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | .ok_or(config::GetServerError::ServerNotFound(server_name.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| config::GetServerError::ServerNotFound(server_name.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/commands/search.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | .or(self.server_config.default_index.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.server_config.default_index.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/commands/search.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | self.from = self.from + result_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.from += result_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/commands/search.rs:164:68 [INFO] [stderr] | [INFO] [stderr] 164 | println!("{}", strfmt(format, &self.collect(item)).unwrap_or("Cannot format item".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Cannot format item".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/search.rs:171:58 [INFO] [stderr] | [INFO] [stderr] 171 | &serde_json::Value::String(ref str_value) => format!("{}", str_value), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `str_value.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/commands/search.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | Some(value.into()) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/commands/config.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | if self.config.servers.iter().find(|server| server.name == name).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|server| server.name == name).is_some()` with `any(|server| server.name == name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/commands/config.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | address.map(|addr| server.server = addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(addr) = address { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match run_application() { [INFO] [stderr] 24 | | Err(cause) => { [INFO] [stderr] 25 | | error!("{}", cause); [INFO] [stderr] 26 | | std::process::exit(1); [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | _ => { } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(cause) = run_application() { [INFO] [stderr] 24 | error!("{}", cause); [INFO] [stderr] 25 | std::process::exit(1); [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:88:63 [INFO] [stderr] | [INFO] [stderr] 88 | let fields = sub_match.value_of("fields").map(|f| f.split(",").collect()); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "1b4000bed075c88b9011821b5c4598f482b9d2e630c9f4c878b5c4d6bbdf2287"` [INFO] running `"docker" "rm" "-f" "1b4000bed075c88b9011821b5c4598f482b9d2e630c9f4c878b5c4d6bbdf2287"` [INFO] [stdout] 1b4000bed075c88b9011821b5c4598f482b9d2e630c9f4c878b5c4d6bbdf2287