[INFO] updating cached repository avahowell/npm-flip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/avahowell/npm-flip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/avahowell/npm-flip" "work/ex/clippy-test-run/sources/stable/gh/avahowell/npm-flip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/avahowell/npm-flip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/avahowell/npm-flip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avahowell/npm-flip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avahowell/npm-flip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2c0f5f91d160d8565b303a0f66c7d973d82808b4 [INFO] sha for GitHub repo avahowell/npm-flip: 2c0f5f91d160d8565b303a0f66c7d973d82808b4 [INFO] validating manifest of avahowell/npm-flip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of avahowell/npm-flip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing avahowell/npm-flip [INFO] finished frobbing avahowell/npm-flip [INFO] frobbed toml for avahowell/npm-flip written to work/ex/clippy-test-run/sources/stable/gh/avahowell/npm-flip/Cargo.toml [INFO] started frobbing avahowell/npm-flip [INFO] finished frobbing avahowell/npm-flip [INFO] frobbed toml for avahowell/npm-flip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/avahowell/npm-flip/Cargo.toml [INFO] crate avahowell/npm-flip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting avahowell/npm-flip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/avahowell/npm-flip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87ee351663cb935ba919d8b0260b1090da81d2b068a5a2b4a22ad5372e3a39d6 [INFO] running `"docker" "start" "-a" "87ee351663cb935ba919d8b0260b1090da81d2b068a5a2b4a22ad5372e3a39d6"` [INFO] [stderr] Checking npm-flip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return core.run(work).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `core.run(work).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return res.body().concat2().map(|body| { [INFO] [stderr] 24 | | let data :Value = serde_json::from_slice(&body).unwrap(); [INFO] [stderr] 25 | | if let Some(latest_tag) = data["dist-tags"]["latest"].as_str() { [INFO] [stderr] 26 | | if data["versions"][latest_tag]["dependencies"][package_name.as_str()].is_string() || [INFO] [stderr] ... | [INFO] [stderr] 31 | | return false [INFO] [stderr] 32 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | res.body().concat2().map(|body| { [INFO] [stderr] 24 | let data :Value = serde_json::from_slice(&body).unwrap(); [INFO] [stderr] 25 | if let Some(latest_tag) = data["dist-tags"]["latest"].as_str() { [INFO] [stderr] 26 | if data["versions"][latest_tag]["dependencies"][package_name.as_str()].is_string() || [INFO] [stderr] 27 | data["versions"][latest_tag]["devDependencies"][package_name.as_str()].is_string() { [INFO] [stderr] 28 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return String::from_utf8(string_bytes).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(string_bytes).ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return core.run(work).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `core.run(work).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return res.body().concat2().map(|body| { [INFO] [stderr] 24 | | let data :Value = serde_json::from_slice(&body).unwrap(); [INFO] [stderr] 25 | | if let Some(latest_tag) = data["dist-tags"]["latest"].as_str() { [INFO] [stderr] 26 | | if data["versions"][latest_tag]["dependencies"][package_name.as_str()].is_string() || [INFO] [stderr] ... | [INFO] [stderr] 31 | | return false [INFO] [stderr] 32 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | res.body().concat2().map(|body| { [INFO] [stderr] 24 | let data :Value = serde_json::from_slice(&body).unwrap(); [INFO] [stderr] 25 | if let Some(latest_tag) = data["dist-tags"]["latest"].as_str() { [INFO] [stderr] 26 | if data["versions"][latest_tag]["dependencies"][package_name.as_str()].is_string() || [INFO] [stderr] 27 | data["versions"][latest_tag]["devDependencies"][package_name.as_str()].is_string() { [INFO] [stderr] 28 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return String::from_utf8(string_bytes).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(string_bytes).ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | fn is_cyclical(flipped_name: &String, package_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:18:53 [INFO] [stderr] | [INFO] [stderr] 18 | fn is_cyclical(flipped_name: &String, package_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | fn flip_str(input: &String, character_index :usize, shift: u8) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | fn flip_exhaustive(original: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | fn is_cyclical(flipped_name: &String, package_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:18:53 [INFO] [stderr] | [INFO] [stderr] 18 | fn is_cyclical(flipped_name: &String, package_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | fn flip_str(input: &String, character_index :usize, shift: u8) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> main.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | fn flip_exhaustive(original: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.32s [INFO] running `"docker" "inspect" "87ee351663cb935ba919d8b0260b1090da81d2b068a5a2b4a22ad5372e3a39d6"` [INFO] running `"docker" "rm" "-f" "87ee351663cb935ba919d8b0260b1090da81d2b068a5a2b4a22ad5372e3a39d6"` [INFO] [stdout] 87ee351663cb935ba919d8b0260b1090da81d2b068a5a2b4a22ad5372e3a39d6