[INFO] updating cached repository av-elier/sqs-to-slack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/av-elier/sqs-to-slack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/av-elier/sqs-to-slack" "work/ex/clippy-test-run/sources/stable/gh/av-elier/sqs-to-slack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/av-elier/sqs-to-slack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/av-elier/sqs-to-slack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/av-elier/sqs-to-slack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/av-elier/sqs-to-slack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c0bfef99a85c80379ea4d6bb56854fe1e3c9bae [INFO] sha for GitHub repo av-elier/sqs-to-slack: 5c0bfef99a85c80379ea4d6bb56854fe1e3c9bae [INFO] validating manifest of av-elier/sqs-to-slack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of av-elier/sqs-to-slack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing av-elier/sqs-to-slack [INFO] finished frobbing av-elier/sqs-to-slack [INFO] frobbed toml for av-elier/sqs-to-slack written to work/ex/clippy-test-run/sources/stable/gh/av-elier/sqs-to-slack/Cargo.toml [INFO] started frobbing av-elier/sqs-to-slack [INFO] finished frobbing av-elier/sqs-to-slack [INFO] frobbed toml for av-elier/sqs-to-slack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/av-elier/sqs-to-slack/Cargo.toml [INFO] crate av-elier/sqs-to-slack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting av-elier/sqs-to-slack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/av-elier/sqs-to-slack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07cc40020c314ac62c220dbe59d3fc169674b07e5703c9d58f06c4f77a471c24 [INFO] running `"docker" "start" "-a" "07cc40020c314ac62c220dbe59d3fc169674b07e5703c9d58f06c4f77a471c24"` [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking serde-hjson v0.8.2 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking rusoto_credential v0.13.0 [INFO] [stderr] Checking rusoto_core v0.34.0 [INFO] [stderr] Checking rusoto_sqs v0.34.0 [INFO] [stderr] Checking sqs-to-slack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slack.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slack.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sqs.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | queue_url: queue_url, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sqs.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | queue_url: queue_url, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queue_url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slack.rs:68:70 [INFO] [stderr] | [INFO] [stderr] 68 | "title": format!("Id {}", sqs_msg.clone().message_id.unwrap_or("_no id_".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_no id_".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/slack.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | "text": format!("{:?}", sqs_msg.clone().attributes.unwrap_or(std::collections::HashMap::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `sqs_msg.clone().attributes.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slack.rs:73:66 [INFO] [stderr] | [INFO] [stderr] 73 | "text": format!("```{}```", sqs_msg.clone().body.unwrap_or("_no body_".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_no body_".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slack.rs:68:70 [INFO] [stderr] | [INFO] [stderr] 68 | "title": format!("Id {}", sqs_msg.clone().message_id.unwrap_or("_no id_".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_no id_".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/slack.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | "text": format!("{:?}", sqs_msg.clone().attributes.unwrap_or(std::collections::HashMap::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `sqs_msg.clone().attributes.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/slack.rs:73:66 [INFO] [stderr] | [INFO] [stderr] 73 | "text": format!("```{}```", sqs_msg.clone().body.unwrap_or("_no body_".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_no body_".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.47s [INFO] running `"docker" "inspect" "07cc40020c314ac62c220dbe59d3fc169674b07e5703c9d58f06c4f77a471c24"` [INFO] running `"docker" "rm" "-f" "07cc40020c314ac62c220dbe59d3fc169674b07e5703c9d58f06c4f77a471c24"` [INFO] [stdout] 07cc40020c314ac62c220dbe59d3fc169674b07e5703c9d58f06c4f77a471c24