[INFO] updating cached repository audunhalland/spectro_wasm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/audunhalland/spectro_wasm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/audunhalland/spectro_wasm" "work/ex/clippy-test-run/sources/stable/gh/audunhalland/spectro_wasm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/audunhalland/spectro_wasm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/audunhalland/spectro_wasm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/audunhalland/spectro_wasm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/audunhalland/spectro_wasm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bdd65bd912dbe8306b28c938ebe5a77c1d6de371 [INFO] sha for GitHub repo audunhalland/spectro_wasm: bdd65bd912dbe8306b28c938ebe5a77c1d6de371 [INFO] validating manifest of audunhalland/spectro_wasm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of audunhalland/spectro_wasm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing audunhalland/spectro_wasm [INFO] finished frobbing audunhalland/spectro_wasm [INFO] frobbed toml for audunhalland/spectro_wasm written to work/ex/clippy-test-run/sources/stable/gh/audunhalland/spectro_wasm/Cargo.toml [INFO] started frobbing audunhalland/spectro_wasm [INFO] finished frobbing audunhalland/spectro_wasm [INFO] frobbed toml for audunhalland/spectro_wasm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/audunhalland/spectro_wasm/Cargo.toml [INFO] crate audunhalland/spectro_wasm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting audunhalland/spectro_wasm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/audunhalland/spectro_wasm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21c5d9f1d1ac7d9ae76f8bd2a1ac8732ac72f1d39cfab42d582af85490e56f85 [INFO] running `"docker" "start" "-a" "21c5d9f1d1ac7d9ae76f8bd2a1ac8732ac72f1d39cfab42d582af85490e56f85"` [INFO] [stderr] Checking bresenham v0.1.1 [INFO] [stderr] Checking rustfft v2.0.0 [INFO] [stderr] Checking spectro_wasm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gfx.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | self.pixel_oob_check(Point { x: x, y: y }, value); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gfx.rs:62:48 [INFO] [stderr] | [INFO] [stderr] 62 | self.pixel_oob_check(Point { x: x, y: y }, value); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | bufsize: bufsize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bufsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | fmin: fmin, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fmin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:104:44 [INFO] [stderr] | [INFO] [stderr] 104 | surface.bresenham(gfx::Point { x: x, y: y0 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:105:44 [INFO] [stderr] | [INFO] [stderr] 105 | gfx::Point { x: x, y: y1 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gfx.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | self.pixel_oob_check(Point { x: x, y: y }, value); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gfx.rs:62:48 [INFO] [stderr] | [INFO] [stderr] 62 | self.pixel_oob_check(Point { x: x, y: y }, value); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | bufsize: bufsize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bufsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | fmin: fmin, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fmin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:104:44 [INFO] [stderr] | [INFO] [stderr] 104 | surface.bresenham(gfx::Point { x: x, y: y0 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectro.rs:105:44 [INFO] [stderr] | [INFO] [stderr] 105 | gfx::Point { x: x, y: y1 }, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.r as u32)` [INFO] [stderr] --> src/gfx.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | (self.r as u32) << 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | (self.r as u32) << 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | | (self.g as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | | (self.b as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | | (self.a as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/spectro.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | let bin_energy = (&energies[bin_index0 .. bin_index1 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `bin_index0..=bin_index1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.r as u32)` [INFO] [stderr] --> src/gfx.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | (self.r as u32) << 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | (self.r as u32) << 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | | (self.g as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | | (self.b as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gfx.rs:16:15 [INFO] [stderr] | [INFO] [stderr] 16 | | (self.a as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/spectro.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | let bin_energy = (&energies[bin_index0 .. bin_index1 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `bin_index0..=bin_index1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.11s [INFO] running `"docker" "inspect" "21c5d9f1d1ac7d9ae76f8bd2a1ac8732ac72f1d39cfab42d582af85490e56f85"` [INFO] running `"docker" "rm" "-f" "21c5d9f1d1ac7d9ae76f8bd2a1ac8732ac72f1d39cfab42d582af85490e56f85"` [INFO] [stdout] 21c5d9f1d1ac7d9ae76f8bd2a1ac8732ac72f1d39cfab42d582af85490e56f85