[INFO] updating cached repository atten-dev/uniform-invoice-lottery [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/atten-dev/uniform-invoice-lottery [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/atten-dev/uniform-invoice-lottery" "work/ex/clippy-test-run/sources/stable/gh/atten-dev/uniform-invoice-lottery"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atten-dev/uniform-invoice-lottery'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/atten-dev/uniform-invoice-lottery" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atten-dev/uniform-invoice-lottery"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atten-dev/uniform-invoice-lottery'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ee96588ffab04660d25c2ff93ec407f41a13ac86 [INFO] sha for GitHub repo atten-dev/uniform-invoice-lottery: ee96588ffab04660d25c2ff93ec407f41a13ac86 [INFO] validating manifest of atten-dev/uniform-invoice-lottery on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atten-dev/uniform-invoice-lottery on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atten-dev/uniform-invoice-lottery [INFO] finished frobbing atten-dev/uniform-invoice-lottery [INFO] frobbed toml for atten-dev/uniform-invoice-lottery written to work/ex/clippy-test-run/sources/stable/gh/atten-dev/uniform-invoice-lottery/Cargo.toml [INFO] started frobbing atten-dev/uniform-invoice-lottery [INFO] finished frobbing atten-dev/uniform-invoice-lottery [INFO] frobbed toml for atten-dev/uniform-invoice-lottery written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atten-dev/uniform-invoice-lottery/Cargo.toml [INFO] crate atten-dev/uniform-invoice-lottery has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atten-dev/uniform-invoice-lottery against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/atten-dev/uniform-invoice-lottery:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a13e7806a6f6ec1955783938cae5d88057d3245c0a2de3eb32224bca75cc907 [INFO] running `"docker" "start" "-a" "7a13e7806a6f6ec1955783938cae5d88057d3245c0a2de3eb32224bca75cc907"` [INFO] [stderr] Checking uniform-invoice-lottery v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 68 | | if ticket.len() != 0 [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | println!("Ticket {} is malformed. Exiting.", ticket); [INFO] [stderr] 71 | | process::exit(1); [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | else if ticket.len() != 0 [INFO] [stderr] 68 | { [INFO] [stderr] 69 | println!("Ticket {} is malformed. Exiting.", ticket); [INFO] [stderr] 70 | process::exit(1); [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/checker.rs:86:95 [INFO] [stderr] | [INFO] [stderr] 86 | else if ticket_rev.chars().take(3).eq(winning_numbers.additional_prizes[1].chars().rev()) { [INFO] [stderr] | _______________________________________________________________________________________________^ [INFO] [stderr] 87 | | PrizeType::ADDITIONAL [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/checker.rs:83:95 [INFO] [stderr] | [INFO] [stderr] 83 | else if ticket_rev.chars().take(3).eq(winning_numbers.additional_prizes[0].chars().rev()) { [INFO] [stderr] | _______________________________________________________________________________________________^ [INFO] [stderr] 84 | | PrizeType::ADDITIONAL [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `args` [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 1..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for (i, ) in args.iter().enumerate().take(6).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | let tickets : Vec<&str> = contents.split("\n").map(|t| t.trim()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if ticket.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ticket.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uniform-invoice-lottery`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 68 | | if ticket.len() != 0 [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | println!("Ticket {} is malformed. Exiting.", ticket); [INFO] [stderr] 71 | | process::exit(1); [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 67 | else if ticket.len() != 0 [INFO] [stderr] 68 | { [INFO] [stderr] 69 | println!("Ticket {} is malformed. Exiting.", ticket); [INFO] [stderr] 70 | process::exit(1); [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/checker.rs:86:95 [INFO] [stderr] | [INFO] [stderr] 86 | else if ticket_rev.chars().take(3).eq(winning_numbers.additional_prizes[1].chars().rev()) { [INFO] [stderr] | _______________________________________________________________________________________________^ [INFO] [stderr] 87 | | PrizeType::ADDITIONAL [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/checker.rs:83:95 [INFO] [stderr] | [INFO] [stderr] 83 | else if ticket_rev.chars().take(3).eq(winning_numbers.additional_prizes[0].chars().rev()) { [INFO] [stderr] | _______________________________________________________________________________________________^ [INFO] [stderr] 84 | | PrizeType::ADDITIONAL [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `args` [INFO] [stderr] --> src/main.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 1..6 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for (i, ) in args.iter().enumerate().take(6).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | let tickets : Vec<&str> = contents.split("\n").map(|t| t.trim()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if ticket.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ticket.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uniform-invoice-lottery`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7a13e7806a6f6ec1955783938cae5d88057d3245c0a2de3eb32224bca75cc907"` [INFO] running `"docker" "rm" "-f" "7a13e7806a6f6ec1955783938cae5d88057d3245c0a2de3eb32224bca75cc907"` [INFO] [stdout] 7a13e7806a6f6ec1955783938cae5d88057d3245c0a2de3eb32224bca75cc907