[INFO] updating cached repository atsushi130/perceptron [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/atsushi130/perceptron [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/atsushi130/perceptron" "work/ex/clippy-test-run/sources/stable/gh/atsushi130/perceptron"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atsushi130/perceptron'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/atsushi130/perceptron" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/perceptron"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/perceptron'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] faa5fe3c75986bcab83ca02d6551b0a4ddca9c3c [INFO] sha for GitHub repo atsushi130/perceptron: faa5fe3c75986bcab83ca02d6551b0a4ddca9c3c [INFO] validating manifest of atsushi130/perceptron on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atsushi130/perceptron on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atsushi130/perceptron [INFO] finished frobbing atsushi130/perceptron [INFO] frobbed toml for atsushi130/perceptron written to work/ex/clippy-test-run/sources/stable/gh/atsushi130/perceptron/Cargo.toml [INFO] started frobbing atsushi130/perceptron [INFO] finished frobbing atsushi130/perceptron [INFO] frobbed toml for atsushi130/perceptron written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atsushi130/perceptron/Cargo.toml [INFO] crate atsushi130/perceptron has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atsushi130/perceptron against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/atsushi130/perceptron:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33f1d5323bb513198530e06aee5fc79474d86b17b51eff3e35d4ba0787c04843 [INFO] running `"docker" "start" "-a" "33f1d5323bb513198530e06aee5fc79474d86b17b51eff3e35d4ba0787c04843"` [INFO] [stderr] Checking perceptron v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/file_operator/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod file_operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/file_operator/parser/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/learner/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod learner; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/learner/perceptron/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod perceptron; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | self.sign((x as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | self.sign((x as f64)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/file_operator/file_operator.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | reader.lines().into_iter().map( |line| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `reader.lines()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | for (word, _) in &key_values { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 25 | for word in key_values.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | for (word, _) in &key_values { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 30 | for word in key_values.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | ).fold(0, |sum, x| sum + x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / match self.word_model.contains_key(word) { [INFO] [stderr] 59 | | true => self.word_model[word] * key_values[word], [INFO] [stderr] 60 | | false => 0, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.word_model.contains_key(word) { self.word_model[word] * key_values[word] } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | self.sign((x as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match x < 0. { [INFO] [stderr] 69 | | true => -1, [INFO] [stderr] 70 | | false => 1 [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if x < 0. { -1 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/file_operator/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod file_operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/file_operator/parser/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/learner/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod learner; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/learner/perceptron/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod perceptron; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | self.sign((x as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | self.sign((x as f64)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/file_operator/file_operator.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | reader.lines().into_iter().map( |line| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `reader.lines()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | for (word, _) in &key_values { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 25 | for word in key_values.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | for (word, _) in &key_values { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 30 | for word in key_values.keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | ).fold(0, |sum, x| sum + x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / match self.word_model.contains_key(word) { [INFO] [stderr] 59 | | true => self.word_model[word] * key_values[word], [INFO] [stderr] 60 | | false => 0, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.word_model.contains_key(word) { self.word_model[word] * key_values[word] } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | self.sign((x as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/learner/perceptron/perceptron.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match x < 0. { [INFO] [stderr] 69 | | true => -1, [INFO] [stderr] 70 | | false => 1 [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if x < 0. { -1 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "33f1d5323bb513198530e06aee5fc79474d86b17b51eff3e35d4ba0787c04843"` [INFO] running `"docker" "rm" "-f" "33f1d5323bb513198530e06aee5fc79474d86b17b51eff3e35d4ba0787c04843"` [INFO] [stdout] 33f1d5323bb513198530e06aee5fc79474d86b17b51eff3e35d4ba0787c04843