[INFO] updating cached repository atoav/bender-bouncer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/atoav/bender-bouncer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/atoav/bender-bouncer" "work/ex/clippy-test-run/sources/stable/gh/atoav/bender-bouncer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atoav/bender-bouncer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/atoav/bender-bouncer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atoav/bender-bouncer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atoav/bender-bouncer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93c0d7d27dbae9019a62099e63208b6857ffdb5b [INFO] sha for GitHub repo atoav/bender-bouncer: 93c0d7d27dbae9019a62099e63208b6857ffdb5b [INFO] validating manifest of atoav/bender-bouncer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of atoav/bender-bouncer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing atoav/bender-bouncer [INFO] finished frobbing atoav/bender-bouncer [INFO] frobbed toml for atoav/bender-bouncer written to work/ex/clippy-test-run/sources/stable/gh/atoav/bender-bouncer/Cargo.toml [INFO] started frobbing atoav/bender-bouncer [INFO] finished frobbing atoav/bender-bouncer [INFO] frobbed toml for atoav/bender-bouncer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atoav/bender-bouncer/Cargo.toml [INFO] crate atoav/bender-bouncer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting atoav/bender-bouncer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/atoav/bender-bouncer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 61b524a2c03db47d68e6c97e341d879618a10973e5af7c083403ccf73fb783a3 [INFO] running `"docker" "start" "-a" "61b524a2c03db47d68e6c97e341d879618a10973e5af7c083403ccf73fb783a3"` [INFO] [stderr] Checking miniz-sys v0.1.11 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking bender_bouncer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | if &head[0..2] == &[0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 74 | if head[0..2] == [0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:103:8 [INFO] [stderr] | [INFO] [stderr] 103 | if &buf[0..2] == &[0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 103 | if buf[0..2] == [0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | if &head[0..2] == &[0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 74 | if head[0..2] == [0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:103:8 [INFO] [stderr] | [INFO] [stderr] 103 | if &buf[0..2] == &[0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 103 | if buf[0..2] == [0x1f, 0x8b]{ [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/bender-bouncer-cli.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/bender-bouncer-cli.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | / if !args.flag_json{ [INFO] [stderr] 69 | | if !args.flag_only_valid{ [INFO] [stderr] 70 | | // Error: print path [INFO] [stderr] 71 | | let mut fname = format!(" ✖ {} ", path).bold().on_red(); [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | if !args.flag_json && !args.flag_only_valid { [INFO] [stderr] 69 | // Error: print path [INFO] [stderr] 70 | let mut fname = format!(" ✖ {} ", path).bold().on_red(); [INFO] [stderr] 71 | if args.flag_no_colors{ fname = fname.clear() ;}; [INFO] [stderr] 72 | println!("{}", fname); [INFO] [stderr] 73 | if !args.flag_basic{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/bender-bouncer-cli.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/bender-bouncer-cli.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | / if !args.flag_json{ [INFO] [stderr] 69 | | if !args.flag_only_valid{ [INFO] [stderr] 70 | | // Error: print path [INFO] [stderr] 71 | | let mut fname = format!(" ✖ {} ", path).bold().on_red(); [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | if !args.flag_json && !args.flag_only_valid { [INFO] [stderr] 69 | // Error: print path [INFO] [stderr] 70 | let mut fname = format!(" ✖ {} ", path).bold().on_red(); [INFO] [stderr] 71 | if args.flag_no_colors{ fname = fname.clear() ;}; [INFO] [stderr] 72 | println!("{}", fname); [INFO] [stderr] 73 | if !args.flag_basic{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.12s [INFO] running `"docker" "inspect" "61b524a2c03db47d68e6c97e341d879618a10973e5af7c083403ccf73fb783a3"` [INFO] running `"docker" "rm" "-f" "61b524a2c03db47d68e6c97e341d879618a10973e5af7c083403ccf73fb783a3"` [INFO] [stdout] 61b524a2c03db47d68e6c97e341d879618a10973e5af7c083403ccf73fb783a3