[INFO] updating cached repository atkinchris/kubesecrets
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/atkinchris/kubesecrets
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/atkinchris/kubesecrets" "work/ex/clippy-test-run/sources/stable/gh/atkinchris/kubesecrets"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/atkinchris/kubesecrets'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/atkinchris/kubesecrets" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atkinchris/kubesecrets"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atkinchris/kubesecrets'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 93a0c545d0ddf8537953cc914923ef1610bf029e
[INFO] sha for GitHub repo atkinchris/kubesecrets: 93a0c545d0ddf8537953cc914923ef1610bf029e
[INFO] validating manifest of atkinchris/kubesecrets on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of atkinchris/kubesecrets on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing atkinchris/kubesecrets
[INFO] finished frobbing atkinchris/kubesecrets
[INFO] frobbed toml for atkinchris/kubesecrets written to work/ex/clippy-test-run/sources/stable/gh/atkinchris/kubesecrets/Cargo.toml
[INFO] started frobbing atkinchris/kubesecrets
[INFO] finished frobbing atkinchris/kubesecrets
[INFO] frobbed toml for atkinchris/kubesecrets written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/atkinchris/kubesecrets/Cargo.toml
[INFO] crate atkinchris/kubesecrets has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting atkinchris/kubesecrets against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/atkinchris/kubesecrets:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7043bdbebd273d372426c95c838f573f910e95db08da454502947a9c58d02230
[INFO] running `"docker" "start" "-a" "7043bdbebd273d372426c95c838f573f910e95db08da454502947a9c58d02230"`
[INFO] [stderr]     Checking kubesecrets v0.5.1 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/kubectl.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 |   print!("{}\n", Blue.paint(stdout));
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/kubectl.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 |   print!("{}\n", Blue.paint(stdout));
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/b64.rs:14:3
[INFO] [stderr]    |
[INFO] [stderr] 14 |   return output;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/b64.rs:25:3
[INFO] [stderr]    |
[INFO] [stderr] 25 |   return output;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands.rs:95:3
[INFO] [stderr]    |
[INFO] [stderr] 95 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fs.rs:21:3
[INFO] [stderr]    |
[INFO] [stderr] 21 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/kubectl.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |   return Ok(manifest);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(manifest)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/kubectl.rs:58:3
[INFO] [stderr]    |
[INFO] [stderr] 58 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             return commands::pull(get_all, output);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commands::pull(get_all, output)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             return commands::push(input, prune);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commands::push(input, prune)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/b64.rs:14:3
[INFO] [stderr]    |
[INFO] [stderr] 14 |   return output;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/b64.rs:25:3
[INFO] [stderr]    |
[INFO] [stderr] 25 |   return output;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/b64.rs:38:7
[INFO] [stderr]    |
[INFO] [stderr] 38 | /       return tuples
[INFO] [stderr] 39 | |         .iter()
[INFO] [stderr] 40 | |         .map(|(k, v)| (k.to_string(), v.to_string()))
[INFO] [stderr] 41 | |         .collect();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 38 |       tuples
[INFO] [stderr] 39 |         .iter()
[INFO] [stderr] 40 |         .map(|(k, v)| (k.to_string(), v.to_string()))
[INFO] [stderr] 41 |         .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands.rs:95:3
[INFO] [stderr]    |
[INFO] [stderr] 95 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/fs.rs:21:3
[INFO] [stderr]    |
[INFO] [stderr] 21 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/kubectl.rs:29:3
[INFO] [stderr]    |
[INFO] [stderr] 29 |   return Ok(manifest);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(manifest)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/kubectl.rs:58:3
[INFO] [stderr]    |
[INFO] [stderr] 58 |   return Ok(());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             return commands::pull(get_all, output);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commands::pull(get_all, output)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             return commands::push(input, prune);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commands::push(input, prune)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]  --> src/b64.rs:9:37
[INFO] [stderr]   |
[INFO] [stderr] 9 |     let value = base64::decode(val).expect(&format!("Error decoding Base64 in {}", key));
[INFO] [stderr]   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error decoding Base64 in {}", key))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/b64.rs:10:42
[INFO] [stderr]    |
[INFO] [stderr] 10 |     let value_string = from_utf8(&value).expect(&format!("Error representing {} as UTF-8", key));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error representing {} as UTF-8", key))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands.rs:59:8
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if unchanged.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!unchanged.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands.rs:66:8
[INFO] [stderr]    |
[INFO] [stderr] 66 |     if added.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!added.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands.rs:73:8
[INFO] [stderr]    |
[INFO] [stderr] 73 |     if deleted.len() > 0 && prune {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!deleted.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/difference.rs:6:11
[INFO] [stderr]   |
[INFO] [stderr] 6 |   before: &'a Vec<T>,
[INFO] [stderr]   |           ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/difference.rs:7:10
[INFO] [stderr]   |
[INFO] [stderr] 7 |   after: &'a Vec<T>,
[INFO] [stderr]   |          ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]  --> src/duplicates.rs:4:24
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn find_duplicates<'a, T>(iter: T) -> Option<Vec<T::Item>>
[INFO] [stderr]   |                        ^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/fs.rs:16:3
[INFO] [stderr]    |
[INFO] [stderr] 16 | /   match file.write_all(contents.as_bytes()) {
[INFO] [stderr] 17 | |     Err(why) => panic!("couldn't write to {}: {}", display, why.description()),
[INFO] [stderr] 18 | |     Ok(_) => (),
[INFO] [stderr] 19 | |   }
[INFO] [stderr]    | |___^ help: try this: `if let Err(why) = file.write_all(contents.as_bytes()) { panic!("couldn't write to {}: {}", display, why.description()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]  --> src/b64.rs:9:37
[INFO] [stderr]   |
[INFO] [stderr] 9 |     let value = base64::decode(val).expect(&format!("Error decoding Base64 in {}", key));
[INFO] [stderr]   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error decoding Base64 in {}", key))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/b64.rs:10:42
[INFO] [stderr]    |
[INFO] [stderr] 10 |     let value_string = from_utf8(&value).expect(&format!("Error representing {} as UTF-8", key));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error representing {} as UTF-8", key))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands.rs:59:8
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if unchanged.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!unchanged.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands.rs:66:8
[INFO] [stderr]    |
[INFO] [stderr] 66 |     if added.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!added.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands.rs:73:8
[INFO] [stderr]    |
[INFO] [stderr] 73 |     if deleted.len() > 0 && prune {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!deleted.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/difference.rs:6:11
[INFO] [stderr]   |
[INFO] [stderr] 6 |   before: &'a Vec<T>,
[INFO] [stderr]   |           ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/difference.rs:7:10
[INFO] [stderr]   |
[INFO] [stderr] 7 |   after: &'a Vec<T>,
[INFO] [stderr]   |          ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]  --> src/duplicates.rs:4:24
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn find_duplicates<'a, T>(iter: T) -> Option<Vec<T::Item>>
[INFO] [stderr]   |                        ^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/fs.rs:16:3
[INFO] [stderr]    |
[INFO] [stderr] 16 | /   match file.write_all(contents.as_bytes()) {
[INFO] [stderr] 17 | |     Err(why) => panic!("couldn't write to {}: {}", display, why.description()),
[INFO] [stderr] 18 | |     Ok(_) => (),
[INFO] [stderr] 19 | |   }
[INFO] [stderr]    | |___^ help: try this: `if let Err(why) = file.write_all(contents.as_bytes()) { panic!("couldn't write to {}: {}", display, why.description()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.12s
[INFO] running `"docker" "inspect" "7043bdbebd273d372426c95c838f573f910e95db08da454502947a9c58d02230"`
[INFO] running `"docker" "rm" "-f" "7043bdbebd273d372426c95c838f573f910e95db08da454502947a9c58d02230"`
[INFO] [stdout] 7043bdbebd273d372426c95c838f573f910e95db08da454502947a9c58d02230