[INFO] updating cached repository athorwall/parser-combinators [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/athorwall/parser-combinators [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/athorwall/parser-combinators" "work/ex/clippy-test-run/sources/stable/gh/athorwall/parser-combinators"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/athorwall/parser-combinators'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/athorwall/parser-combinators" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/athorwall/parser-combinators"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/athorwall/parser-combinators'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9dc572158cc0e1493cb8b3c0637a4d8d7013b8b [INFO] sha for GitHub repo athorwall/parser-combinators: e9dc572158cc0e1493cb8b3c0637a4d8d7013b8b [INFO] validating manifest of athorwall/parser-combinators on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of athorwall/parser-combinators on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing athorwall/parser-combinators [INFO] finished frobbing athorwall/parser-combinators [INFO] frobbed toml for athorwall/parser-combinators written to work/ex/clippy-test-run/sources/stable/gh/athorwall/parser-combinators/Cargo.toml [INFO] started frobbing athorwall/parser-combinators [INFO] finished frobbing athorwall/parser-combinators [INFO] frobbed toml for athorwall/parser-combinators written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/athorwall/parser-combinators/Cargo.toml [INFO] crate athorwall/parser-combinators has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting athorwall/parser-combinators against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/athorwall/parser-combinators:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8e00ff93824136c1c896c3bf2bfd91430909b78fbbdb9cd8c8cd95525d73919 [INFO] running `"docker" "start" "-a" "b8e00ff93824136c1c896c3bf2bfd91430909b78fbbdb9cd8c8cd95525d73919"` [INFO] [stderr] Checking parser-combinators v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / return results.iter() [INFO] [stderr] 29 | | .map(|(u, rest)| { [INFO] [stderr] 30 | | (func(u), rest.clone()) [INFO] [stderr] 31 | | }) [INFO] [stderr] 32 | | .collect(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | results.iter() [INFO] [stderr] 29 | .map(|(u, rest)| { [INFO] [stderr] 30 | (func(u), rest.clone()) [INFO] [stderr] 31 | }) [INFO] [stderr] 32 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/parser.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | Some(value) => { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `new_input` [INFO] [stderr] --> src/parser.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | let mut new_input = input.clone(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_new_input` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | struct Parser<'a, T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse` [INFO] [stderr] --> src/parser.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse(&self, input: &String) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `map` [INFO] [stderr] --> src/parser.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn map(self, func: Box U>) -> Parser<'a, U> where T: 'a, U: 'a { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `one` [INFO] [stderr] --> src/parser.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn one(t: char) -> Parser<'a, char> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `combine` [INFO] [stderr] --> src/parser.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn combine<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stderr] 63 | | where U: Copy + 'b { [INFO] [stderr] 64 | | Parser{ [INFO] [stderr] 65 | | f: Box::from(move |input: &String| { [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `option` [INFO] [stderr] --> src/parser.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / pub fn option<'b, U>(p1: Parser<'b, U>, p2: Parser<'b, U>) -> Parser<'b, U> [INFO] [stderr] 76 | | where U: Copy + 'b { [INFO] [stderr] 77 | | Parser{ [INFO] [stderr] 78 | | f: Box::from(move |input: &String| { [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/parser.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn bind<'b, U, V>(p1: Parser<'b, U>, p2: Box Parser<'b, V>>) -> Parser<'b, V> [INFO] [stderr] 91 | | where U: Copy + 'b, V: 'b { [INFO] [stderr] 92 | | Parser{ [INFO] [stderr] 93 | | f: Box::from(move |input: &String| { [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse(&self, input: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | if remaining.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / return results.iter() [INFO] [stderr] 29 | | .map(|(u, rest)| { [INFO] [stderr] 30 | | (func(u), rest.clone()) [INFO] [stderr] 31 | | }) [INFO] [stderr] 32 | | .collect(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | results.iter() [INFO] [stderr] 29 | .map(|(u, rest)| { [INFO] [stderr] 30 | (func(u), rest.clone()) [INFO] [stderr] 31 | }) [INFO] [stderr] 32 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/parser.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | Some(value) => { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `new_input` [INFO] [stderr] --> src/parser.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | let mut new_input = input.clone(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_new_input` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | let mut s = a.to_string(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | let mut s = a.to_string(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse(&self, input: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | if remaining.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.53s [INFO] running `"docker" "inspect" "b8e00ff93824136c1c896c3bf2bfd91430909b78fbbdb9cd8c8cd95525d73919"` [INFO] running `"docker" "rm" "-f" "b8e00ff93824136c1c896c3bf2bfd91430909b78fbbdb9cd8c8cd95525d73919"` [INFO] [stdout] b8e00ff93824136c1c896c3bf2bfd91430909b78fbbdb9cd8c8cd95525d73919