[INFO] updating cached repository asymmetric/rusty-chain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asymmetric/rusty-chain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asymmetric/rusty-chain" "work/ex/clippy-test-run/sources/stable/gh/asymmetric/rusty-chain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asymmetric/rusty-chain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asymmetric/rusty-chain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asymmetric/rusty-chain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asymmetric/rusty-chain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ffb29dddedc1186fadd07f87ec3e8ae619c0d858 [INFO] sha for GitHub repo asymmetric/rusty-chain: ffb29dddedc1186fadd07f87ec3e8ae619c0d858 [INFO] validating manifest of asymmetric/rusty-chain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asymmetric/rusty-chain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asymmetric/rusty-chain [INFO] finished frobbing asymmetric/rusty-chain [INFO] frobbed toml for asymmetric/rusty-chain written to work/ex/clippy-test-run/sources/stable/gh/asymmetric/rusty-chain/Cargo.toml [INFO] started frobbing asymmetric/rusty-chain [INFO] finished frobbing asymmetric/rusty-chain [INFO] frobbed toml for asymmetric/rusty-chain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asymmetric/rusty-chain/Cargo.toml [INFO] crate asymmetric/rusty-chain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asymmetric/rusty-chain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/asymmetric/rusty-chain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] acea58fcb2e860cba788b184c430416d6088b6d2847fd9b2d2d295f88f420c96 [INFO] running `"docker" "start" "-a" "acea58fcb2e860cba788b184c430416d6088b6d2847fd9b2d2d295f88f420c96"` [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking rusty-chain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/mod.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | difficulty: difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difficulty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/mod.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | difficulty: difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difficulty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | / return [ [INFO] [stderr] 4 | | val as u8, [INFO] [stderr] 5 | | (val >> 8) as u8, [INFO] [stderr] 6 | | (val >> 16) as u8, [INFO] [stderr] ... | [INFO] [stderr] 11 | | (val >> 56) as u8, [INFO] [stderr] 12 | | ] [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 3 | [ [INFO] [stderr] 4 | val as u8, [INFO] [stderr] 5 | (val >> 8) as u8, [INFO] [stderr] 6 | (val >> 16) as u8, [INFO] [stderr] 7 | (val >> 24) as u8, [INFO] [stderr] 8 | (val >> 32) as u8, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | / return [ [INFO] [stderr] 4 | | val as u8, [INFO] [stderr] 5 | | (val >> 8) as u8, [INFO] [stderr] 6 | | (val >> 16) as u8, [INFO] [stderr] ... | [INFO] [stderr] 11 | | (val >> 56) as u8, [INFO] [stderr] 12 | | ] [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 3 | [ [INFO] [stderr] 4 | val as u8, [INFO] [stderr] 5 | (val >> 8) as u8, [INFO] [stderr] 6 | (val >> 16) as u8, [INFO] [stderr] 7 | (val >> 24) as u8, [INFO] [stderr] 8 | (val >> 32) as u8, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | difficulty: difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difficulty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | difficulty: difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difficulty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.78s [INFO] running `"docker" "inspect" "acea58fcb2e860cba788b184c430416d6088b6d2847fd9b2d2d295f88f420c96"` [INFO] running `"docker" "rm" "-f" "acea58fcb2e860cba788b184c430416d6088b6d2847fd9b2d2d295f88f420c96"` [INFO] [stdout] acea58fcb2e860cba788b184c430416d6088b6d2847fd9b2d2d295f88f420c96