[INFO] updating cached repository aswaving/netcat-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aswaving/netcat-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aswaving/netcat-rs" "work/ex/clippy-test-run/sources/stable/gh/aswaving/netcat-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aswaving/netcat-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aswaving/netcat-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aswaving/netcat-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aswaving/netcat-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b7e599b2baa2d79d26bdb4efb21acb0d777ae028 [INFO] sha for GitHub repo aswaving/netcat-rs: b7e599b2baa2d79d26bdb4efb21acb0d777ae028 [INFO] validating manifest of aswaving/netcat-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aswaving/netcat-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aswaving/netcat-rs [INFO] finished frobbing aswaving/netcat-rs [INFO] frobbed toml for aswaving/netcat-rs written to work/ex/clippy-test-run/sources/stable/gh/aswaving/netcat-rs/Cargo.toml [INFO] started frobbing aswaving/netcat-rs [INFO] finished frobbing aswaving/netcat-rs [INFO] frobbed toml for aswaving/netcat-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aswaving/netcat-rs/Cargo.toml [INFO] crate aswaving/netcat-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aswaving/netcat-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aswaving/netcat-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b9b9ee1e8cb552e880c7a993e8f45ef6d3df8050b5d3b72373195c2fb7b4fa6 [INFO] running `"docker" "start" "-a" "1b9b9ee1e8cb552e880c7a993e8f45ef6d3df8050b5d3b72373195c2fb7b4fa6"` [INFO] [stderr] Checking netcat-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iopoll.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iopoll.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `SocketAddr` [INFO] [stderr] --> src/main.rs:13:51 [INFO] [stderr] | [INFO] [stderr] 13 | use std::net::{TcpStream, TcpListener, UdpSocket, SocketAddr}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SocketAddr` [INFO] [stderr] --> src/main.rs:13:51 [INFO] [stderr] | [INFO] [stderr] 13 | use std::net::{TcpStream, TcpListener, UdpSocket, SocketAddr}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/iopoll.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | fn error(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stream_id` [INFO] [stderr] --> src/iopoll.rs:20:53 [INFO] [stderr] | [INFO] [stderr] 20 | fn error(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^ help: consider using `_stream_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/iopoll.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | fn hangup(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stream_id` [INFO] [stderr] --> src/iopoll.rs:21:54 [INFO] [stderr] | [INFO] [stderr] 21 | fn hangup(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^ help: consider using `_stream_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/iopoll.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn timeout(&mut self, event_loop: &mut EventLoop) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nr` [INFO] [stderr] --> src/iopoll.rs:195:26 [INFO] [stderr] | [INFO] [stderr] 195 | for (nr, &(fd, eventset)) in bla.iter().enumerate() { [INFO] [stderr] | ^^ help: consider using `_nr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stdin_stream` [INFO] [stderr] --> src/iopoll.rs:248:38 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn register_stdin(&mut self, stdin_stream: &Stdin) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_stdin_stream` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/iopoll.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let mut result = Ok(()); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn is_readable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn is_high_prio_readable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn is_writable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_not_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn is_error(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn is_hangup(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/iopoll.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | fn error(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stream_id` [INFO] [stderr] --> src/iopoll.rs:20:53 [INFO] [stderr] | [INFO] [stderr] 20 | fn error(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^ help: consider using `_stream_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/iopoll.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | fn hangup(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stream_id` [INFO] [stderr] --> src/iopoll.rs:21:54 [INFO] [stderr] | [INFO] [stderr] 21 | fn hangup(&mut self, event_loop: &mut EventLoop, stream_id: Token) {} [INFO] [stderr] | ^^^^^^^^^ help: consider using `_stream_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/iopoll.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn timeout(&mut self, event_loop: &mut EventLoop) {} [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nr` [INFO] [stderr] --> src/iopoll.rs:195:26 [INFO] [stderr] | [INFO] [stderr] 195 | for (nr, &(fd, eventset)) in bla.iter().enumerate() { [INFO] [stderr] | ^^ help: consider using `_nr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stdin_stream` [INFO] [stderr] --> src/iopoll.rs:248:38 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn register_stdin(&mut self, stdin_stream: &Stdin) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_stdin_stream` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/iopoll.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let mut result = Ok(()); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn is_readable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn is_high_prio_readable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn is_writable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_not_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn is_error(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn is_hangup(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iopoll.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "1b9b9ee1e8cb552e880c7a993e8f45ef6d3df8050b5d3b72373195c2fb7b4fa6"` [INFO] running `"docker" "rm" "-f" "1b9b9ee1e8cb552e880c7a993e8f45ef6d3df8050b5d3b72373195c2fb7b4fa6"` [INFO] [stdout] 1b9b9ee1e8cb552e880c7a993e8f45ef6d3df8050b5d3b72373195c2fb7b4fa6