[INFO] updating cached repository astrojhgu/test_vp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/astrojhgu/test_vp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/astrojhgu/test_vp" "work/ex/clippy-test-run/sources/stable/gh/astrojhgu/test_vp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/astrojhgu/test_vp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/astrojhgu/test_vp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/astrojhgu/test_vp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/astrojhgu/test_vp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa5107b0ad017dd0aaa608d6f609715ea045f2f3 [INFO] sha for GitHub repo astrojhgu/test_vp: aa5107b0ad017dd0aaa608d6f609715ea045f2f3 [INFO] validating manifest of astrojhgu/test_vp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of astrojhgu/test_vp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing astrojhgu/test_vp [INFO] finished frobbing astrojhgu/test_vp [INFO] frobbed toml for astrojhgu/test_vp written to work/ex/clippy-test-run/sources/stable/gh/astrojhgu/test_vp/Cargo.toml [INFO] started frobbing astrojhgu/test_vp [INFO] finished frobbing astrojhgu/test_vp [INFO] frobbed toml for astrojhgu/test_vp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/astrojhgu/test_vp/Cargo.toml [INFO] crate astrojhgu/test_vp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting astrojhgu/test_vp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/astrojhgu/test_vp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e9caa19d8401f11edc481de3373746455a7953301409383a7bb0c7315e3e911 [INFO] running `"docker" "start" "-a" "1e9caa19d8401f11edc481de3373746455a7953301409383a7bb0c7315e3e911"` [INFO] [stderr] Checking vpsearch v1.3.4 [INFO] [stderr] Checking test_vp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | SphCoord{pol:pol, az:az} [INFO] [stderr] | ^^^^^^^ help: replace it with: `pol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | SphCoord{pol:pol, az:az} [INFO] [stderr] | ^^^^^ help: replace it with: `az` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | ReturnNNearestIdx{n:n, candidates:BinaryHeap::>::new()} [INFO] [stderr] | ^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | SphCoord{pol:pol, az:az} [INFO] [stderr] | ^^^^^^^ help: replace it with: `pol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | SphCoord{pol:pol, az:az} [INFO] [stderr] | ^^^^^ help: replace it with: `az` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | ReturnNNearestIdx{n:n, candidates:BinaryHeap::>::new()} [INFO] [stderr] | ^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/main.rs:178:56 [INFO] [stderr] | [INFO] [stderr] 178 | SphCoord::new(90_f64.to_radians(), -90_f64.to_radians()),//note this [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(90_f64.to_radians())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/main.rs:178:56 [INFO] [stderr] | [INFO] [stderr] 178 | SphCoord::new(90_f64.to_radians(), -90_f64.to_radians()),//note this [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(90_f64.to_radians())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / match comp_res{ [INFO] [stderr] 144 | | CompareResult::ACCEPTED => { [INFO] [stderr] 145 | | //if accepted [INFO] [stderr] 146 | | if self.candidates.len()>=self.n { [INFO] [stderr] ... | [INFO] [stderr] 154 | | _ => ()//otherwise, do nothing [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let CompareResult::ACCEPTED = comp_res { [INFO] [stderr] 144 | //if accepted [INFO] [stderr] 145 | if self.candidates.len()>=self.n { [INFO] [stderr] 146 | //if enough points have been collected [INFO] [stderr] 147 | //drop the farthest one in the candidate list [INFO] [stderr] 148 | self.candidates.pop(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / match comp_res{ [INFO] [stderr] 144 | | CompareResult::ACCEPTED => { [INFO] [stderr] 145 | | //if accepted [INFO] [stderr] 146 | | if self.candidates.len()>=self.n { [INFO] [stderr] ... | [INFO] [stderr] 154 | | _ => ()//otherwise, do nothing [INFO] [stderr] 155 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let CompareResult::ACCEPTED = comp_res { [INFO] [stderr] 144 | //if accepted [INFO] [stderr] 145 | if self.candidates.len()>=self.n { [INFO] [stderr] 146 | //if enough points have been collected [INFO] [stderr] 147 | //drop the farthest one in the candidate list [INFO] [stderr] 148 | self.candidates.pop(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:213:34 [INFO] [stderr] | [INFO] [stderr] 213 | let az = (az_max - az_min) / (naz as f64) * (j as f64) + az_min; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(naz)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:213:49 [INFO] [stderr] | [INFO] [stderr] 213 | let az = (az_max - az_min) / (naz as f64) * (j as f64) + az_min; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:213:34 [INFO] [stderr] | [INFO] [stderr] 213 | let az = (az_max - az_min) / (naz as f64) * (j as f64) + az_min; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(naz)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:213:49 [INFO] [stderr] | [INFO] [stderr] 213 | let az = (az_max - az_min) / (naz as f64) * (j as f64) + az_min; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `"docker" "inspect" "1e9caa19d8401f11edc481de3373746455a7953301409383a7bb0c7315e3e911"` [INFO] running `"docker" "rm" "-f" "1e9caa19d8401f11edc481de3373746455a7953301409383a7bb0c7315e3e911"` [INFO] [stdout] 1e9caa19d8401f11edc481de3373746455a7953301409383a7bb0c7315e3e911