[INFO] updating cached repository astlouisf/krampus [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/astlouisf/krampus [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/astlouisf/krampus" "work/ex/clippy-test-run/sources/stable/gh/astlouisf/krampus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/astlouisf/krampus'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/astlouisf/krampus" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/astlouisf/krampus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/astlouisf/krampus'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c271dc04b014aaa64dab4bf2fb1646bb7d8d0910 [INFO] sha for GitHub repo astlouisf/krampus: c271dc04b014aaa64dab4bf2fb1646bb7d8d0910 [INFO] validating manifest of astlouisf/krampus on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of astlouisf/krampus on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing astlouisf/krampus [INFO] finished frobbing astlouisf/krampus [INFO] frobbed toml for astlouisf/krampus written to work/ex/clippy-test-run/sources/stable/gh/astlouisf/krampus/Cargo.toml [INFO] started frobbing astlouisf/krampus [INFO] finished frobbing astlouisf/krampus [INFO] frobbed toml for astlouisf/krampus written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/astlouisf/krampus/Cargo.toml [INFO] crate astlouisf/krampus has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting astlouisf/krampus against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/astlouisf/krampus:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e516fd13260f7732cc96f7620495b079d80d59eeedc58ccb0dff0cb9f63f5be6 [INFO] running `"docker" "start" "-a" "e516fd13260f7732cc96f7620495b079d80d59eeedc58ccb0dff0cb9f63f5be6"` [INFO] [stderr] Checking csv-core v0.1.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking openssl v0.9.21 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking handlebars v0.29.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking lettre v0.7.0 [INFO] [stderr] Checking krampus v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|((from, to), themes)| Match { from: from, to: to, themes: themes }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:57 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|((from, to), themes)| Match { from: from, to: to, themes: themes }) [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:65 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|((from, to), themes)| Match { from: from, to: to, themes: themes }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `themes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|((from, to), themes)| Match { from: from, to: to, themes: themes }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:57 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|((from, to), themes)| Match { from: from, to: to, themes: themes }) [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:65 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|((from, to), themes)| Match { from: from, to: to, themes: themes }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `themes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `lettre::smtp::SUBMISSION_PORT` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use lettre::smtp::SUBMISSION_PORT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | Some(n) => panic!("Not enough themes"), [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sender` [INFO] [stderr] --> src/main.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | let mut sender = FileEmailTransport::new(dir); [INFO] [stderr] | ^^^^^^ help: consider using `_sender` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `lettre::smtp::SUBMISSION_PORT` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use lettre::smtp::SUBMISSION_PORT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let mut emails : Vec = matches [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let mut sender = FileEmailTransport::new(dir); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | handlebars.register_template_file(template_name, template_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | mailer.send(&email); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | Some(n) => panic!("Not enough themes"), [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sender` [INFO] [stderr] --> src/main.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | let mut sender = FileEmailTransport::new(dir); [INFO] [stderr] | ^^^^^^ help: consider using `_sender` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let mut emails : Vec = matches [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let mut sender = FileEmailTransport::new(dir); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | handlebars.register_template_file(template_name, template_file); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | mailer.send(&email); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.15s [INFO] running `"docker" "inspect" "e516fd13260f7732cc96f7620495b079d80d59eeedc58ccb0dff0cb9f63f5be6"` [INFO] running `"docker" "rm" "-f" "e516fd13260f7732cc96f7620495b079d80d59eeedc58ccb0dff0cb9f63f5be6"` [INFO] [stdout] e516fd13260f7732cc96f7620495b079d80d59eeedc58ccb0dff0cb9f63f5be6