[INFO] updating cached repository asp2insp/AdventOfCode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asp2insp/AdventOfCode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asp2insp/AdventOfCode" "work/ex/clippy-test-run/sources/stable/gh/asp2insp/AdventOfCode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asp2insp/AdventOfCode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asp2insp/AdventOfCode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asp2insp/AdventOfCode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asp2insp/AdventOfCode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebcdb7d7ceb4befab570953fa1d0f6c4bd087080 [INFO] sha for GitHub repo asp2insp/AdventOfCode: ebcdb7d7ceb4befab570953fa1d0f6c4bd087080 [INFO] validating manifest of asp2insp/AdventOfCode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asp2insp/AdventOfCode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asp2insp/AdventOfCode [INFO] finished frobbing asp2insp/AdventOfCode [INFO] frobbed toml for asp2insp/AdventOfCode written to work/ex/clippy-test-run/sources/stable/gh/asp2insp/AdventOfCode/Cargo.toml [INFO] started frobbing asp2insp/AdventOfCode [INFO] finished frobbing asp2insp/AdventOfCode [INFO] frobbed toml for asp2insp/AdventOfCode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asp2insp/AdventOfCode/Cargo.toml [INFO] crate asp2insp/AdventOfCode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asp2insp/AdventOfCode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/asp2insp/AdventOfCode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3174b379feefb45b6a6cc5d1bfcafbff4f29b2bd32181c9f3d67a5f8c154625c [INFO] running `"docker" "start" "-a" "3174b379feefb45b6a6cc5d1bfcafbff4f29b2bd32181c9f3d67a5f8c154625c"` [INFO] [stderr] Checking owning_ref v0.2.2 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking backtrace-sys v0.1.5 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Compiling aoc-runner-derive v0.1.1 [INFO] [stderr] Checking backtrace v0.1.8 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking debugtrace v0.1.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking parking_lot_core v0.2.0 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking chomp v0.3.1 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking parking_lot v0.3.6 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day15.rs:165:28 [INFO] [stderr] | [INFO] [stderr] 165 | let p = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day15.rs:165:34 [INFO] [stderr] | [INFO] [stderr] 165 | let p = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day15.rs:165:28 [INFO] [stderr] | [INFO] [stderr] 165 | let p = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day15.rs:165:34 [INFO] [stderr] | [INFO] [stderr] 165 | let p = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/day15.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | units.iter_mut().find(|u| u.loc == att).map(|u| u.hp -= AP); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(u) = units.iter_mut().find(|u| u.loc == att) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/day15.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | units.iter().filter(|u| u.loc.e(x,y)).next().map(Unit::print).unwrap_or(map[y][x]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|u| u.loc.e(x,y)).next()` with `find(|u| u.loc.e(x,y))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match args.next() { [INFO] [stderr] 40 | | Some(s) => { [INFO] [stderr] 41 | | match s.as_str() { [INFO] [stderr] 42 | | "1" => run_one = true, [INFO] [stderr] ... | [INFO] [stderr] 47 | | None => {}, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = args.next() { run_day!(day15); }` [INFO] [stderr] ... [INFO] [stderr] 71 | run_day!(day15); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match args.next() { [INFO] [stderr] 50 | | Some(s) => { [INFO] [stderr] 51 | | match s.as_str() { [INFO] [stderr] 52 | | "1" => run_one = true, [INFO] [stderr] ... | [INFO] [stderr] 57 | | None => {}, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = args.next() { run_day!(day15); }` [INFO] [stderr] ... [INFO] [stderr] 71 | run_day!(day15); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/day15.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | units.iter_mut().find(|u| u.loc == att).map(|u| u.hp -= AP); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(u) = units.iter_mut().find(|u| u.loc == att) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/day15.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | units.iter().filter(|u| u.loc.e(x,y)).next().map(Unit::print).unwrap_or(map[y][x]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|u| u.loc.e(x,y)).next()` with `find(|u| u.loc.e(x,y))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match args.next() { [INFO] [stderr] 40 | | Some(s) => { [INFO] [stderr] 41 | | match s.as_str() { [INFO] [stderr] 42 | | "1" => run_one = true, [INFO] [stderr] ... | [INFO] [stderr] 47 | | None => {}, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = args.next() { run_day!(day15); }` [INFO] [stderr] ... [INFO] [stderr] 71 | run_day!(day15); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match args.next() { [INFO] [stderr] 50 | | Some(s) => { [INFO] [stderr] 51 | | match s.as_str() { [INFO] [stderr] 52 | | "1" => run_one = true, [INFO] [stderr] ... | [INFO] [stderr] 57 | | None => {}, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(s) = args.next() { run_day!(day15); }` [INFO] [stderr] ... [INFO] [stderr] 71 | run_day!(day15); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.22s [INFO] running `"docker" "inspect" "3174b379feefb45b6a6cc5d1bfcafbff4f29b2bd32181c9f3d67a5f8c154625c"` [INFO] running `"docker" "rm" "-f" "3174b379feefb45b6a6cc5d1bfcafbff4f29b2bd32181c9f3d67a5f8c154625c"` [INFO] [stdout] 3174b379feefb45b6a6cc5d1bfcafbff4f29b2bd32181c9f3d67a5f8c154625c