[INFO] updating cached repository asmoaesl/term3d [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/asmoaesl/term3d [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/asmoaesl/term3d" "work/ex/clippy-test-run/sources/stable/gh/asmoaesl/term3d"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/asmoaesl/term3d'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/asmoaesl/term3d" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/term3d"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/term3d'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 952e8761226b5a7b23f309dd1a2116b6f0d9c10b [INFO] sha for GitHub repo asmoaesl/term3d: 952e8761226b5a7b23f309dd1a2116b6f0d9c10b [INFO] validating manifest of asmoaesl/term3d on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asmoaesl/term3d on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asmoaesl/term3d [INFO] finished frobbing asmoaesl/term3d [INFO] frobbed toml for asmoaesl/term3d written to work/ex/clippy-test-run/sources/stable/gh/asmoaesl/term3d/Cargo.toml [INFO] started frobbing asmoaesl/term3d [INFO] finished frobbing asmoaesl/term3d [INFO] frobbed toml for asmoaesl/term3d written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/asmoaesl/term3d/Cargo.toml [INFO] crate asmoaesl/term3d has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asmoaesl/term3d against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/asmoaesl/term3d:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 094de32ffe9d1b16a8db7ff094ed4f3ae483f34e02a935c5134ca1a3836c1033 [INFO] running `"docker" "start" "-a" "094de32ffe9d1b16a8db7ff094ed4f3ae483f34e02a935c5134ca1a3836c1033"` [INFO] [stderr] Compiling ncurses v5.97.0 [INFO] [stderr] Checking pancurses v0.16.0 [INFO] [stderr] Checking easycurses v0.12.1 [INFO] [stderr] Checking term3d v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 66 | | if y0 > y1 { [INFO] [stderr] 67 | | draw_line_high(e, x1, y1, x0, y0); [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | draw_line_high(e, x0, y0, x1, y1); [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | } else if y0 > y1 { [INFO] [stderr] 66 | draw_line_high(e, x1, y1, x0, y0); [INFO] [stderr] 67 | } else { [INFO] [stderr] 68 | draw_line_high(e, x0, y0, x1, y1); [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:322:64 [INFO] [stderr] | [INFO] [stderr] 322 | + ((elapsed_after_updates.subsec_nanos() as f32) / 1000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `verts` [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let verts = [ [INFO] [stderr] | ^^^^^ help: consider using `_verts` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `faces` [INFO] [stderr] --> src/main.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | let faces = [ [INFO] [stderr] | ^^^^^ help: consider using `_faces` instead [INFO] [stderr] [INFO] [stderr] warning: variable `cx` is assigned to, but never used [INFO] [stderr] --> src/main.rs:234:14 [INFO] [stderr] | [INFO] [stderr] 234 | let (mut cx, mut cy) = (w as f32 / 2., h as f32 / 2.); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_cx` instead [INFO] [stderr] [INFO] [stderr] warning: variable `cy` is assigned to, but never used [INFO] [stderr] --> src/main.rs:234:22 [INFO] [stderr] | [INFO] [stderr] 234 | let (mut cx, mut cy) = (w as f32 / 2., h as f32 / 2.); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_cy` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cx` is never read [INFO] [stderr] --> src/main.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | cx = w as f32 / 2.; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cy` is never read [INFO] [stderr] --> src/main.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | cy = h as f32 / 2.; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:104:10 [INFO] [stderr] | [INFO] [stderr] 104 | let (mut y1, mut y2, mut y3); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | let (mut y1, mut y2, mut y3); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | let (mut y1, mut y2, mut y3); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rotate_2d` [INFO] [stderr] --> src/main.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | fn rotate_2d(pos: (f32, f32), rad: f32) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:65:12 [INFO] [stderr] | [INFO] [stderr] 65 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 66 | | if y0 > y1 { [INFO] [stderr] 67 | | draw_line_high(e, x1, y1, x0, y0); [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | draw_line_high(e, x0, y0, x1, y1); [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | } else if y0 > y1 { [INFO] [stderr] 66 | draw_line_high(e, x1, y1, x0, y0); [INFO] [stderr] 67 | } else { [INFO] [stderr] 68 | draw_line_high(e, x0, y0, x1, y1); [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:322:64 [INFO] [stderr] | [INFO] [stderr] 322 | + ((elapsed_after_updates.subsec_nanos() as f32) / 1000000000.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `verts` [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let verts = [ [INFO] [stderr] | ^^^^^ help: consider using `_verts` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `faces` [INFO] [stderr] --> src/main.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | let faces = [ [INFO] [stderr] | ^^^^^ help: consider using `_faces` instead [INFO] [stderr] [INFO] [stderr] warning: variable `cx` is assigned to, but never used [INFO] [stderr] --> src/main.rs:234:14 [INFO] [stderr] | [INFO] [stderr] 234 | let (mut cx, mut cy) = (w as f32 / 2., h as f32 / 2.); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_cx` instead [INFO] [stderr] [INFO] [stderr] warning: variable `cy` is assigned to, but never used [INFO] [stderr] --> src/main.rs:234:22 [INFO] [stderr] | [INFO] [stderr] 234 | let (mut cx, mut cy) = (w as f32 / 2., h as f32 / 2.); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_cy` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cx` is never read [INFO] [stderr] --> src/main.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | cx = w as f32 / 2.; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cy` is never read [INFO] [stderr] --> src/main.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | cy = h as f32 / 2.; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:104:10 [INFO] [stderr] | [INFO] [stderr] 104 | let (mut y1, mut y2, mut y3); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | let (mut y1, mut y2, mut y3); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | let (mut y1, mut y2, mut y3); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rotate_2d` [INFO] [stderr] --> src/main.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | fn rotate_2d(pos: (f32, f32), rad: f32) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.38s [INFO] running `"docker" "inspect" "094de32ffe9d1b16a8db7ff094ed4f3ae483f34e02a935c5134ca1a3836c1033"` [INFO] running `"docker" "rm" "-f" "094de32ffe9d1b16a8db7ff094ed4f3ae483f34e02a935c5134ca1a3836c1033"` [INFO] [stdout] 094de32ffe9d1b16a8db7ff094ed4f3ae483f34e02a935c5134ca1a3836c1033