[INFO] updating cached repository aslamplr/scrabber [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aslamplr/scrabber [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aslamplr/scrabber" "work/ex/clippy-test-run/sources/stable/gh/aslamplr/scrabber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aslamplr/scrabber'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aslamplr/scrabber" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslamplr/scrabber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslamplr/scrabber'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 906a11f42572b3f4e8908cab258320aa072211b3 [INFO] sha for GitHub repo aslamplr/scrabber: 906a11f42572b3f4e8908cab258320aa072211b3 [INFO] validating manifest of aslamplr/scrabber on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aslamplr/scrabber on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aslamplr/scrabber [INFO] finished frobbing aslamplr/scrabber [INFO] frobbed toml for aslamplr/scrabber written to work/ex/clippy-test-run/sources/stable/gh/aslamplr/scrabber/Cargo.toml [INFO] started frobbing aslamplr/scrabber [INFO] finished frobbing aslamplr/scrabber [INFO] frobbed toml for aslamplr/scrabber written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aslamplr/scrabber/Cargo.toml [INFO] crate aslamplr/scrabber has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aslamplr/scrabber against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aslamplr/scrabber:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db9ebf5801c43cbfbf083217156efe9f72eab4510f61655e6b0e941f979fa64c [INFO] running `"docker" "start" "-a" "db9ebf5801c43cbfbf083217156efe9f72eab4510f61655e6b0e941f979fa64c"` [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking chrono v0.4.3 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking scrabber v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | if url == "" || params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | if url == "" || params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | fn get_html_from_url(url: &str, params: &ScrabParams) -> ScrabResult { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:58:41 [INFO] [stderr] | [INFO] [stderr] 58 | fn get_html_from_url(url: &str, params: &ScrabParams) -> ScrabResult { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | .filter(|y| y.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!y.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | .filter(|y| y.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!y.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.43s [INFO] running `"docker" "inspect" "db9ebf5801c43cbfbf083217156efe9f72eab4510f61655e6b0e941f979fa64c"` [INFO] running `"docker" "rm" "-f" "db9ebf5801c43cbfbf083217156efe9f72eab4510f61655e6b0e941f979fa64c"` [INFO] [stdout] db9ebf5801c43cbfbf083217156efe9f72eab4510f61655e6b0e941f979fa64c