[INFO] updating cached repository askreet/blackjack-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/askreet/blackjack-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/askreet/blackjack-rs" "work/ex/clippy-test-run/sources/stable/gh/askreet/blackjack-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/askreet/blackjack-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/askreet/blackjack-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/askreet/blackjack-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/askreet/blackjack-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 307186ad695cf05d76d84f1d3e880da1642dcbba [INFO] sha for GitHub repo askreet/blackjack-rs: 307186ad695cf05d76d84f1d3e880da1642dcbba [INFO] validating manifest of askreet/blackjack-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of askreet/blackjack-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing askreet/blackjack-rs [INFO] finished frobbing askreet/blackjack-rs [INFO] frobbed toml for askreet/blackjack-rs written to work/ex/clippy-test-run/sources/stable/gh/askreet/blackjack-rs/Cargo.toml [INFO] started frobbing askreet/blackjack-rs [INFO] finished frobbing askreet/blackjack-rs [INFO] frobbed toml for askreet/blackjack-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/askreet/blackjack-rs/Cargo.toml [INFO] crate askreet/blackjack-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting askreet/blackjack-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/askreet/blackjack-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3d8efd9dbd267543a9f3053e881676a7b9a058f499fd9e0f6042df87633de62 [INFO] running `"docker" "start" "-a" "f3d8efd9dbd267543a9f3053e881676a7b9a058f499fd9e0f6042df87633de62"` [INFO] [stderr] Checking blackjack-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `card::Card` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use card::Card; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `deck::Deck` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use deck::Deck; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `card::Card` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use card::Card; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `deck::Deck` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use deck::Deck; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Card`, `Rank::*`, `Suit::*` [INFO] [stderr] --> src/deck.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | use card::{Card, Rank, Rank::*, Suit, Suit::*}; [INFO] [stderr] | ^^^^ ^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Suit::*` [INFO] [stderr] --> src/game.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | use card::{Rank::*, Suit::*}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: private type `game::Error` in public interface (error E0446) [INFO] [stderr] --> src/game.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn deal_hand(&mut self, bet: Chips) -> Result<()> { [INFO] [stderr] 39 | | self.player_money -= bet; [INFO] [stderr] 40 | | self.current_bet = bet; [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 48 | | Ok(()) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: method is never used: `of` [INFO] [stderr] --> src/deck.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn of(cards: Vec) -> Deck { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotEnoughChips` [INFO] [stderr] --> src/game.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | NotEnoughChips, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Result` [INFO] [stderr] --> src/game.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | type Result = result::Result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `deal_hand` [INFO] [stderr] --> src/game.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn deal_hand(&mut self, bet: Chips) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: private type `game::Error` in public interface (error E0446) [INFO] [stderr] --> src/game.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn deal_hand(&mut self, bet: Chips) -> Result<()> { [INFO] [stderr] 39 | | self.player_money -= bet; [INFO] [stderr] 40 | | self.current_bet = bet; [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 48 | | Ok(()) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotEnoughChips` [INFO] [stderr] --> src/game.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | NotEnoughChips, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "f3d8efd9dbd267543a9f3053e881676a7b9a058f499fd9e0f6042df87633de62"` [INFO] running `"docker" "rm" "-f" "f3d8efd9dbd267543a9f3053e881676a7b9a058f499fd9e0f6042df87633de62"` [INFO] [stdout] f3d8efd9dbd267543a9f3053e881676a7b9a058f499fd9e0f6042df87633de62