[INFO] updating cached repository ashfordneil/splice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ashfordneil/splice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ashfordneil/splice" "work/ex/clippy-test-run/sources/stable/gh/ashfordneil/splice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ashfordneil/splice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ashfordneil/splice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/splice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/splice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b574cc310a3a2d9a5d2e926398682fffdfd36b94
[INFO] sha for GitHub repo ashfordneil/splice: b574cc310a3a2d9a5d2e926398682fffdfd36b94
[INFO] validating manifest of ashfordneil/splice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ashfordneil/splice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ashfordneil/splice
[INFO] finished frobbing ashfordneil/splice
[INFO] frobbed toml for ashfordneil/splice written to work/ex/clippy-test-run/sources/stable/gh/ashfordneil/splice/Cargo.toml
[INFO] started frobbing ashfordneil/splice
[INFO] finished frobbing ashfordneil/splice
[INFO] frobbed toml for ashfordneil/splice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashfordneil/splice/Cargo.toml
[INFO] crate ashfordneil/splice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ashfordneil/splice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ashfordneil/splice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e9821cb70dd5b386469d5525ed0960827d32bd210a218152d516322e574440d2
[INFO] running `"docker" "start" "-a" "e9821cb70dd5b386469d5525ed0960827d32bd210a218152d516322e574440d2"`
[INFO] [stderr]     Checking clap v2.19.1
[INFO] [stderr]     Checking splice v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |             start: start,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             stop: stop,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `stop`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             repeated: repeated,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `repeated`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |             start: start,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |             stop: stop,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `stop`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/setup.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             repeated: repeated,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `repeated`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return &self.start;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.start`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 |         return &self.stop;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.stop`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return &mut self.input;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return self.repeated;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.repeated`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         if options.start().is_match(&buffer) {
[INFO] [stderr] 25 | |             if depth < 1 {
[INFO] [stderr] 26 | |                 depth += 1;
[INFO] [stderr] 27 | |             }
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if options.start().is_match(&buffer) && depth < 1 {
[INFO] [stderr] 25 |     depth += 1;
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 | /         match options.input().read_line(&mut buffer).unwrap() {
[INFO] [stderr] 20 | |             0 => break 'main,
[INFO] [stderr] 21 | |             _ => {}
[INFO] [stderr] 22 | |         };
[INFO] [stderr]    | |_________^ help: try this: `if let 0 = options.input().read_line(&mut buffer).unwrap() { break 'main }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return &self.start;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.start`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 |         return &self.stop;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.stop`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return &mut self.input;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.input`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/setup.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return self.repeated;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.repeated`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         if options.start().is_match(&buffer) {
[INFO] [stderr] 25 | |             if depth < 1 {
[INFO] [stderr] 26 | |                 depth += 1;
[INFO] [stderr] 27 | |             }
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if options.start().is_match(&buffer) && depth < 1 {
[INFO] [stderr] 25 |     depth += 1;
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 | /         match options.input().read_line(&mut buffer).unwrap() {
[INFO] [stderr] 20 | |             0 => break 'main,
[INFO] [stderr] 21 | |             _ => {}
[INFO] [stderr] 22 | |         };
[INFO] [stderr]    | |_________^ help: try this: `if let 0 = options.input().read_line(&mut buffer).unwrap() { break 'main }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.61s
[INFO] running `"docker" "inspect" "e9821cb70dd5b386469d5525ed0960827d32bd210a218152d516322e574440d2"`
[INFO] running `"docker" "rm" "-f" "e9821cb70dd5b386469d5525ed0960827d32bd210a218152d516322e574440d2"`
[INFO] [stdout] e9821cb70dd5b386469d5525ed0960827d32bd210a218152d516322e574440d2