[INFO] updating cached repository ashelleyPurdue/rust_prng [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ashelleyPurdue/rust_prng [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ashelleyPurdue/rust_prng" "work/ex/clippy-test-run/sources/stable/gh/ashelleyPurdue/rust_prng"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ashelleyPurdue/rust_prng'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ashelleyPurdue/rust_prng" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashelleyPurdue/rust_prng"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashelleyPurdue/rust_prng'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 948fa6b1a85743cb932169b13ec47ea1c21fc390 [INFO] sha for GitHub repo ashelleyPurdue/rust_prng: 948fa6b1a85743cb932169b13ec47ea1c21fc390 [INFO] validating manifest of ashelleyPurdue/rust_prng on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ashelleyPurdue/rust_prng on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ashelleyPurdue/rust_prng [INFO] finished frobbing ashelleyPurdue/rust_prng [INFO] frobbed toml for ashelleyPurdue/rust_prng written to work/ex/clippy-test-run/sources/stable/gh/ashelleyPurdue/rust_prng/Cargo.toml [INFO] started frobbing ashelleyPurdue/rust_prng [INFO] finished frobbing ashelleyPurdue/rust_prng [INFO] frobbed toml for ashelleyPurdue/rust_prng written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ashelleyPurdue/rust_prng/Cargo.toml [INFO] crate ashelleyPurdue/rust_prng has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ashelleyPurdue/rust_prng against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ashelleyPurdue/rust_prng:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b14b7f0ee46844a4c17467c66a0cdb4de5ea152722d98a3d6a5d1210e58f4a62 [INFO] running `"docker" "start" "-a" "b14b7f0ee46844a4c17467c66a0cdb4de5ea152722d98a3d6a5d1210e58f4a62"` [INFO] [stderr] Checking rng_struct v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/random.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/random.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return output % max; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output % max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | const LARGEST_U64_PRIME: u64 = 2305843009213693951; // Equivalent to 61 straight 1's in binary [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `2_305_843_009_213_693_951` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hashing.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | h = (h ^ (h >> 30)).wrapping_mul(0xbf58476d1ce4e5b9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbf58_476d_1ce4_e5b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:12:35 [INFO] [stderr] | [INFO] [stderr] 12 | h = (h ^ (h >> 27)).wrapping_mul(0x94d049bb133111eb); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x94d0_49bb_1331_11eb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hashing.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | return mod_exp(BASE, num, LARGEST_U64_PRIME); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mod_exp(BASE, num, LARGEST_U64_PRIME)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | const BASE: u64 = 5009424631521124603; // A huge randomly-chose prime. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `5_009_424_631_521_124_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hashing.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `seed` [INFO] [stderr] --> src/random.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | seed: u64, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `LARGEST_U64_PRIME` [INFO] [stderr] --> src/hashing.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const LARGEST_U64_PRIME: u64 = 2305843009213693951; // Equivalent to 61 straight 1's in binary [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mod_exp_hash` [INFO] [stderr] --> src/hashing.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn mod_exp_hash(num: u64) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mod_exp` [INFO] [stderr] --> src/hashing.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn mod_exp(base: u64, exp: u64, modulo: u64) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hashing.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | exp = exp >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `exp >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return output % max; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output % max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | const LARGEST_U64_PRIME: u64 = 2305843009213693951; // Equivalent to 61 straight 1's in binary [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `2_305_843_009_213_693_951` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hashing.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | h = (h ^ (h >> 30)).wrapping_mul(0xbf58476d1ce4e5b9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xbf58_476d_1ce4_e5b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:12:35 [INFO] [stderr] | [INFO] [stderr] 12 | h = (h ^ (h >> 27)).wrapping_mul(0x94d049bb133111eb); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x94d0_49bb_1331_11eb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hashing.rs:28:2 [INFO] [stderr] | [INFO] [stderr] 28 | return mod_exp(BASE, num, LARGEST_U64_PRIME); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mod_exp(BASE, num, LARGEST_U64_PRIME)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hashing.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | const BASE: u64 = 5009424631521124603; // A huge randomly-chose prime. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `5_009_424_631_521_124_603` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hashing.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `seed` [INFO] [stderr] --> src/random.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | seed: u64, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `LARGEST_U64_PRIME` [INFO] [stderr] --> src/hashing.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const LARGEST_U64_PRIME: u64 = 2305843009213693951; // Equivalent to 61 straight 1's in binary [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mod_exp_hash` [INFO] [stderr] --> src/hashing.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn mod_exp_hash(num: u64) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mod_exp` [INFO] [stderr] --> src/hashing.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn mod_exp(base: u64, exp: u64, modulo: u64) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hashing.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | exp = exp >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `exp >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "b14b7f0ee46844a4c17467c66a0cdb4de5ea152722d98a3d6a5d1210e58f4a62"` [INFO] running `"docker" "rm" "-f" "b14b7f0ee46844a4c17467c66a0cdb4de5ea152722d98a3d6a5d1210e58f4a62"` [INFO] [stdout] b14b7f0ee46844a4c17467c66a0cdb4de5ea152722d98a3d6a5d1210e58f4a62